mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-26 11:45:37 +00:00
448f596abf
Installing a Webapp is an asynchronous job, and there is a pocket of time between when web content requests to install an app and before the browser displays an installation prompt that the outer window of the content can browse away. This pocket of time is typically used by XHR to request the web app resources and verify their contents. This pocket of time is, essentially, bug 771294, and is a bit of a security problem. This problem was originally patched over on Desktop by checking in the parent process that the outer window was still at the same URI as it had been when it made the request. I'm not entirely sure if Android / B2G made similar checks. With separated content processes, however, the browser front-end can no longer performantly check to ensure that the outer window is at the same URI. We solve this problem by sending up a message in the content process when the location of an outer window making use of navigator.mozApps changes. We hold a Map of "actions" mapping to in-flight installs mapped by the outer window ID of the requesting content. When we notice a location change, we mark those actions as cancelled. When the XHR returns, we have it check the state of its actions, and if they're cancelled, it aborts further action. Normally, this wouldn't be necessary, since any XHR initiated by the content window would be cancelled once the location changed, but in this case, the XHR is occurring in Webapps.jsm, and is not influenced by the outer window of the content. --HG-- extra : rebase_source : 5f95002a21c96c5cbf3dca8ca265400448251b43 |
||
|---|---|---|
| .. | ||
| apps | ||
| chrome.ini | ||
| cross_origin.html | ||
| file_bug_779982.html | ||
| file_bug_779982.js | ||
| head.js | ||
| install_and_redirect_helper.xul | ||
| mochitest.ini | ||
| test_bug_765063.xul | ||
| test_bug_771294.xul | ||
| test_bug_779982.html | ||
| test_cross_origin.xul | ||
| test_getNotInstalled.xul | ||
| test_install_app.xul | ||
| test_install_errors.xul | ||
| test_install_utf8.xul | ||
| test_launch_paths.xul | ||
| test_list_api.xul | ||