mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-11-27 14:52:16 +00:00
2e67531735
Unmounting the top level React component will help avoid trigerring React updates when async thunk actions keep dispatching new actions after the tool is closed. This was leading to various exceptions in many React components. Also avoid a race condition where `responsiveFront` could be undefined when closing RDM while it is still initializing. Finally, ensure registering the `ResponsiveUI` immediately in `activeTabs` to prevent race condition in openIfNeeded. Adding some test coverage for such race condition, but can't enable this on verify. In chaos mode, there is too many exceptions at the test teardown. Ideally, RDM should: * only close the RDP client and let the server restore the default value on its own. i.e. we shouldn't do any request on closing. * RDM close requests should wait for previous initialization request to be done. This would avoid zillion of possible exceptions because initialization is very async and each step may throw because of things are already being destroyed. But this wouldn't address race condition when the tab is closed. So RDM should probably try to have a more resilient initialization sequence as well. Differential Revision: https://phabricator.services.mozilla.com/D197581 |
||
|---|---|---|
| .. | ||
| actions | ||
| components | ||
| docs | ||
| images | ||
| reducers | ||
| test | ||
| utils | ||
| constants.js | ||
| index.css | ||
| index.js | ||
| manager.js | ||
| moz.build | ||
| reducers.js | ||
| responsive-browser.css | ||
| store.js | ||
| toolbar.xhtml | ||
| types.js | ||
| ui.js | ||