Mike Hommey 028ad1b883 Bug 1766377 - Fix remaining sign-compare warnings in Windows builds. r=rkraesig,gsvelto,media-playback-reviewers,gfx-reviewers,bryce,sotaro ... browser/components/shell/WindowsUserChoice.cpp(233,23): error: comparison of integers of different signs: 'int' and 'const size_t' (aka 'const unsigned long long') [-Werror,-Wsign-compare] for (int j = 0; j < DWORDS_PER_BLOCK; ++j) { ~ ^ ~~~~~~~~~~~~~~~~ browser/components/shell/WindowsUserChoice.cpp(388,21): error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-compare] for (int i = 0; i < ArrayLength(exts); ++i) { ~ ^ ~~~~~~~~~~~~~~~~~ browser/components/shell/nsWindowsShellService.cpp(1225,21): error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-compare] for (int i = 0; i < ArrayLength(shortcutCSIDLs); ++i) { ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~ browser/components/shell/nsWindowsShellService.cpp(1492,21): error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-compare] for (int i = 0; i < ArrayLength(folders); ++i) { ~ ^ ~~~~~~~~~~~~~~~~~~~~ dom/media/platforms/wmf/MFTDecoder.cpp(85,23): error: comparison of integers of different signs: 'int' and 'UINT32' (aka 'unsigned int') [-Werror,-Wsign-compare] for (int i = 1; i < actsNum; i++) { ~ ^ ~~~~~~~ gfx/2d/Factory.cpp(1276,21): error: comparison of integers of different signs: 'int' and 'uint32_t' (aka 'unsigned int') [-Werror,-Wsign-compare] for (int y = 0; y < height; y++) { ~ ^ ~~~~~~ gfx/layers/d3d11/CompositorD3D11.cpp(1096,36): error: comparison of integers of different signs: 'UINT' (aka 'unsigned int') and 'int' [-Werror,-Wsign-compare] swapDesc.BufferDesc.Height == mSize.height) || ~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~ gfx/layers/d3d11/CompositorD3D11.cpp(1095,35): error: comparison of integers of different signs: 'UINT' (aka 'unsigned int') and 'int' [-Werror,-Wsign-compare] if (((swapDesc.BufferDesc.Width == mSize.width && ~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~ gfx/layers/d3d11/TextureD3D11.cpp(1278,30): error: comparison of integers of different signs: 'UINT' (aka 'unsigned int') and 'int' [-Werror,-Wsign-compare] currentDesc.Height != mSize.height || ~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~ gfx/layers/d3d11/TextureD3D11.cpp(1277,29): error: comparison of integers of different signs: 'UINT' (aka 'unsigned int') and 'int' [-Werror,-Wsign-compare] if (currentDesc.Width != mSize.width || ~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~ gfx/layers/ipc/ContentCompositorBridgeParent.cpp(248,19): error: comparison of integers of different signs: 'const uint32_t' (aka 'const unsigned int') and 'int32_t' (aka 'int') [-Werror,-Wsign-compare] if (sequenceNum == status.sequenceNumber() && !dm->HasDeviceReset()) { ~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~ gfx/thebes/D3D11Checks.cpp(129,21): error: comparison of integers of different signs: 'int' and 'unsigned int' [-Werror,-Wsign-compare] if (resultColor != 0xffffff00) { ~~~~~~~~~~~ ^ ~~~~~~~~~~ gfx/thebes/D3D11Checks.cpp(154,23): error: comparison of integers of different signs: 'int' and 'unsigned long long' [-Werror,-Wsign-compare] for (int i = 0; i < PR_ARRAY_SIZE(checkModules); i += 1) { ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~ gfx/thebes/D3D11Checks.cpp(409,14): error: comparison of integers of different signs: 'int32_t' (aka 'int') and 'UINT' (aka 'unsigned int') [-Werror,-Wsign-compare] if (vendor != desc.VendorId) { ~~~~~~ ^ ~~~~~~~~~~~~~ gfx/thebes/gfxDWriteFontList.cpp(1248,39): error: comparison of integers of different signs: 'unsigned int' and 'int' [-Werror,-Wsign-compare] addFamily(names[index], index != sysLocIndex); ~~~~~ ^ ~~~~~~~~~~~ intl/lwbrk/nsUniscribeBreaker.cpp(121,21): error: comparison of integers of different signs: 'int' and 'uint32_t' (aka 'unsigned int') [-Werror,-Wsign-compare] for (int i = 0; i < aLength; ++i) { ~ ^ ~~~~~~~ intl/lwbrk/nsUniscribeBreaker.cpp(132,23): error: comparison of integers of different signs: 'int' and 'uint32_t' (aka 'unsigned int') [-Werror,-Wsign-compare] for (int i = 0; i < aLength; ++i) { ~ ^ ~~~~~~~ intl/lwbrk/nsUniscribeBreaker.cpp(138,23): error: comparison of integers of different signs: 'int' and 'uint32_t' (aka 'unsigned int') [-Werror,-Wsign-compare] for (int i = 0; i < aLength; ++i) { ~ ^ ~~~~~~~ mozglue/misc/PreXULSkeletonUI.cpp(319,26): error: comparison of integers of different signs: 'std::basic_string<char>::size_type' (aka 'unsigned long long') and 'int' [-Werror,-Wsign-compare] while (line.length() > whitespace && ~~~~~~~~~~~~~ ^ ~~~~~~~~~~ mozglue/misc/PreXULSkeletonUI.cpp(1003,21): error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-compare] for (int i = 1; i < noPlaceholderSpans.length(); i++) { ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~ mozglue/misc/PreXULSkeletonUI.cpp(1708,21): error: comparison of integers of different signs: 'int' and 'unsigned long long' [-Werror,-Wsign-compare] for (int i = 0; i < dataLen / (2 * sizeof(double)); i++) { ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ security/sandbox/chromium-shim/sandbox/win/permissionsService.cpp(40,16): error: comparison of integers of different signs: 'int' and 'const std::basic_string<wchar_t>::size_type' (aka 'const unsigned long long') [-Werror,-Wsign-compare] if (slashIdx != std::wstring::npos) { ~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~ toolkit/components/aboutthirdparty/tests/gtest/TestAboutThirdParty.cpp(107,21): error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-compare] for (int i = 0; i < ArrayLength(kDirectoriesUnsorted); ++i) { ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ toolkit/crashreporter/breakpad-client/windows/crash_generation/crash_generation_server.cc(957,23): error: comparison of integers of different signs: 'int' and 'const size_t' (aka 'const unsigned long long') [-Werror,-Wsign-compare] for (int i = 0; i < kExceptionAppMemoryRegions; i++) { ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~ toolkit/crashreporter/client/crashreporter_win.cpp(373,21): error: comparison of integers of different signs: 'int' and 'unsigned long long' [-Werror,-Wsign-compare] for (int i = 0; i < sizeof(kDefaultAttachedBottom) / sizeof(UINT); i++) { ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ toolkit/crashreporter/client/crashreporter_win.cpp(671,21): error: comparison of integers of different signs: 'int' and 'unsigned long long' [-Werror,-Wsign-compare] for (int i = 0; i < sizeof(controls) / sizeof(controls[0]); i++) { ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ toolkit/crashreporter/client/crashreporter_win.cpp(1048,21): error: comparison of integers of different signs: 'int' and 'unsigned long long' [-Werror,-Wsign-compare] for (int i = 0; i < sizeof(kDefaultAttachedBottom) / sizeof(UINT); i++) { ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ toolkit/mozapps/defaultagent/SetDefaultBrowser.cpp(248,21): error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-compare] for (int i = 0; i < mozilla::ArrayLength(associations); ++i) { ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ toolkit/system/windowsproxy/ProxyUtils.cpp(27,36): error: comparison of integers of different signs: 'const int' and 'nsTArray_base::size_type' (aka 'unsigned long long') [-Werror,-Wsign-compare] if (i < addr.Length()) { ~ ^ ~~~~~~~~~~~~~ toolkit/xre/dllservices/mozglue/interceptor/Arm64.h(178,28): error: comparison of integers of different signs: 'int32_t' (aka 'int') and 'unsigned int' [-Werror,-Wsign-compare] if (signbits && signbits != 0xFE000000) { ~~~~~~~~ ^ ~~~~~~~~~~ obj-build/dist/include/gtest/gtest.h(1842,54): note: expanded from macro 'EXPECT_EQ' EXPECT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2) ^ obj-build/dist/include/gtest/gtest.h(1354,11): error: comparison of integers of different signs: 'const unsigned int' and 'const int' [-Werror,-Wsign-compare] if (lhs == rhs) { ~~~ ^ ~~~ obj-build/dist/include/gtest/gtest.h(1373,12): note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<unsigned int, int>' requested here return CmpHelperEQ(lhs_expression, rhs_expression, lhs, rhs); ^ toolkit/xre/dllservices/tests/gtest/TestUntrustedModules.cpp(35,5): note: in instantiation of function template specialization 'testing::internal::EqHelper::Compare<unsigned int, int, nullptr>' requested here EXPECT_EQ(mCounters.Count(), N); ^ obj-build/dist/include/gtest/gtest.h(1842,54): note: expanded from macro 'EXPECT_EQ' EXPECT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2) ^ toolkit/xre/dllservices/tests/gtest/TestUntrustedModules.cpp(210,28): note: in instantiation of function template specialization 'ModuleLoadCounter::Remains<1>' requested here EXPECT_TRUE(waitForOne.Remains({kTestModules[0]}, {0})); ^ toolkit/xre/test/gtest/TestAssembleCommandLineWin.cpp(139,21): error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-compare] for (int i = 0; i < ArrayLength(kExpectedArgsW); ++i) { ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~ toolkit/xre/test/gtest/TestAssembleCommandLineWin.cpp(151,21): error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-compare] for (int i = 0; i < ArrayLength(kExpectedArgsW); ++i) { ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~ toolkit/xre/test/gtest/TestAssembleCommandLineWin.cpp(164,21): error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-compare] for (int i = 0; i < ArrayLength(kExpectedArgsW); ++i) { ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~ obj-build/dist/include/gtest/gtest.h(1354,11): error: comparison of integers of different signs: 'const int' and 'const unsigned long long' [-Werror,-Wsign-compare] if (lhs == rhs) { ~~~ ^ ~~~ obj-build/dist/include/gtest/gtest.h(1373,12): note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<int, unsigned long long>' requested here return CmpHelperEQ(lhs_expression, rhs_expression, lhs, rhs); ^ toolkit/xre/test/gtest/TestAssembleCommandLineWin.cpp(138,3): note: in instantiation of function template specialization 'testing::internal::EqHelper::Compare<int, unsigned long long, nullptr>' requested here EXPECT_EQ(len, ArrayLength(kExpectedArgsW)); ^ widget/windows/TSFTextStore.cpp(3455,28): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'long' [-Werror,-Wsign-compare] range.mEndOffset == end - mComposition->StartOffset() && ~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ widget/windows/TSFTextStore.cpp(3454,30): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'long' [-Werror,-Wsign-compare] if (range.mStartOffset == start - mComposition->StartOffset() && ~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ xpfe/appshell/AppWindow.cpp(1900,21): error: comparison of integers of different signs: 'int' and 'uint32_t' (aka 'unsigned int') [-Werror,-Wsign-compare] for (int i = 0; i < toolbarSprings->Length(); i++) { ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~ Differential Revision: https://phabricator.services.mozilla.com/D144695		2022-04-29 09:14:12 +00:00
..
build
rust	Bug 1748718 - Part 2: Use the specified type for rust xpidl constants, r=emilio	2022-01-07 20:35:15 +00:00
test	Bug 1207753 - Add MOZ_UNANNOTATED to all Mutexes/Monitors r=nika,kershaw	2022-03-16 18:47:08 +00:00
variant
FileSystemModule.cpp
FileSystemModule.h
IStorageBindingParamsInternal.h
moz.build	Bug 1725145 - Preparation for the hybrid build env. r=necko-reviewers,firefox-build-system-reviewers,valentin,glandium	2021-08-25 10:46:17 +00:00
mozIStorageAsyncConnection.idl	Bug 1736844 - Add interrupt flag to storage service methods opening database; r=dom-storage-reviewers,mak,janv	2022-02-17 06:22:27 +00:00
mozIStorageAsyncStatement.idl
mozIStorageBaseStatement.idl
mozIStorageBindingParams.idl
mozIStorageBindingParamsArray.idl
mozIStorageCompletionCallback.idl
mozIStorageConnection.idl
mozIStorageError.idl
mozIStorageFunction.idl
mozIStoragePendingStatement.idl
mozIStorageProgressHandler.idl
mozIStorageResultSet.idl
mozIStorageRow.idl
mozIStorageService.idl	Bug 1736844 - Add interrupt flag to storage service methods opening database; r=dom-storage-reviewers,mak,janv	2022-02-17 06:22:27 +00:00
mozIStorageStatement.idl
mozIStorageStatementCallback.idl
mozIStorageVacuumParticipant.idl
mozIStorageValueArray.idl
mozStorageArgValueArray.cpp
mozStorageArgValueArray.h
mozStorageAsyncStatement.cpp
mozStorageAsyncStatement.h
mozStorageAsyncStatementExecution.cpp
mozStorageAsyncStatementExecution.h
mozStorageAsyncStatementJSHelper.cpp	Bug 1754405 part 4 - Remove JSID_TO_LINEAR_STRING. r=evilpie	2022-02-10 09:13:18 +00:00
mozStorageAsyncStatementJSHelper.h
mozStorageAsyncStatementParams.cpp
mozStorageAsyncStatementParams.h
mozStorageBindingParams.cpp
mozStorageBindingParams.h
mozStorageBindingParamsArray.cpp
mozStorageBindingParamsArray.h
mozStorageConnection.cpp	Bug 1207753 - Add MOZ_UNANNOTATED to all Mutexes/Monitors r=nika,kershaw	2022-03-16 18:47:08 +00:00
mozStorageConnection.h	Bug 1207753 - Add MOZ_UNANNOTATED to all Mutexes/Monitors r=nika,kershaw	2022-03-16 18:47:08 +00:00
mozStorageError.cpp
mozStorageError.h
mozStorageHelper.h
mozStoragePrivateHelpers.cpp
mozStoragePrivateHelpers.h
mozStorageResultSet.cpp
mozStorageResultSet.h
mozStorageRow.cpp
mozStorageRow.h
mozStorageService.cpp	Bug 1736844 - Add interrupt flag to storage service methods opening database; r=dom-storage-reviewers,mak,janv	2022-02-17 06:22:27 +00:00
mozStorageService.h	Bug 1207753 - Add MOZ_UNANNOTATED to all Mutexes/Monitors r=nika,kershaw	2022-03-16 18:47:08 +00:00
mozStorageSQLFunctions.cpp
mozStorageSQLFunctions.h
mozStorageStatement.cpp
mozStorageStatement.h
mozStorageStatementData.h
mozStorageStatementJSHelper.cpp	Bug 1754405 part 4 - Remove JSID_TO_LINEAR_STRING. r=evilpie	2022-02-10 09:13:18 +00:00
mozStorageStatementJSHelper.h
mozStorageStatementParams.cpp
mozStorageStatementParams.h
mozStorageStatementRow.cpp
mozStorageStatementRow.h
ObfuscatingVFS.cpp
SQLCollations.cpp	Bug 1719550 - Unify collator in mozStorageService and SQLCollations; r=platform-i18n-reviewers,nordzilla	2021-08-10 16:01:18 +00:00
SQLCollations.h	Bug 1719550 - Unify collator in mozStorageService and SQLCollations; r=platform-i18n-reviewers,nordzilla	2021-08-10 16:01:18 +00:00
SQLiteMutex.h
StatementCache.h
storage.h
StorageBaseStatementInternal.cpp
StorageBaseStatementInternal.h
style.txt
TelemetryVFS.cpp	Bug 1766377 - Fix remaining sign-compare warnings in Windows builds. r=rkraesig,gsvelto,media-playback-reviewers,gfx-reviewers,bryce,sotaro	2022-04-29 09:14:12 +00:00
VacuumManager.cpp
VacuumManager.h
Variant_inl.h
Variant.cpp
Variant.h
variantToSQLiteT_impl.h