Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-01-08 12:22:34 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
4a6ff21ab5
gecko-dev/dom
History
Chris Pearce 4a6ff21ab5 Bug 1473671 - Don't store persistent block permission if ESC pressed while showing permission doorhanger. r=florian 
While showing a doorhanger permisison prompt, if the user presses the ESC key
we call the secondary action callback, passing in whether any checkbox on
the popup notification was checked.

In the case of an autoplay-media permission prompt, we have a "remember"
checkbox, which is checked by default. So pressing ESC means the user will
remember a "block" result for the current site.

We believe that users don't expect pressing ESC to result in a remembered
decision, they expect pressing ESC to avoid making a decision. So we want to
ignore the checkbox when ESC is pressed for autoplay-media.

So this patch adds a new PopupNotification behaviour which reports the source
of event which caused the action callback to be called. This enables the ESC
key press to ignore storing a permission.

Note: the change here to not store a permission on ESC press applies to all
permissions, not just autoplay-media.


MozReview-Commit-ID: IUWFN8LG9VF

--HG--
extra : rebase_source : b004bc211177a7bfb6dcea563d75db9a6750b214
2018-07-17 14:45:17 +12:00
..
abort
animation Bug 1479246 - Use z-index for the property running on the main thread instead of background-color. r=boris 2018-07-29 15:59:21 +09:00
asmjscache
audiochannel
base Bug 1478955 part 1 - Rename JSAutoRealm to JSAutoRealmAllowCCW. r=luke 2018-07-28 12:12:26 +02:00
battery
bindings Bug 1478955 part 4 - Use JSAutoRealm in Codegen.py in a few places. r=bz 2018-07-28 12:16:12 +02:00
broadcastchannel
browser-element Bug 1478955 part 1 - Rename JSAutoRealm to JSAutoRealmAllowCCW. r=luke 2018-07-28 12:12:26 +02:00
cache
canvas Bug 1478955 part 1 - Rename JSAutoRealm to JSAutoRealmAllowCCW. r=luke 2018-07-28 12:12:26 +02:00
chrome-webidl Bug 1474286 - Throw a JS exception in ChromeUtils::RequestPerformanceMetrics if pref is off - r=baku 2018-07-26 10:28:39 +02:00
clients Bug 1478955 part 1 - Rename JSAutoRealm to JSAutoRealmAllowCCW. r=luke 2018-07-28 12:12:26 +02:00
commandhandler
console Bug 1478955 part 1 - Rename JSAutoRealm to JSAutoRealmAllowCCW. r=luke 2018-07-28 12:12:26 +02:00
credentialmanagement
crypto
encoding Bug 1478955 part 1 - Rename JSAutoRealm to JSAutoRealmAllowCCW. r=luke 2018-07-28 12:12:26 +02:00
events Bug 1478955 part 1 - Rename JSAutoRealm to JSAutoRealmAllowCCW. r=luke 2018-07-28 12:12:26 +02:00
fetch Bug 1474542 - Use the unwrapped object's global in FetchUtil::StreamResponseToJS. r=luke 2018-07-26 10:52:01 +02:00
file Bug 1228139 - Remove nsIURIWithPrincipal - part 3 - main part, r=bz 2018-07-24 22:15:57 +02:00
filehandle
filesystem
flex Bug 1477856: In flexbox devtools API, report max-width:none as +infinity. r=bradwerth 2018-07-27 21:38:46 +00:00
gamepad
geolocation
grid
html Bug 1478955 part 1 - Rename JSAutoRealm to JSAutoRealmAllowCCW. r=luke 2018-07-28 12:12:26 +02:00
imptests
indexedDB Bug 1478955 part 1 - Rename JSAutoRealm to JSAutoRealmAllowCCW. r=luke 2018-07-28 12:12:26 +02:00
interfaces Bug 1477670 - remove content handler code from browser/, r=florian,jkt 2018-07-24 17:54:40 +01:00
ipc Bug 1478955 part 1 - Rename JSAutoRealm to JSAutoRealmAllowCCW. r=luke 2018-07-28 12:12:26 +02:00
jsurl Bug 1382035. Treat Promise return values like undefined for javascript: urls. r=peterv 2018-07-23 16:18:33 -04:00
locales
manifest
mathml
media Bug 1478955 part 1 - Rename JSAutoRealm to JSAutoRealmAllowCCW. r=luke 2018-07-28 12:12:26 +02:00
messagechannel Bug 1450167. Stop using atom-or-string for event names in the listener manager. r=smaug 2018-07-24 18:15:19 -04:00
midi Bug 1450167. Stop using atom-or-string for event names in the listener manager. r=smaug 2018-07-24 18:15:19 -04:00
network Bug 1478955 part 1 - Rename JSAutoRealm to JSAutoRealmAllowCCW. r=luke 2018-07-28 12:12:26 +02:00
notification Bug 1452743. Stop using the no-arg DOMEventTargetHelper constructor from Notification. r=smaug 2018-07-24 18:15:22 -04:00
offline
payments
performance
permission
plugins Bug 1478955 part 1 - Rename JSAutoRealm to JSAutoRealmAllowCCW. r=luke 2018-07-28 12:12:26 +02:00
power
presentation
promise Bug 1478955 part 1 - Rename JSAutoRealm to JSAutoRealmAllowCCW. r=luke 2018-07-28 12:12:26 +02:00
push Bug 1476145 part 5. Stop using getInterface(nsIDOMWindowUtils) in DOM code. r=mccr8 2018-07-24 19:47:41 -04:00
quota Bug 1473671 - Don't store persistent block permission if ESC pressed while showing permission doorhanger. r=florian 2018-07-17 14:45:17 +12:00
res
script Bug 1478955 part 1 - Rename JSAutoRealm to JSAutoRealmAllowCCW. r=luke 2018-07-28 12:12:26 +02:00
security Bug 1474537 - CSP 'self' should translate to 'self' and not be resolved to actual self URI. r=dveditz 2018-07-22 18:08:17 +02:00
serviceworkers Bug 1416723: Remove SIMD.js support; r=luke, r=nbp 2018-07-24 15:15:01 +02:00
smil Bug 1450250: SMIL document-related fixes. r=heycam 2018-07-20 14:44:47 +02:00
storage Bug 1473217 - Part 2: dom: Fix misc-unused-raii warnings. r=baku 2018-07-03 22:09:54 -07:00
svg Bug 1477965: Fix SVGAnimationElement::AfterSetAttr. r=heycam 2018-07-26 14:47:42 +02:00
system
tests Merge inbound to mozilla-central. a=merge 2018-07-27 00:58:11 +03:00
u2f
url
vr
webauthn
webbrowserpersist Bug 1476145 part 9. Drop support for getting window utils via getInterface. r=nika 2018-07-24 19:47:43 -04:00
webgpu
webidl Bug 1475342 - Move document.getElementsByAttribute[NS] to ParentNode so it'll work for HTML document and elements;r=bz 2018-07-26 13:40:13 -07:00
websocket Bug 1476145 part 5. Stop using getInterface(nsIDOMWindowUtils) in DOM code. r=mccr8 2018-07-24 19:47:41 -04:00
workers Bug 1478955 part 1 - Rename JSAutoRealm to JSAutoRealmAllowCCW. r=luke 2018-07-28 12:12:26 +02:00
worklet Bug 1478955 part 1 - Rename JSAutoRealm to JSAutoRealmAllowCCW. r=luke 2018-07-28 12:12:26 +02:00
xbl Bug 1478955 part 1 - Rename JSAutoRealm to JSAutoRealmAllowCCW. r=luke 2018-07-28 12:12:26 +02:00
xhr
xml Bug 1477458 - Use <link/> instead of <style/> to insert CSS for XML Pretty Printing to avoid site CSP. r=bz 2018-07-21 12:36:39 +01:00
xslt Bug 1471814 - Add a preference for Web Animations timelines; r=bz,hiro 2018-07-14 09:23:03 +09:00
xul Bug 1478955 part 1 - Rename JSAutoRealm to JSAutoRealmAllowCCW. r=luke 2018-07-28 12:12:26 +02:00
jar.mn
moz.build