gecko-dev/widget/windows
cku 5a90745685 Bug 1424922 - Prevent calling PDFiumParent::Close twice. r=dvander
We call PDFiumParent::Close twice under certain conditions. Once in
PDFiumProcessParent::Delete, and once in PDFiumProcessParent's dtor. So we may
hit MOZ_ABORT which tell us that we are trying to close a closed channel.

This patch prevents hitting this abort by:
1. Only close the channel in PDFiumProcessParent::Delete, remove another call
   in PDFiumProcessParent's dtor. (Please see the change in
   PDFiumProcessParent.cpp).
2. Remove PDFiumParent::AbortConversion and relative code. We can just use
   PDFiumParent::EndConversion instead. When calling PDFiumParent::Close, we
   actually close the IPC channel *synchronously*, which means there is no need
   to register a callback by PDFiumParent::AbortConversion to receive
   actor-destroy callback.

MozReview-Commit-ID: 9i5j6t54J3h

--HG--
extra : rebase_source : 5f74ebc1ecc29e9983c30ca2dd63e0b49bd24a50
2017-12-13 12:42:59 +08:00
..
gtest Bug 1399787 - Part 2.c. Rename DrawPageToFile to SavePageToFile. r=jwatt 2017-11-02 20:19:30 +08:00
res
tests
AudioSession.cpp Bug 1339259 - Hold Windows AudioSession object while recycling registration. r=jimm 2017-09-28 14:28:39 -07:00
AudioSession.h
CompositorWidgetChild.cpp Bug 1373739 - Make headless compositing Windows-compatible, in addition to Linux. r=dvander 2017-07-06 17:45:34 -07:00
CompositorWidgetChild.h Bug 1373739 - Make headless compositing Windows-compatible, in addition to Linux. r=dvander 2017-07-06 17:45:34 -07:00
CompositorWidgetParent.cpp Bug 1373739 - Make headless compositing Windows-compatible, in addition to Linux. r=dvander 2017-07-06 17:45:34 -07:00
CompositorWidgetParent.h Bug 1330037 - Propagate the CompositorOptions to all CompositorWidget instances. r=dvander 2017-01-12 17:29:42 -05:00
GfxInfo.cpp Bug 1402519 - Remove MOZ_CRASHREPORTER directives from widget; r=froydnj 2017-11-23 10:59:04 +01:00
GfxInfo.h Bug 1285563: Part 1. Track two GPU infos in arrays, easier for swap if the second is active. r=milan 2016-12-16 11:56:59 -05:00
IEnumFE.cpp
IEnumFE.h Bug 1322465 part 14 - Use explicit/MOZ_IMPLICIT for the unary constructors in widget/. r=Ehsan 2016-12-16 16:00:43 +08:00
IMMHandler.cpp Bug 1409155 - IMEHandler should not associate IMC with any window if active IME is ATOK 2010 or earlier with x64 build on Win8 or later r=m_kato 2017-10-25 23:51:27 +09:00
IMMHandler.h Bug 1409155 - IMEHandler should not associate IMC with any window if active IME is ATOK 2010 or earlier with x64 build on Win8 or later r=m_kato 2017-10-25 23:51:27 +09:00
InkCollector.cpp Bug 1315264: Set InkCollector.AutoRedraw to false to prevent repainting when the window is invalidated. r=jimm 2016-11-29 16:43:49 +08:00
InkCollector.h Backed out 22 changesets (bug 1399787) for shutdown leaks on windows 7 debug tc-M without e10s r=backout on a CLOSED TREE 2017-12-08 13:09:56 +02:00
InProcessWinCompositorWidget.cpp Bug 1373739 - Make headless compositing Windows-compatible, in addition to Linux. r=dvander 2017-07-06 17:45:34 -07:00
InProcessWinCompositorWidget.h Bug 1373739 - Make headless compositing Windows-compatible, in addition to Linux. r=dvander 2017-07-06 17:45:34 -07:00
JumpListBuilder.cpp Bug 1411001 - Remove the +x permissions on cpp & h files r=froydnj 2017-10-23 20:59:55 +02:00
JumpListBuilder.h Bug 1376760 - Fix race condition for ICustomDestinationList usage. r=jimm 2017-07-06 14:06:09 +08:00
JumpListItem.cpp Bug 1357114 - Move the taskbar refresh timer to idle dispatch. r=florian 2017-09-07 12:15:13 +08:00
JumpListItem.h Bug 1322465 part 14 - Use explicit/MOZ_IMPLICIT for the unary constructors in widget/. r=Ehsan 2016-12-16 16:00:43 +08:00
KeyboardLayout.cpp Bug 1402519 - Remove MOZ_CRASHREPORTER directives from widget; r=froydnj 2017-11-23 10:59:04 +01:00
KeyboardLayout.h Bug 1411001 - Remove the +x permissions on cpp & h files r=froydnj 2017-10-23 20:59:55 +02:00
LSPAnnotator.cpp Bug 1372405 - Provide names for all runnables in the tree (r=froydnj) 2017-06-26 14:19:58 -07:00
moz.build Bug 1399787 - Part 10. Make PrintTargetEMF use the PDFium process to convert to EMF. r=jwatt 2017-11-05 03:06:04 +08:00
nsAppShell.cpp Bug 1424317: Unconditionally remove UIA hook once UIA detection has run; r=jimm 2017-12-08 11:09:11 -07:00
nsAppShell.h Bug 1419886: Part 1 - Add hooks for UIA detection to nsAppShell; r=jimm 2017-12-04 17:53:13 -07:00
nsBidiKeyboard.cpp Bug 1376638 - Minimize uses of prmem.h. r=glandium. 2017-06-30 19:05:41 -07:00
nsBidiKeyboard.h
nsClipboard.cpp Bug 1393528 Add parentheses to a confusing if statement r=jimm 2017-08-24 12:34:09 -05:00
nsClipboard.h Bug 1387168 - Use custom clipboard constructor instead of singleton. r=jrmuizel 2017-08-09 09:46:51 -07:00
nsColorPicker.cpp Backed out 22 changesets (bug 1399787) for shutdown leaks on windows 7 debug tc-M without e10s r=backout on a CLOSED TREE 2017-12-08 13:09:56 +02:00
nsColorPicker.h
nsDataObj.cpp Backed out 22 changesets (bug 1399787) for shutdown leaks on windows 7 debug tc-M without e10s r=backout on a CLOSED TREE 2017-12-08 13:09:56 +02:00
nsDataObj.h Bug 1372063 - Use fallible array to avoid OOM. r=jimm 2017-06-12 12:12:30 +09:00
nsDataObjCollection.cpp
nsDataObjCollection.h
nsdefs.h
nsDeviceContextSpecWin.cpp Bug 1399787 - Part 11.d. Using PrintTargetEMF on windows if skia-pdf is enable. r=jwatt 2017-11-14 13:57:11 +08:00
nsDeviceContextSpecWin.h Bug 1399787 - Part 4. Take out the code we landed in bug 1370488. r=jwatt 2017-11-05 00:53:05 +08:00
nsDragService.cpp Bug 1088760 - Remove nsRenderingContext, replacing all of its uses with gfxContext. r=jwatt,jrmuizel 2017-06-13 11:00:10 -04:00
nsDragService.h Bug 606885 - Fire drag events with keyboard modifiers. r=enn 2017-02-17 11:29:42 +08:00
nsFilePicker.cpp Bug 1404198: Part 2d - Switch to NS_NewTimer* in widget. r=njn 2017-10-15 23:12:54 -07:00
nsFilePicker.h Bug 1387800 - Remove [deprecated] nsIFilePicker.show(). r=qdot 2017-08-06 13:15:31 +09:00
nsIdleServiceWin.cpp
nsIdleServiceWin.h
nsImageClipboard.cpp Bug 1376638 - Minimize uses of prmem.h. r=glandium. 2017-06-30 19:05:41 -07:00
nsImageClipboard.h Bug 1322465 part 14 - Use explicit/MOZ_IMPLICIT for the unary constructors in widget/. r=Ehsan 2016-12-16 16:00:43 +08:00
nsLookAndFeel.cpp Bug 1412611 Reorder member initialization to fix -Wreorder warning in widget/windows/nsLookAndFeel.cpp r=njn 2017-10-28 23:36:04 -05:00
nsLookAndFeel.h Bug 1403690 Part 2: Windows change nsLookAndFeel::NativeGetColor to use cached colors. r=jimm 2017-10-02 16:17:05 -07:00
nsNativeDragSource.cpp
nsNativeDragSource.h Bug 1322465 part 14 - Use explicit/MOZ_IMPLICIT for the unary constructors in widget/. r=Ehsan 2016-12-16 16:00:43 +08:00
nsNativeDragTarget.cpp Bug 606885 - Fire drag events with keyboard modifiers. r=enn 2017-02-17 11:29:42 +08:00
nsNativeDragTarget.h Bug 1309596, implementation of UpdateDragImage by adjusting image and calling DragEnter of the drag feedback helper, r=jimm 2016-12-23 18:09:44 -05:00
nsNativeThemeWin.cpp Bug 1417751 - Implement a new value inner-spin-button to -moz-appearance on all platforms except Android. r=mats 2017-11-29 10:43:13 +08:00
nsNativeThemeWin.h Bug 1400460 - Rename nsIAtom as nsAtom. r=hiro. 2017-10-03 09:05:19 +11:00
nsPrintDialogUtil.cpp Bug 1405210 - Part 3: Apply clang-format to added print dialog widget code. r=jimm 2017-10-19 11:04:50 +09:00
nsPrintDialogUtil.h Bug 1405210 - Part 3: Apply clang-format to added print dialog widget code. r=jimm 2017-10-19 11:04:50 +09:00
nsPrintDialogWin.cpp Bug 1313150 - Remove |weak| parameter from nsIMutableArray methods. r=froydnj 2017-10-21 23:53:02 +09:00
nsPrintDialogWin.h Bug 1405210 - Part 3: Apply clang-format to added print dialog widget code. r=jimm 2017-10-19 11:04:50 +09:00
nsPrintOptionsWin.cpp Bug 1407103 - Convert wstring attributes to AString in widget/nsIPrint*.idl. r=bobowen. 2017-10-09 10:08:09 +11:00
nsPrintOptionsWin.h
nsPrintSettingsWin.cpp Bug 1407103 - Convert wstring attributes to AString in widget/nsIPrint*.idl. r=bobowen. 2017-10-09 10:08:09 +11:00
nsPrintSettingsWin.h Bug 1407103 - Convert wstring attributes to AString in widget/nsIPrint*.idl. r=bobowen. 2017-10-09 10:08:09 +11:00
nsSound.cpp Backed out 22 changesets (bug 1399787) for shutdown leaks on windows 7 debug tc-M without e10s r=backout on a CLOSED TREE 2017-12-08 13:09:56 +02:00
nsSound.h Bug 1363163 - Playing sound in a seperated thread to avoid jank r=masayuki 2017-06-08 11:08:49 +08:00
nsToolkit.cpp
nsToolkit.h
nsUXThemeConstants.h Bug 1373079 - (3) Special-case min-size cache for buttons r=jimm 2017-07-07 10:15:32 -07:00
nsUXThemeData.cpp Bug 1391164 - Unnecessary to use GetProcAddress for gesture APIs since we already drop XP and Vista. r=jimm 2017-08-18 09:47:36 +09:00
nsUXThemeData.h Bug 1391164 - Unnecessary to use GetProcAddress for gesture APIs since we already drop XP and Vista. r=jimm 2017-08-18 09:47:36 +09:00
nsWidgetFactory.cpp Bug 1417442 - P2. fix nsIGfxInfo in GPU process. r=dvander 2017-11-15 23:33:37 +01:00
nsWindow.cpp Backed out 22 changesets (bug 1399787) for shutdown leaks on windows 7 debug tc-M without e10s r=backout on a CLOSED TREE 2017-12-08 13:09:56 +02:00
nsWindow.h Bug 1415070 - Cut out the window button shape on Windows 7. r=kats 2017-11-09 16:31:08 -05:00
nsWindowBase.cpp Bug 1405210 - Part 1: Add PrintDialogService to windows widget. r=jimm,mshal 2017-10-19 11:04:13 +09:00
nsWindowBase.h Bug 1409155 - IMEHandler should not associate IMC with any window if active IME is ATOK 2010 or earlier with x64 build on Win8 or later r=m_kato 2017-10-25 23:51:27 +09:00
nsWindowDbg.cpp Bug 1352339 - Add missing 'using namespace mozilla' to nsWindowDbg.cpp r=jwatt 2017-04-01 00:42:35 +08:00
nsWindowDbg.h
nsWindowDefs.h Bug 1322465 part 14 - Use explicit/MOZ_IMPLICIT for the unary constructors in widget/. r=Ehsan 2016-12-16 16:00:43 +08:00
nsWindowGfx.cpp Bug 1376638 - Minimize uses of prmem.h. r=glandium. 2017-06-30 19:05:41 -07:00
nsWindowGfx.h
nsWinGesture.cpp Bug 1391164 - Unnecessary to use GetProcAddress for gesture APIs since we already drop XP and Vista. r=jimm 2017-08-18 09:47:36 +09:00
nsWinGesture.h Bug 1391164 - Unnecessary to use GetProcAddress for gesture APIs since we already drop XP and Vista. r=jimm 2017-08-18 09:47:36 +09:00
PCompositorWidget.ipdl
PDFiumChild.cpp Bug 1399787 - Part 10. Make PrintTargetEMF use the PDFium process to convert to EMF. r=jwatt 2017-11-05 03:06:04 +08:00
PDFiumChild.h Bug 1399787 - Part 10. Make PrintTargetEMF use the PDFium process to convert to EMF. r=jwatt 2017-11-05 03:06:04 +08:00
PDFiumEngineShim.cpp Bug 1399787 - Part 16. Hide function table in PDFiumEngineShim.cpp. r=jwatt 2017-11-01 21:51:20 +08:00
PDFiumEngineShim.h Bug 1399787 - Part 16. Hide function table in PDFiumEngineShim.cpp. r=jwatt 2017-11-01 21:51:20 +08:00
PDFiumParent.cpp Bug 1424922 - Prevent calling PDFiumParent::Close twice. r=dvander 2017-12-13 12:42:59 +08:00
PDFiumParent.h Bug 1424922 - Prevent calling PDFiumParent::Close twice. r=dvander 2017-12-13 12:42:59 +08:00
PDFiumProcessChild.cpp Bug 1399787 - Part 9. Sandbox the PDFium process. r=bobowen,jwatt 2017-10-18 20:52:45 +08:00
PDFiumProcessChild.h Bug 1399787 - Part 9. Sandbox the PDFium process. r=bobowen,jwatt 2017-10-18 20:52:45 +08:00
PDFiumProcessParent.cpp Bug 1424922 - Prevent calling PDFiumParent::Close twice. r=dvander 2017-12-13 12:42:59 +08:00
PDFiumProcessParent.h Bug 1424922 - Prevent calling PDFiumParent::Close twice. r=dvander 2017-12-13 12:42:59 +08:00
PDFViaEMFPrintHelper.cpp Bug 1399787 - Part 17. Clean up some comments and formatting in PDFViaEMFPrintHelper code. r=jwatt 2017-11-29 15:45:34 +08:00
PDFViaEMFPrintHelper.h Bug 1399787 - Part 17. Clean up some comments and formatting in PDFViaEMFPrintHelper code. r=jwatt 2017-11-29 15:45:34 +08:00
PlatformWidgetTypes.ipdlh Bug 1373739 - Make headless compositing Windows-compatible, in addition to Linux. r=dvander 2017-07-06 17:45:34 -07:00
PPDFium.ipdl Backed out 22 changesets (bug 1399787) for shutdown leaks on windows 7 debug tc-M without e10s r=backout on a CLOSED TREE 2017-12-08 13:09:56 +02:00
resource.h
ScreenHelperWin.cpp Backed out 22 changesets (bug 1399787) for shutdown leaks on windows 7 debug tc-M without e10s r=backout on a CLOSED TREE 2017-12-08 13:09:56 +02:00
ScreenHelperWin.h Bug 1356023 - Remove nsIScreenManager.systemDefaultScale. r=jfkthame 2017-04-13 07:20:35 +09:00
TaskbarPreview.cpp Bug 1403819 - Remove nsIDOMHTMLCanvasElement; r=bz 2017-10-06 10:49:26 -07:00
TaskbarPreview.h
TaskbarPreviewButton.cpp
TaskbarPreviewButton.h
TaskbarTabPreview.cpp
TaskbarTabPreview.h
TaskbarWindowPreview.cpp
TaskbarWindowPreview.h
touchinjection_sdk80.h
TSFTextStore.cpp Bug 1411001 - Remove the +x permissions on cpp & h files r=froydnj 2017-10-23 20:59:55 +02:00
TSFTextStore.h Bug 1411001 - Remove the +x permissions on cpp & h files r=froydnj 2017-10-23 20:59:55 +02:00
widget.rc
WidgetTraceEvent.cpp Bug 1372405 - Provide names for all runnables in the tree (r=froydnj) 2017-06-26 14:19:58 -07:00
WinCompositorWidget.cpp Bug 1373739 - Make headless compositing Windows-compatible, in addition to Linux. r=dvander 2017-07-06 17:45:34 -07:00
WinCompositorWidget.h Bug 1373739 - Make headless compositing Windows-compatible, in addition to Linux. r=dvander 2017-07-06 17:45:34 -07:00
WindowHook.cpp
WindowHook.h Bug 1322465 part 14 - Use explicit/MOZ_IMPLICIT for the unary constructors in widget/. r=Ehsan 2016-12-16 16:00:43 +08:00
WindowsEMF.cpp Backed out 22 changesets (bug 1399787) for shutdown leaks on windows 7 debug tc-M without e10s r=backout on a CLOSED TREE 2017-12-08 13:09:56 +02:00
WindowsEMF.h Backed out 22 changesets (bug 1399787) for shutdown leaks on windows 7 debug tc-M without e10s r=backout on a CLOSED TREE 2017-12-08 13:09:56 +02:00
WindowsUIUtils.cpp Bug 1344629 - Part 6: Rewrite unnecessary uses of nsLiteralString. r=dbaron 2017-03-14 15:26:27 +13:00
WindowsUIUtils.h
WinIMEHandler.cpp Bug 1406446 - part 1: InputContextAction should treat focus change during handling a user input as caused by user input even if it's caused by JS r=smaug 2017-10-24 02:46:15 +09:00
WinIMEHandler.h Bug 1409155 - IMEHandler should not associate IMC with any window if active IME is ATOK 2010 or earlier with x64 build on Win8 or later r=m_kato 2017-10-25 23:51:27 +09:00
WinMessages.h Bug 1352368 - Remove some old Windows defines from WinMessages.h r=jwatt 2017-04-01 00:44:26 +08:00
WinModifierKeyState.h Bug 1391803 - Use nsStringFwd.h for forward declaring string classes. r=froydnj 2017-08-16 16:48:52 -07:00
WinMouseScrollHandler.cpp Bug 1410988 - Add a debug mode pref to emulate odd touchpad utils which give focus to window under mouse cursor when user tries to scroll the content r=jimm 2017-10-19 02:28:37 +09:00
WinMouseScrollHandler.h Bug 1410988 - Add a debug mode pref to emulate odd touchpad utils which give focus to window under mouse cursor when user tries to scroll the content r=jimm 2017-10-19 02:28:37 +09:00
WinNativeEventData.h
WinPointerEvents.cpp Bug 1345398 - Fire WidgetMouseEvent by handling pen generated mouse messages to get Windows native dnd supports. r=jimm 2017-03-13 15:40:52 +08:00
WinPointerEvents.h Bug 1372963 Remove WinPointerEvents:: qualifier which breaks MinGW build r=jimm 2017-04-25 13:28:04 -05:00
WinTaskbar.cpp Bug 1387802 - Remove [deprecated] methods from nsITaskbarPreviewController. r=jimm 2017-08-06 13:35:02 +09:00
WinTaskbar.h
WinTextEventDispatcherListener.cpp Bug 1343075 - Use GeckoEditableSupport from PuppetWidget; r=masayuki r=rbarker r=snorp r=esawin 2017-03-07 22:34:39 -05:00
WinTextEventDispatcherListener.h Bug 1343075 - Use GeckoEditableSupport from PuppetWidget; r=masayuki r=rbarker r=snorp r=esawin 2017-03-07 22:34:39 -05:00
WinUtils.cpp Bug 1421655 - Renaming imgITools::decodeImageBuffer to imgITools::decodeImageFromBuffer, r=aosmond 2017-11-30 14:48:47 +01:00
WinUtils.h Bug 1390097 - Revert a part of bug 1354020 changes. r=masayuki 2017-08-23 12:59:40 +09:00