gecko-dev/netwerk/protocol/http/AltDataOutputStreamParent.h
Valentin Gosu b830ea1f6d Bug 1363653 - Make AltDataOutputStreamParent not send any messages after object destruction r=mayhemer
This patch prevents the following error:
AltDataOutputStreamChild::Close -> SendClose()
AltDataOutputStreamChild::Release -> Send__delete__()
AltDataOutputStreamParent::RecvClose() -> SendError()
AltDataOutputStreamParent::ActorDestroy -> mIPCOpen = false
AltDataOutputStreamChild::RecvError -> === Crash - object was deleted ===

We introduce the DeleteSelf message.
AltDataOutputStreamChild::Release -> SendDeleteSelf()
AltDataOutputStreamParent::RecvDeleteSelf -> mIPCOpen = false; SendDeleteSelf()
AltDataOutputStreamChild::RecvDeleteSelf -> Send__delete__()

The parent will not send any more messages after receiving the DeleteSelf message.

MozReview-Commit-ID: I9RQ5I7eSt9

--HG--
extra : rebase_source : 8f918d24595248149ebd3857e05e38dc5237059b
2017-05-11 21:35:37 +02:00

55 lines
1.8 KiB
C++

/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* vim: set sw=2 ts=8 et tw=80 : */
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#ifndef mozilla_net_AltDataOutputStreamParent_h
#define mozilla_net_AltDataOutputStreamParent_h
#include "mozilla/net/PAltDataOutputStreamParent.h"
#include "nsIOutputStream.h"
namespace mozilla {
namespace net {
// Forwards data received from the content process to an output stream.
class AltDataOutputStreamParent
: public PAltDataOutputStreamParent
, public nsISupports
{
public:
NS_DECL_ISUPPORTS
// Called from NeckoParent::AllocPAltDataOutputStreamParent which also opens
// the output stream.
// aStream may be null
explicit AltDataOutputStreamParent(nsIOutputStream* aStream);
// Called when data is received from the content process.
// We proceed to write that data to the output stream.
virtual mozilla::ipc::IPCResult RecvWriteData(const nsCString& data) override;
// Called when AltDataOutputStreamChild::Close() is
// Closes and nulls the output stream.
virtual mozilla::ipc::IPCResult RecvClose() override;
virtual void ActorDestroy(ActorDestroyReason aWhy) override;
// Sets an error that will be reported to the content process.
void SetError(nsresult status) { mStatus = status; }
virtual mozilla::ipc::IPCResult RecvDeleteSelf() override;
private:
virtual ~AltDataOutputStreamParent();
nsCOMPtr<nsIOutputStream> mOutputStream;
// In case any error occurs mStatus will be != NS_OK, and this status code will
// be sent to the content process asynchronously.
nsresult mStatus;
bool mIPCOpen;
};
} // namespace net
} // namespace mozilla
#endif // mozilla_net_AltDataOutputStreamParent_h