gecko-dev/tools/lint
Chris Peterson c6373306f8 Bug 1436263 - Part 5: Add a mach lint for virtual function declarations with multiple specifiers. r=froydnj r=ahal
Virtual function declarations should specify only one of `virtual`, `final`, or `override`, as per the Mozilla C++ style guide:

https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style

This lint warns about:

  virtual void Bad1() final
  void Bad2() final override
  void Bad3() override final

Caveats: This lint doesn't warn about `virtual void NotBad() override` at this time because there are 8000+ instances. It also doesn't warn about function declarations that span multiple lines because the regex can't match across line breaks.

MozReview-Commit-ID: LcBsOAKKgz7

--HG--
extra : rebase_source : 4da72ffac59acdc9796e3f540f24bb97af989cd0
2018-02-15 00:50:02 -08:00
..
docs Bug 1436575 - Prevent ==/!= comparisons with booleans as they aren't necessary. r=standard8 2018-02-08 11:51:17 -05:00
eslint Bug 1436575 - Remove autofix from rule since it is not reliable in all cases. r=standard8 2018-02-08 15:37:40 -05:00
python Bug 1436639 - [lint] Make sure flake8 is run with same python as |mach lint| was, r=jmaher 2018-02-07 23:28:33 -05:00
shell Bug 1432627 Add shellcheck linter to CI r=ahal 2018-01-29 15:27:04 +00:00
spell Bug 1433410 - Add codespell support for mach lint r=ahal 2018-01-27 10:35:31 +01:00
tox Bug 1302773 - Install tox in docker image in MozReview; r=dustin 2017-05-13 02:31:37 +05:30
wpt Bug 1428585 - Fixup flake8 error, r=me ON A CLOSED TREE 2018-01-09 15:47:06 +00:00
yamllint_ Bug 1395126 - Support cascading configuration for flake8, r=bc 2017-08-29 17:32:31 -04:00
codespell.yml Bug 1433912 - [lint] Only run codespell linter on python/mozlint and tools/lint for now, r=sylvestre 2018-01-29 10:25:54 -05:00
cpp-virtual-final.yml Bug 1436263 - Part 5: Add a mach lint for virtual function declarations with multiple specifiers. r=froydnj r=ahal 2018-02-15 00:50:02 -08:00
eslint.yml Bug 1429457 - [mozlint] Create formal 'setup' mechanism for bootstrapping lint dependencies, r=gbrown 2018-01-25 13:40:02 -05:00
flake8.yml Bug 1436725 - [lint] Remove obsolete eslintvalidate files, r=standard8 2018-02-08 09:25:14 -05:00
hooks.py Bug 1386351 - Let the Lint hook default to pre-push (for git) if being called directly. r=glandium 2017-11-23 09:09:33 +00:00
mach_commands.py Bug 1384273 - Get lint root dir from mach; r=ahal 2017-07-22 01:28:34 -06:00
py2.yml Bug 1436792 - [py-compat] Improve error messaging when python is missing, r=jmaher 2018-02-08 14:26:15 -05:00
py3.yml Bug 1436792 - [py-compat] Improve error messaging when python is missing, r=jmaher 2018-02-08 14:26:15 -05:00
shellcheck.yml Bug 1432627 Add shellcheck linter to CI r=ahal 2018-01-29 15:27:04 +00:00
test-disable.yml Bug 1437226 - Fix text-disable linter message; r=ahal 2018-02-12 12:28:41 -08:00
wpt_manifest.yml Bug 1387862 - Lint the linter config yaml files themselves. r=ahal 2017-08-06 13:47:03 -04:00
wpt.yml Bug 1387862 - Lint the linter config yaml files themselves. r=ahal 2017-08-06 13:47:03 -04:00
yaml.yml Bug 1387862 - Lint the linter config yaml files themselves. r=ahal 2017-08-06 13:47:03 -04:00