mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-17 07:15:46 +00:00
9ea93c4f7b
Each nsStaticAtomSetup contains a pointer to a static atom, and also a pointer to the canonical pointer to that static atom. Which is pretty weird! The notable thing thing about it is that these structs are in an array, and that gives us the only way to iterate over all static atoms in a single class, for registration and lookups. But thanks to various other recent changes to the implementation of static atoms, we can now put the static atoms themselves into an array, which can be iterated over. So this patch does that. With that done, nsStaticAtomSetup is no longer necessary. According to the `size` utility, on Linux64 this reduces the size of libxul.so by the following amounts: > text: 62008 bytes > data: 20992 bytes > bss: 21040 bytes > total: 104040 bytes - The bss reduction is one word per atom, because the canonical static atom pointers (e.g. nsGkAtoms::foo) have moved from .bss to .data, because they're now initialized at compile time instead of runtime. - The data reduction is one word per atom, because we remove two words per atom for the nsStaticAtomSetup removal, but gain one word per atom from the previous bullet point. - I'm not sure about the text reduction. It's three words per atom. Maybe because there is one less relocation per atom? Other notable things in the patch: - nsICSSAnonBoxPseudo and nsICSSPseudoElement now inherit from nsStaticAtom, not nsAtom, because that's more precise. - Each static atoms array now has an enum associated with it, which is used in various ways. - In the big comment about the macros at the top of nsStaticAtom.h, the pre- and post-expansion forms are now shown interleaved. The interleaving reduces duplication and makes the comment much easier to read and maintain. The comment also has an introduction that explains the constraints and goals of the implementation. - The SUBCLASS macro variations are gone. There are few enough users of these macros now that always passing the atom type has become simpler. MozReview-Commit-ID: 1GmfKidLjaU --HG-- extra : rebase_source : 2352590101fc6693ba388f885ca4714a42963943
53 lines
1.2 KiB
C++
53 lines
1.2 KiB
C++
/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
|
|
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#ifndef nsGkAtoms_h___
|
|
#define nsGkAtoms_h___
|
|
|
|
#include "nsAtom.h"
|
|
#include "nsStaticAtom.h"
|
|
|
|
namespace mozilla {
|
|
namespace detail {
|
|
|
|
struct GkAtoms
|
|
{
|
|
#define GK_ATOM(name_, value_) NS_STATIC_ATOM_DECL_STRING(name_, value_)
|
|
#include "nsGkAtomList.h"
|
|
#undef GK_ATOM
|
|
|
|
enum class Atoms {
|
|
#define GK_ATOM(name_, value_) NS_STATIC_ATOM_ENUM(name_)
|
|
#include "nsGkAtomList.h"
|
|
#undef GK_ATOM
|
|
AtomsCount
|
|
};
|
|
|
|
const nsStaticAtom mAtoms[static_cast<size_t>(Atoms::AtomsCount)];
|
|
};
|
|
|
|
extern const GkAtoms gGkAtoms;
|
|
|
|
} // namespace detail
|
|
} // namespace mozilla
|
|
|
|
class nsGkAtoms
|
|
{
|
|
private:
|
|
static const nsStaticAtom* const sAtoms;
|
|
static constexpr size_t sAtomsLen =
|
|
mozilla::ArrayLength(mozilla::detail::gGkAtoms.mAtoms);
|
|
|
|
public:
|
|
static void RegisterStaticAtoms();
|
|
|
|
#define GK_ATOM(name_, value_) NS_STATIC_ATOM_DECL_PTR(nsStaticAtom, name_)
|
|
#include "nsGkAtomList.h"
|
|
#undef GK_ATOM
|
|
};
|
|
|
|
#endif /* nsGkAtoms_h___ */
|