mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-02-26 12:20:56 +00:00
2bc83ec22d
Done: - Functionality of the button was changed from cleaning the field value to toggling the datepicker dialog. - Pre-existing issues resolved: Updated datetimebox.js to use `keydown` event instead of the deprecated `keypress` (which does not preventDefault for buttons), added default handling of digits for `keydown`, and added a check to avoid running duplicate cleanup when the picker is closed - Removed ability to open a date picker from editable elements of the `<input type="date">` field and ensured keyboard and mouse/touch click are working for the Calendar button, while Escape functionality remained - Updated `onBlur` logic for the button in accordance with its new functionaility - New Calendar SVG icon was created by Katie Caldwell and optimized by Sam Foster - Provided HCM support for the Calendar button - Ensured the Calendar button is not shown on `<input type=time>` to preserve the existent UX - Added Fluent l10n to the content process and provided `title` to the image button (SVG is marked as `role="none"` to avoid exposure to assistive technology) - Added functional and markup tests for the Calendar button and its localization, updated Reset button tests to the Calendar one ToDo (further patch): 1. Pt.4 - Ensure keyboard support when focus moves between processes ToDo (other dependencies/bugs): 1. Investigations into if we should show a calendar button for read-only fields and if a Reset button would be benefitial to be shown for a `type=time` inputs Depends on D139981 Differential Revision: https://phabricator.services.mozilla.com/D141175