Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-17 23:35:34 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
559a3f06ee
gecko-dev/modules
History
Nicholas Nethercote 559a3f06ee Bug 1413085 - Make PREF_Get{CString,Int,Bool}Pref() more uniform. r=glandium. 
This patch does the following.

- Reduces nesting and simplifies control flow by handling failure cases
  earlier, and makes all three functions have identical structure.

- Avoids unnecessary temporary local variables, including |rv|.

- Removes low-value comments, including some misleading ones (e.g. "This
  function will perform conversion...").

- PREF_GetCStringValue() previously did not check HasDefaultValue(), unlike the
  other two. It now does.

- PREF_GetCStringValue() now calls SetIsVoid(true) at the start, so that
  aValueOut will be Voided on all failure paths.

MozReview-Commit-ID: 2uCSv76Y8eu

--HG--
extra : rebase_source : 9ca9148ad0a5069bdd3e08aec0038216d27ea092
2017-11-01 08:55:07 +11:00
..
brotli Bug 1403346 - Replace all uses of ALLOW_COMPILER_WARNINGS with a template, remove ALLOW_COMPILER_WARNINGS. r=glandium 2017-10-25 15:12:09 -07:00
fdlibm Bug 1350355 - fdlibm should provide definition for u_int32_t and u_int64_t. r=arai 2017-03-27 03:33:34 -07:00
freetype2 Bug 1403346 - Replace all uses of ALLOW_COMPILER_WARNINGS with a template, remove ALLOW_COMPILER_WARNINGS. r=glandium 2017-10-25 15:12:09 -07:00
libbz2 Bug 1345618 - add BUG_COMPONENT to modules/* files. r=jfkthame,mcmanus,rstrong 2017-03-09 05:33:31 -05:00
libjar Bug 1409249: Follow-up: Fix libjar ref counting bustage. r=bustage 2017-10-25 23:05:02 -07:00
libmar Bug 1407014 - Fix typo in CyprtoAPI_VerifySignature function name. r=rstrong 2017-10-09 11:57:43 -07:00
libpref Bug 1413085 - Make PREF_Get{CString,Int,Bool}Pref() more uniform. r=glandium. 2017-11-01 08:55:07 +11:00
pdfium Bug 1403346 - Replace all uses of ALLOW_COMPILER_WARNINGS with a template, remove ALLOW_COMPILER_WARNINGS. r=glandium 2017-10-25 15:12:09 -07:00
woff2 Bug 1403346 - Replace all uses of ALLOW_COMPILER_WARNINGS with a template, remove ALLOW_COMPILER_WARNINGS. r=glandium 2017-10-25 15:12:09 -07:00
xz-embedded Bug 1403346 - Replace all uses of ALLOW_COMPILER_WARNINGS with a template, remove ALLOW_COMPILER_WARNINGS. r=glandium 2017-10-25 15:12:09 -07:00
zlib Bug 1345618 - add BUG_COMPONENT to modules/* files. r=jfkthame,mcmanus,rstrong 2017-03-09 05:33:31 -05:00
moz.build Bug 1345618 - add BUG_COMPONENT to modules/* files. r=jfkthame,mcmanus,rstrong 2017-03-09 05:33:31 -05:00