mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-21 01:05:45 +00:00
57887f2601
Currently manifestparser will only look for line continuations *after* looking for a key. This means
that line continuations cannot contain key separators. For example, this:
[test]
foo=
bar=baz
gets treated as:
{'name': 'test', 'foo': '', 'bar': 'baz'}
Here, bar=baz will be treated as a new key/value pair despite the indentation. This patch switches
the order around, so we look for a continuation first. Now, it is only treated as a continuation if
the indent is greater than the indent of the preceding key.
So this manifest:
[test]
foo=bar
baz=fleem
is a continuation and results in:
{'name': 'test', 'foo': 'bar\nbaz=fleem'}
But this manifest:
[test]
foo=bar
baz=fleem
is not a continuation, and yields:
{'name': 'test', 'foo': 'bar', 'baz': 'fleem'}
MozReview-Commit-ID: FAMP5TUIo9q
--HG--
extra : rebase_source : 624c53cfe0565374c1224dd86a3fffc8831279d3
|
||
|---|---|---|
| .. | ||
| blue-150.png | ||
| browser_fire_appinstalled_event.js | ||
| browser_Manifest_install.js | ||
| browser_ManifestFinder_browserHasManifestLink.js | ||
| browser_ManifestIcons_browserFetchIcon.js | ||
| browser_ManifestObtainer_obtain.js | ||
| browser.ini | ||
| common.js | ||
| file_reg_appinstalled_event.html | ||
| file_testserver.sjs | ||
| icon.png | ||
| manifestLoader.html | ||
| mochitest.ini | ||
| red-50.png | ||
| resource.sjs | ||
| test_ImageObjectProcessor_sizes.html | ||
| test_ImageObjectProcessor_src.html | ||
| test_ImageObjectProcessor_type.html | ||
| test_ManifestProcessor_background_color.html | ||
| test_ManifestProcessor_dir.html | ||
| test_ManifestProcessor_display.html | ||
| test_ManifestProcessor_icons.html | ||
| test_ManifestProcessor_JSON.html | ||
| test_ManifestProcessor_lang.html | ||
| test_ManifestProcessor_name_and_short_name.html | ||
| test_ManifestProcessor_orientation.html | ||
| test_ManifestProcessor_scope.html | ||
| test_ManifestProcessor_start_url.html | ||
| test_ManifestProcessor_theme_color.html | ||
| test_ManifestProcessor_warnings.html | ||
| test_window_onappinstalled_event.html | ||
