gecko-dev/taskcluster
Chris Peterson c6373306f8 Bug 1436263 - Part 5: Add a mach lint for virtual function declarations with multiple specifiers. r=froydnj r=ahal
Virtual function declarations should specify only one of `virtual`, `final`, or `override`, as per the Mozilla C++ style guide:

https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style

This lint warns about:

  virtual void Bad1() final
  void Bad2() final override
  void Bad3() override final

Caveats: This lint doesn't warn about `virtual void NotBad() override` at this time because there are 8000+ instances. It also doesn't warn about function declarations that span multiple lines because the regex can't match across line breaks.

MozReview-Commit-ID: LcBsOAKKgz7

--HG--
extra : rebase_source : 4da72ffac59acdc9796e3f540f24bb97af989cd0
2018-02-15 00:50:02 -08:00
..
ci Bug 1436263 - Part 5: Add a mach lint for virtual function declarations with multiple specifiers. r=froydnj r=ahal 2018-02-15 00:50:02 -08:00
docker Bug 1438415 Re-order mbsdiff hook to allow exit values r=catlee 2018-02-15 21:59:15 +00:00
docs Bug 1398796 - Do uptake monitoring in TC r=mtabara 2018-02-15 08:49:45 -05:00
scripts Bug 1425406 - Add a linux64 clang 6 (pre) toolchain with the macosx64 native sanitizer dylibs. r=froydnj 2018-02-08 16:58:12 -05:00
taskgraph Merge mozilla-central to inbound. a=merge CLOSED TREE 2018-02-17 00:13:16 +02:00
.yamllint Bug 1414824 - Enable stricter linting in taskcluster yaml files. r=Callek 2017-11-11 00:36:41 -05:00
mach_commands.py Bug 1437710: fix spelling of zstd; r=gps 2018-02-12 23:32:11 +00:00
moz.build Backed out 2 changesets (bug 1403519) for bustage on \python\mozbuild\mozbuild\test\frontend\test_reader.py on a CLOSED TREE 2018-01-17 07:23:40 +02:00