mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-11 20:35:50 +00:00
58786e1ea7
This patch makes the following changes to the macros. - Removes PROFILER_LABEL_FUNC. It's only suitable for use in functions outside classes, due to PROFILER_FUNCTION_NAME not getting class names, and it was mostly misused. - Removes PROFILER_FUNCTION_NAME. It's no longer used, and __func__ is universally available now anyway. - Combines the first two string literal arguments of PROFILER_LABEL and PROFILER_LABEL_DYNAMIC into a single argument. There was no good reason for them to be separate, and it forced a '::' in the label, which isn't always appropriate. Also, the meaning of the "name_space" argument was interpreted in an interesting variety of ways. - Adds an "AUTO_" prefix to PROFILER_LABEL and PROFILER_LABEL_DYNAMIC, to make it clearer they construct RAII objects rather than just being function calls. (I myself have screwed up the scoping because of this in the past.) - Fills in the 'js::ProfileEntry::Category::' qualifier within the macro, so the caller doesn't need to. This makes a *lot* more of the uses fit onto a single line. The patch also makes the following changes to the macro uses (beyond those required by the changes described above). - Fixes a bunch of labels that had gotten out of sync with the name of the class and/or function that encloses them. - Removes a useless PROFILER_LABEL use within a trivial scope in EventStateManager::DispatchMouseOrPointerEvent(). It clearly wasn't serving any useful purpose. It also serves as extra evidence that the AUTO_ prefix is a good idea. - Tweaks DecodePool::SyncRunIf{Preferred,Possible} so that the labelling is done within them, instead of at their callsites, because that's a more standard way of doing things. --HG-- extra : rebase_source : 318d1bc6fc1425a94aacbf489dd46e4f83211de4 |
||
---|---|---|
.. | ||
build | ||
test | ||
FileSystemModule.cpp | ||
FileSystemModule.h | ||
IStorageBindingParamsInternal.h | ||
moz.build | ||
mozIStorageAggregateFunction.idl | ||
mozIStorageAsyncConnection.idl | ||
mozIStorageAsyncStatement.idl | ||
mozIStorageBaseStatement.idl | ||
mozIStorageBindingParams.idl | ||
mozIStorageBindingParamsArray.idl | ||
mozIStorageCompletionCallback.idl | ||
mozIStorageConnection.idl | ||
mozIStorageError.idl | ||
mozIStorageFunction.idl | ||
mozIStoragePendingStatement.idl | ||
mozIStorageProgressHandler.idl | ||
mozIStorageResultSet.idl | ||
mozIStorageRow.idl | ||
mozIStorageService.idl | ||
mozIStorageStatement.idl | ||
mozIStorageStatementCallback.idl | ||
mozIStorageStatementParams.idl | ||
mozIStorageStatementRow.idl | ||
mozIStorageVacuumParticipant.idl | ||
mozIStorageValueArray.idl | ||
mozStorageArgValueArray.cpp | ||
mozStorageArgValueArray.h | ||
mozStorageAsyncStatement.cpp | ||
mozStorageAsyncStatement.h | ||
mozStorageAsyncStatementExecution.cpp | ||
mozStorageAsyncStatementExecution.h | ||
mozStorageAsyncStatementJSHelper.cpp | ||
mozStorageAsyncStatementJSHelper.h | ||
mozStorageAsyncStatementParams.cpp | ||
mozStorageAsyncStatementParams.h | ||
mozStorageBindingParams.cpp | ||
mozStorageBindingParams.h | ||
mozStorageBindingParamsArray.cpp | ||
mozStorageBindingParamsArray.h | ||
mozStorageConnection.cpp | ||
mozStorageConnection.h | ||
mozStorageError.cpp | ||
mozStorageError.h | ||
mozStorageHelper.h | ||
mozStoragePrivateHelpers.cpp | ||
mozStoragePrivateHelpers.h | ||
mozStorageResultSet.cpp | ||
mozStorageResultSet.h | ||
mozStorageRow.cpp | ||
mozStorageRow.h | ||
mozStorageService.cpp | ||
mozStorageService.h | ||
mozStorageSQLFunctions.cpp | ||
mozStorageSQLFunctions.h | ||
mozStorageStatement.cpp | ||
mozStorageStatement.h | ||
mozStorageStatementData.h | ||
mozStorageStatementJSHelper.cpp | ||
mozStorageStatementJSHelper.h | ||
mozStorageStatementParams.cpp | ||
mozStorageStatementParams.h | ||
mozStorageStatementRow.cpp | ||
mozStorageStatementRow.h | ||
SQLCollations.cpp | ||
SQLCollations.h | ||
SQLiteMutex.h | ||
StatementCache.h | ||
storage.h | ||
StorageBaseStatementInternal.cpp | ||
StorageBaseStatementInternal.h | ||
style.txt | ||
TelemetryVFS.cpp | ||
VacuumManager.cpp | ||
VacuumManager.h | ||
Variant_inl.h | ||
Variant.h | ||
variantToSQLiteT_impl.h |