gecko-dev/python/mozbuild
Nick Alexander 5a41a44863 Bug 1182579 - Compute Android version codes in Python. r=gps
I considered three ways to do this:

* one, as a Python script executed with $(shell);
* two, as a Python script that writes an include file for the preprocessor;
* three, as a function exposed to the moz.build sandbox.

I rejected two because it's both tied to the preprocessor, and awkward
to make handle the dependency on the buildid (in a file) and
additional build defines (in config.status).

I rejected three because I know of no precedent for this approach, and
it hides the dependency on the buildid.

One doesn't handle failures in the script gracefully, but neither did
the existing approach.  This patch is at least testable.

--HG--
extra : commitid : 8dfw1ri7qjr
extra : rebase_source : da0e5ec705e0ac4c795bd2d7892f73857a1699ac
2015-07-08 12:43:06 -07:00
..
dumbmake Bug 1176642 - Use absolute_import in mozbuild; r=glandium 2015-06-21 18:37:18 -07:00
mozbuild Bug 1182579 - Compute Android version codes in Python. r=gps 2015-07-08 12:43:06 -07:00
mozpack Bug 1176642 - Use absolute_import in mozpack; r=glandium 2015-06-25 12:13:55 -07:00
setup.py Bug 1172645 - Make mozbuild's setup.py work; r=glandium 2015-06-12 09:37:54 -07:00
TODO Bug 784841 - Part 2: Implement sandboxing for Python build files; r=ted,glandium 2013-01-15 22:21:21 -08:00