mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-20 00:35:44 +00:00
a8b76dc318
Following bug 1223599, NotifyDataArrived is called extremely often (every 32kB block downloaded). The combination of pinning the MediaResource with small cache reads while reading on another thread can causes incorrect read. While this issue needs to be addressed, the special handling of NotifyDataArrived with DirectShow ultimately serves no purpose. By the time we have read the metadata, we have already identified if the MP3 has a known duration. If not, the duration will be amended as data is being returned to the MDSM. Continually feeding new data to the MP3FrameParser only allow to account for the new data downloaded ahead of the last decoded sample and to get a slightly more accurate buffered range and duration. The new MP3Demuxer doesn't do it, and ultimately this makes the DirectShowReader behaves like the new MP3Demuxer and gives us consistency across the readers. MozReview-Commit-ID: HKNWWrofIqV --HG-- extra : rebase_source : 88d8ef9206e8a16097b2d493681e88b4c174d0c5 |
||
|---|---|---|
| .. | ||
| AudioSinkFilter.cpp | ||
| AudioSinkFilter.h | ||
| AudioSinkInputPin.cpp | ||
| AudioSinkInputPin.h | ||
| DirectShowDecoder.cpp | ||
| DirectShowDecoder.h | ||
| DirectShowReader.cpp | ||
| DirectShowReader.h | ||
| DirectShowUtils.cpp | ||
| DirectShowUtils.h | ||
| moz.build | ||
| SampleSink.cpp | ||
| SampleSink.h | ||
| SourceFilter.cpp | ||
| SourceFilter.h | ||