mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-17 23:35:34 +00:00
8bc98179e9
On the server, when looking for a flex container for a node, we were bailing out if the displayType of the node was null. It was null for pseudo-elements. This value was returned by the displayType getter in the NodeActor class. Now, the reason for this dates to 4 years ago in bug 1139937 where trying to get the display style of a pseudo-element was done in a way to failed. So we just decided to return null at that point. It doesn't fail anymore, we're able to return, say, "block" if a pseudo-element has a display:block style. So I've removed the checks that returned null and that fixed the issue here. The other part of the fix that was need is in the FlexItemActor class on the server too. This class can be created for a pseudo-element too. It accesses element.style without checking if that property exists. However it does not exist for pseudo-elements. So we needed to add a check for that. It's not a problem to just skip it in this case because pseudo-elements can't have inline styles. Differential Revision: https://phabricator.services.mozilla.com/D8873 --HG-- extra : moz-landing-system : lando |
||
|---|---|---|
| .. | ||
| actors | ||
| performance | ||
| socket | ||
| startup | ||
| tests | ||
| main.js | ||
| moz.build | ||