mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-11-27 06:43:32 +00:00
1a1f42da37
This changeset is the result of adding modernize-use-default-member-init to tools/clang-tidy/config.yaml then proceeding to run `./mach static-analysis check netwerk/ --fix` I then went through the resulting fix and manually updated all of the member variables which were missed due to them having a non-trivial constructor. Note that the tool was only run on Linux, so code that only runs on some platforms may have been missed. The member variables that are still initialized in the contructor definition are: - bitfields (not all currently supported compilers allow default-member-init - variables that are initialized via a parameter - variables that use code not visible in the header file There are a few advantages to landing this change: - fewer lines of code - now declaration is in the same place as initialization this also makes it easier to see when looking at the header. - it makes it harder to miss initializing a member when adding a new contructor - variables that depend on an include guard look much nicer now Additionally I removed some unnecessary reinitialization of NetAddr members (it has a constructor that does that now), and changed nsWifiScannerDBus to use the thread-safe strtok_r instead of strtok. Differential Revision: https://phabricator.services.mozilla.com/D116980
68 lines
2.3 KiB
C++
68 lines
2.3 KiB
C++
/* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
|
|
/* vim:set ts=2 sw=2 sts=2 et cindent: */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#ifndef PollableEvent_h__
|
|
#define PollableEvent_h__
|
|
|
|
#include "mozilla/Mutex.h"
|
|
#include "mozilla/TimeStamp.h"
|
|
|
|
struct PRFileDesc;
|
|
|
|
namespace mozilla {
|
|
namespace net {
|
|
|
|
// class must be called locked
|
|
class PollableEvent {
|
|
public:
|
|
PollableEvent();
|
|
~PollableEvent();
|
|
|
|
// Signal/Clear return false only if they fail
|
|
bool Signal();
|
|
// This is called only when we get non-null out_flags for the socket pair
|
|
bool Clear();
|
|
bool Valid() { return mWriteFD && mReadFD; }
|
|
|
|
// We want to detect if writing to one of the socket pair sockets takes
|
|
// too long to be received by the other socket from the pair.
|
|
// Hence, we remember the timestamp of the earliest write by a call to
|
|
// MarkFirstSignalTimestamp() from Signal(). After waking up from poll()
|
|
// we check how long it took get the 'readable' signal on the socket pair.
|
|
void MarkFirstSignalTimestamp();
|
|
// Called right before we enter poll() to exclude any possible delay between
|
|
// the earlist call to Signal() and entering poll() caused by processing
|
|
// of events dispatched to the socket transport thread.
|
|
void AdjustFirstSignalTimestamp();
|
|
// This returns false on following conditions:
|
|
// - PR_Write has failed
|
|
// - no out_flags were signalled on the socket pair for too long after
|
|
// the earliest Signal()
|
|
bool IsSignallingAlive(TimeDuration const& timeout);
|
|
|
|
PRFileDesc* PollableFD() { return mReadFD; }
|
|
|
|
private:
|
|
PRFileDesc* mWriteFD{nullptr};
|
|
PRFileDesc* mReadFD{nullptr};
|
|
bool mSignaled{false};
|
|
// true when PR_Write to the socket pair has failed (status < 1)
|
|
bool mWriteFailed{false};
|
|
// Set true after AdjustFirstSignalTimestamp() was called
|
|
// Set false after Clear() was called
|
|
// Ensures shifting the timestamp before entering poll() only once
|
|
// between Clear()'ings.
|
|
bool mSignalTimestampAdjusted{false};
|
|
// Timestamp of the first call to Signal() (or time we enter poll())
|
|
// that happened after the last Clear() call
|
|
TimeStamp mFirstSignalAfterClear;
|
|
};
|
|
|
|
} // namespace net
|
|
} // namespace mozilla
|
|
|
|
#endif
|