mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-12-01 08:42:13 +00:00
160e0a36f6
There were two assumptions preventing this output from being logged, both related to the case a test passes and xpcshell returns 0. The first was that we would not find crash dumps in this case, and would therefore not need to log the full output of the test process (in the case xpcshell returned non-zero or a test failed, we would log this output prior to checking for crashes). The second was that if a test was eligible to retry, we wouldn't need to store a test's output at all, because this output would only relate to a failure that we would consider non-fatal. The first assumption does not hold because it's possible to fatally assert at shutdown in tests spawning child processes without causing a test failure or non-zero exit code. The second assumption followed from the first, and is violated when the first is violated, because in this case we would consider a found crash fatal even when a test was eligible to retry. This patch reverses these assumptions and logs the full output of a test that passes but produces crash dumps. It's not clear that the existing code intended for a crash to ever be considered fatal when a test was eligible to retry, but to change this criteria now would reduce our effective test coverage by ignoring crashes that are now considered fatal, so after this patch we continue to consider this scenario fatal. If it is determined these crashes are related to these tests running in parallel with other tests, or they are not relevant for some other reason, these tests should be run sequentially, or this criteria should be changed. MozReview-Commit-ID: 2PaFSGx2MVR --HG-- extra : rebase_source : 34c0d1f13f4256928906729b1f3667bc395b2c56 |
||
|---|---|---|
| .. | ||
| example | ||
| moz-http2 | ||
| node-http2 | ||
| b2g_xpcshell_venv.sh | ||
| dbg-actors.js | ||
| head.js | ||
| mach_commands.py | ||
| mach_test_package_commands.py | ||
| moz.build | ||
| README | ||
| remotexpcshelltests.py | ||
| runtestsb2g.py | ||
| runxpcshelltests.py | ||
| selftest.py | ||
| xpcshell.eslintrc | ||
| xpcshellcommandline.py | ||
Simple xpcshell-based test harness converted from netwerk/test/unit Some documentation at http://developer.mozilla.org/en/docs/Writing_xpcshell-based_unit_tests See also http://wiki.mozilla.org/SoftwareTesting:Tools:Simple_xpcshell_test_harness