Read-only Git mirror of the Mercurial gecko repositories at https://hg.mozilla.org. How to contribute: https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
Go to file
Emilio Cobos Álvarez 5f05578314 Bug 1036966 - Make accessibility.tabfocus default to 7 on macOS too. r=morgan,settings-reviewers,mac-reviewers,mstange
Stop supporting following the system preference, but keep macOS users
able to switch to just text controls (accessibility.tabfocus=1) in the
settings.

Change the meaning of the "Use the tab key to move focus between form
controls and links" checkbox in the Firefox settings, which was
introduced in bug 1628476 to override the system setting.

The intention, I think was that this checkbox being off resulted in
"follow the system" behavior, but that didn't quite happen due to a bug
in the preferences code (this[1] won't unset the pref, because of
this[2], which means we'll just return 0).

This patch changes it so that the checkbox instead always ignores the
system setting. There will no longer be a Firefox setting (neither in
the UI nor on about:config) that means "follow system setting".

This allows us to somewhat simplify the approach compared to the
previous patch in D196110, and keep the accessibility.tabfocus working
as the source of truth without a migration.

In the future, we can think of migrating accessibility.tabfocus to a
boolean pref, which would allow us to do the cleanups to the preferences
code that D196110 did.

[1]: https://searchfox.org/mozilla-central/rev/f1532761de0b60337e42c6c3f525288a523dabef/browser/components/preferences/main.js#2252
[2]: https://searchfox.org/mozilla-central/rev/f1532761de0b60337e42c6c3f525288a523dabef/toolkit/content/preferencesBindings.js#450,483

Differential Revision: https://phabricator.services.mozilla.com/D208602
2024-05-03 23:10:47 +00:00
.cargo Bug 1893057 - build(webgpu): update WGPU to latest trunk as of 2024-04-22 r=webgpu-reviewers,supply-chain-reviewers,jimb 2024-05-02 18:17:36 +00:00
.github/workflows
.vscode
accessible Bug 1488080 Part 1 - Convert GetAllInFlowRects flags to EnumSet. r=dholbert 2024-05-03 18:42:41 +00:00
browser Bug 1036966 - Make accessibility.tabfocus default to 7 on macOS too. r=morgan,settings-reviewers,mac-reviewers,mstange 2024-05-03 23:10:47 +00:00
build Bug 1892005 - Move MOZ_LINUX_32_SSE2_STARTUP_ERROR env check to moz.configure r=glandium 2024-05-03 05:57:52 +00:00
caps Bug 1892481 - More consistently enforce noscript and builtinclass in xpidl, r=xpcom-reviewers,necko-reviewers,valentin,media-playback-reviewers,mccr8,padenot 2024-04-22 18:19:58 +00:00
chrome Bug 1864896: Autofix unused function arguments (general). r=nika,jfkthame,ckerschb 2024-03-19 14:59:22 +00:00
config Bug 1877926 - Make mach build --keep-going pass --keep-going to cargo. r=firefox-build-system-reviewers,nalexander 2024-05-02 04:20:41 +00:00
devtools Bug 1893611 - Add shouldAvoidSideEffects debugger flag and use it in Services resolve hook. r=iain,devtools-reviewers,nchevobbe 2024-05-03 20:06:38 +00:00
docs Bug 1843629 - Explain some non-fatal errors in the OS build docs. r=sylvestre DONTBUILD 2024-05-03 11:28:15 +00:00
docshell Bug 1677190 - Introduce SessionStoreFunctions for GeckoView package and move the existing SessionStoreFunctions from toolkit to the browser package. r=geckoview-reviewers,farre,nika,owlish 2024-04-30 11:17:55 +00:00
dom Bug 1036966 - Make accessibility.tabfocus default to 7 on macOS too. r=morgan,settings-reviewers,mac-reviewers,mstange 2024-05-03 23:10:47 +00:00
editor Bug 1877513 - Make HTMLEditor deletes only preceding lines of right child block if the range starts from start of a line r=m_kato 2024-04-27 00:36:26 +00:00
extensions Bug 1893434 - Test, r=manuel,anti-tracking-reviewers 2024-04-30 09:30:33 +00:00
gfx Bug 1888581 - Copy FontVariation data instead of doing an unsound cast. r=jrmuizel 2024-05-03 22:45:35 +00:00
gradle/wrapper Bug 1887180 - Update Gradle to version 8.7. r=android-reviewers 2024-03-25 14:35:36 +00:00
hal Bug 1875484 - Add missing null check in Hal code. r=gsvelto 2024-01-22 18:56:18 +00:00
image Bug 1806946 - Skip GTests which fail when run under TSAN. r=profiler-reviewers,dom-storage-reviewers,tnikkel,xpcom-reviewers,ipc-reviewers,mccr8,janv,webrtc-reviewers,pehrsons,canaltinova 2024-05-02 13:09:07 +00:00
intl Bug 1894551 - remove old win/aarch64 references in gtest moz.build files. r=RyanVM,necko-reviewers 2024-05-02 12:17:06 +00:00
ipc Bug 1893150 - Handle actor id registration errors more explicitly, r=ipc-reviewers,mccr8 2024-05-03 17:21:16 +00:00
js Bug 1893611 - Add shouldAvoidSideEffects debugger flag and use it in Services resolve hook. r=iain,devtools-reviewers,nchevobbe 2024-05-03 20:06:38 +00:00
layout Bug 1894564: Add an explicit scrollbar-color for textarea ltr/rtl scrollbar position reftests. r=layout-reviewers,emilio 2024-05-03 22:26:09 +00:00
media Backed out changeset 4a57673e2054 (bug 1894110) for causing MinGW build bustages & crashtest failures CLOSED TREE 2024-05-03 09:48:45 +03:00
memory Bug 1894551 - remove old win/aarch64 references in gtest moz.build files. r=RyanVM,necko-reviewers 2024-05-02 12:17:06 +00:00
mfbt Bug 1894147 - Fix C++20 std::memory_order build errors in MPSCQueue.h. r=xpcom-reviewers,emilio 2024-04-30 15:37:35 +00:00
mobile Bug 1879011 - Fix openFirefoxSuggestSponsoredSearchResultsTest r=jajohnson 2024-05-03 20:05:55 +00:00
modules Bug 1036966 - Make accessibility.tabfocus default to 7 on macOS too. r=morgan,settings-reviewers,mac-reviewers,mstange 2024-05-03 23:10:47 +00:00
mozglue Backed out 2 changesets (bug 1849075, bug 1878764) for causing mass crashes at panicking.rs. CLOSED TREE 2024-05-03 00:17:49 +03:00
netwerk Bug 1871082 - Remove unnecessary commented out TEST_RESTART_LOGIC code r=edgul,necko-reviewers,valentin 2024-05-03 19:38:24 +00:00
nsprpub Bug 1879120 - Remove all python deprecation warning: invalid escape sequence r=ahochheiden,webdriver-reviewers,perftest-reviewers,afinder UPGRADE_NSPR_RELEASE 2024-02-26 08:26:38 +00:00
other-licenses Bug 1883629 - Update Snappy to version 1.2.0. r=dom-storage-reviewers,janv 2024-04-08 13:48:06 +00:00
parser Bug 1884208 - Remove negative probes for measuring delta between OnDataFinished and OnStopRequest in HttpChannelChild and HTML5Parser. r=jesup,necko-reviewers 2024-03-28 09:37:25 +00:00
python Bug 1894645 - Adjust non-default-target case after bug 1459764. r=firefox-build-system-reviewers,nalexander 2024-05-02 19:34:10 +00:00
remote Bug 1798464 - [marionette] Removed usage of 'isElementEnabled' Selenium atom. r=webdriver-reviewers,Sasha 2024-05-03 08:59:22 +00:00
security Bug 1894826 - Don't update digest when given string is empty. r=jschanck 2024-05-02 22:49:28 +00:00
services No Bug, mozilla-central repo-update remote-settings tld-suffixes mobile-experiments - r=release-managers,dmeehan 2024-05-03 11:59:24 +00:00
servo Bug 1894792 - build: update style's dep. on indexmap 1 → 2 r=glandium 2024-05-03 20:09:53 +00:00
startupcache Bug 1882581: Implement @scope parsing. r=firefox-style-system-reviewers,saschanaz,emilio 2024-03-19 13:36:48 +00:00
storage Bug 1806946 - Skip GTests which fail when run under TSAN. r=profiler-reviewers,dom-storage-reviewers,tnikkel,xpcom-reviewers,ipc-reviewers,mccr8,janv,webrtc-reviewers,pehrsons,canaltinova 2024-05-02 13:09:07 +00:00
supply-chain Bug 1894792 - build: upgrade sfv 0.9.3 → 0.9.4 r=supply-chain-reviewers 2024-05-03 20:09:53 +00:00
taskcluster Bug 1894819 - Fix notarization task description r=releng-reviewers,taskgraph-reviewers,gabriel 2024-05-03 16:57:05 +00:00
testing Bug 1888731 - Add bugzilla components for wpt tests and adjust implementation status as needed. r=aryx 2024-05-03 22:35:58 +00:00
third_party Bug 1894792 - build: upgrade sfv 0.9.3 → 0.9.4 r=supply-chain-reviewers 2024-05-03 20:09:53 +00:00
toolkit Backed out changeset ede7a0b15af0 (bug 1742889) for causing node tests failures. CLOSED TREE 2024-05-03 23:12:24 +03:00
tools Bug 1894367 - Update perfdocs with talos changes. r=perftest-reviewers,kshampur DONTBUILD 2024-05-03 14:25:22 +00:00
uriloader Bug 1883693 - Remove early return in nsExternalProtocolHandler::NewChannel when handler doesn't exist r=nika 2024-05-02 18:11:51 +00:00
view Bug 1893357 - Drop |aRepaintExposedAreaOnly| argument from nsViewManager::ResizeView(). r=tnikkel 2024-04-25 02:37:26 +00:00
widget Bug 1036966 - Make accessibility.tabfocus default to 7 on macOS too. r=morgan,settings-reviewers,mac-reviewers,mstange 2024-05-03 23:10:47 +00:00
xpcom no bug - license: add a missing license line r=jcristau DONTBUILD 2024-05-02 17:55:19 +00:00
xpfe/appshell Bug 1893918 - A not-yet-loaded browser window shouldn't stop being an early blank window. r=win-reviewers,rkraesig 2024-04-30 08:39:59 +00:00
.arcconfig
.babel-eslint.rc.js
.clang-format
.clang-format-ignore Bug 1889978 - Vendor ffmpeg 7.0 headers. r=media-playback-reviewers,frontend-codestyle-reviewers,alwu 2024-04-30 14:21:45 +00:00
.cron.yml Bug 1890373 - Enable android-l10n-sync via cron on mozilla-beta r=hneiva,gabriel 2024-04-15 18:07:57 +00:00
.eslintignore Bug 1864255. Move crashtests that leave window(s) open to the very end. r=dholbert,frontend-codestyle-reviewers 2024-04-21 21:37:49 +00:00
.eslintrc-test-paths.js Bug 1876432 - Added support for custom themes as its own menu in Reader View. r=reader-mode-reviewers,fluent-reviewers,desktop-theme-reviewers,hjones,accessibility-frontend-reviewers,bolsson,devtools-reviewers,sfoster,cmkm,jules,ayeddi 2024-04-02 00:08:46 +00:00
.eslintrc.js Bug 1891982 - Part 1: Copy Top Sites Feed into the Top Sites component - r=dao,frontend-codestyle-reviewers,Standard8 2024-04-23 18:32:30 +00:00
.git-blame-ignore-revs Bug 1882465 - Update .hg-annotate-ignore-revs and .git-blame-ignore-revs to reflect firefox-android monorepo migration r=glandium,geckoview-reviewers,tthibaud 2024-04-04 14:55:00 +00:00
.gitattributes
.gitignore Bug 1894617: ignore the root .vscode directory too; r=sheehan 2024-05-02 18:26:11 +00:00
.hg-annotate-ignore-revs Bug 1882465 - Update .hg-annotate-ignore-revs and .git-blame-ignore-revs to reflect firefox-android monorepo migration r=glandium,geckoview-reviewers,tthibaud 2024-04-04 14:55:00 +00:00
.hg-format-source
.hgignore Bug 1894619 - Remove the invalid regex escape sequences in .hgignore. r=sheehan 2024-05-02 18:28:22 +00:00
.hgtags No bug - tagging de27b0fc3ab30bad572ccdcd8ea161d1f9a198ad with FIREFOX_NIGHTLY_126_END a=release DONTBUILD CLOSED TREE 2024-04-15 08:26:20 +00:00
.lando.ini Bug 1871425: re-enable autoformatting after disabling WPT linter r=zeid DONTBUILD 2024-02-29 21:22:27 +00:00
.lldbinit
.mailmap Bug 1892339 - Add my name to .mailmap r=nika 2024-04-19 13:42:34 +00:00
.prettierignore Bug 1889978 - Vendor ffmpeg 7.0 headers. r=media-playback-reviewers,frontend-codestyle-reviewers,alwu 2024-04-30 14:21:45 +00:00
.prettierrc.js
.stylelintignore Bug 1881094 - 5. remove stylelint exclusions for firefox-android r=android-reviewers,frontend-codestyle-reviewers,gl 2024-05-02 18:38:36 +00:00
.stylelintrc.js
.taskcluster.yml
.trackerignore
.yamllint
.ycm_extra_conf.py
aclocal.m4 Bug 1881545 - Move nl_langinfo and CODESET check from js/src/old-configure.in to js/moz.configure r=glandium 2024-02-28 11:11:18 +00:00
AUTHORS
build.gradle Bug 1892641 - include timestamps in BUILDSTATUS lines from gradle, r=glandium. 2024-04-30 08:17:13 +00:00
Cargo.lock Bug 1894792 - build: update style's dep. on indexmap 1 → 2 r=glandium 2024-05-03 20:09:53 +00:00
Cargo.toml Bug 1893057 - build(webgpu): update WGPU to latest trunk as of 2024-04-22 r=webgpu-reviewers,supply-chain-reviewers,jimb 2024-05-02 18:17:36 +00:00
client.mk
client.py
CLOBBER Bug 1889978 - Vendor ffmpeg master, after 7.0, update and reapply patch, remove old files, move bsf files into the bsf directory. r=media-playback-reviewers,alwu 2024-04-30 14:21:45 +00:00
configure
configure.py
GNUmakefile
gradle.properties Bug 1873677 - Upgrade Gradle to 8.5 version r=geckoview-reviewers,calu 2024-01-23 14:50:12 +00:00
gradlew Bug 1873677 - Upgrade Gradle to 8.5 version r=geckoview-reviewers,calu 2024-01-23 14:50:12 +00:00
gradlew.bat Bug 1878410 - Update Gradle to version 8.6. r=geckoview-reviewers,mcarare,amejiamarmol 2024-02-05 16:01:14 +00:00
LICENSE
mach
mach.cmd
mach.ps1
Makefile.in Bug 1873959 - Only force generation of buildid.h and source-repo.h during export phase r=glandium 2024-01-16 13:49:03 +00:00
mots.yaml Bug 1891966: Re-add supply chain module and other missed changes to mots. r=bholley,zeid 2024-05-03 14:01:18 +00:00
moz.build Bug 1888321 - Rename .cargo/config.in to .cargo/config.toml.in. r=firefox-build-system-reviewers,webdriver-reviewers,ahochheiden 2024-04-01 21:26:49 +00:00
moz.configure Bug 1880424 - Move clock_monotonic check to moz.configure r=glandium 2024-02-28 11:11:17 +00:00
mozilla-config.h.in
old-configure.in Bug 1892005 - Move MOZ_LINUX_32_SSE2_STARTUP_ERROR env check to moz.configure r=glandium 2024-05-03 05:57:52 +00:00
package-lock.json Bug 1557040 - Remove eslint-plugin-fetch-options from the tree. r=Gijs,omc-reviewers,aminomancer,home-newtab-reviewers,frontend-codestyle-reviewers,thecount 2024-04-09 08:11:10 +00:00
package.json Bug 1557040 - Remove eslint-plugin-fetch-options from the tree. r=Gijs,omc-reviewers,aminomancer,home-newtab-reviewers,frontend-codestyle-reviewers,thecount 2024-04-09 08:11:10 +00:00
pyproject.toml Bug 1879558 - Reactivate invalid escape sequence warning in ruff r=ahochheiden 2024-02-28 08:16:06 +00:00
README.txt
settings.gradle Bug 1876335 - use GRADLE_MAVEN_REPOSITORIES in more places. r=owlish,geckoview-reviewers,nalexander,tthibaud,android-reviewers 2024-01-18 15:38:47 +01:00
substitute-local-geckoview.gradle
test.mozbuild

An explanation of the Firefox Source Code Directory Structure and links to
project pages with documentation can be found at:

    https://firefox-source-docs.mozilla.org/contributing/directory_structure.html

For information on how to build Firefox from the source code and create the patch see:

    https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html

If you have a question about developing Firefox, and can't find the solution
on https://firefox-source-docs.mozilla.org/, you can try asking your question on Matrix at chat.mozilla.org in `Introduction` (https://chat.mozilla.org/#/room/#introduction:mozilla.org) channel.


Nightly development builds can be downloaded from:

    https://archive.mozilla.org/pub/firefox/nightly/latest-mozilla-central/
            - or -
    https://www.mozilla.org/firefox/channel/desktop/#nightly

Keep in mind that nightly builds, which are used by Firefox developers for
testing, may be buggy.