gecko-dev/python/mozbuild/mozpack
Nick Alexander 00bbcb11bb Bug 1429815 - Fix InstallManifest::add_entries_from with non-trivial base. r=gps
There's a bug in InstallManifest::add_entries_from: some of the
manifest entries bake their destination into both the manifest key and
the manifest value, and add_entries_from with a non-empty "base"
parameter to prepend to the destination only updates the manifest key
and not the value.

This bug causes |mach watch| to fail to _read_ the unified manifest
that aggregates all of the build manifests relevant to |mach watch|
that |mach build-backend -b FasterMake| successfully _wrote_, because
the manifest keys are validated against the manifest values written to
disk.

I see no way to address this other than to manually reach into the
manifest values and patch the internal destination parameter, which
this patch does.

MozReview-Commit-ID: FVyRB41NnHa

--HG--
extra : rebase_source : 23eb18ddc0452955539ce2e7a6d7bbfd083c940c
2018-01-18 16:58:07 -08:00
..
chrome Bug 1428938 - Remove legacy toolbar customization code. r=Gijs 2018-01-11 16:35:17 +00:00
packager Bug 1415432 - .ftl files repackaged multiple times. r=glandium 2017-11-07 22:16:16 -08:00
test Bug 1429815 - Fix InstallManifest::add_entries_from with non-trivial base. r=gps 2018-01-18 16:58:07 -08:00
__init__.py
archive.py Bug 1390968: python-3 compatibility for python/**/*.py; r=Alex_Gaynor,gps 2017-08-28 21:31:30 +00:00
copier.py Bug 1352595 - Add basic support for brotli compression to the packager. r=gps 2017-08-18 05:37:18 +09:00
dmg.py Bug 1426528: Pass paths to extra dmg files explicitly when packing; r=glandium 2017-12-21 13:38:35 -07:00
errors.py
executables.py
files.py Bug 1393242 - Normalize paths in MercurialRevisionFinder; r=mshal 2017-08-31 10:39:28 -07:00
hg.py
manifests.py Bug 1429815 - Fix InstallManifest::add_entries_from with non-trivial base. r=gps 2018-01-18 16:58:07 -08:00
mozjar.py Bug 1317041 - Calculate crc32 incrementally; r=gps 2017-11-07 15:34:20 -08:00
path.py Bug 1427213: Clean up docstrings in mozpack.path; r=glandium 2017-12-27 15:57:32 -07:00