mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-08 02:14:43 +00:00
eb6fa5f6d7
In code-coverage builds we have code which, after `fork` in the child process, does a number of async-signal-unsafe operations which aren't permitted in that context. In particular, locking is a problem: if another thread in the parent process had held the lock, it will deadlock. Most of this is conditional on the `GCOV_CHILD_PREFIX` env var being set, and currently we don't (see bug 1724239), but checking that env var itself is a problem, because `PR_GetEnv` takes a mutex. (This was found by inspection, so I don't know if it's happening in practice, but it's possible that mysterious timeouts on ccov builds might be caused by this bug.) Therefore, this patch moves reading the env var into the parent process, where it's safe; the rest of the code still contains unsafe operations (although our `pthread_atfork` hooks in mozjemalloc might help) but it won't be run. This will need further cleanup at some point; see bug 1783305. Differential Revision: https://phabricator.services.mozilla.com/D154572 |
||
|---|---|---|
| .. | ||
| gtest | ||
| src | ||
| chromium-config.mozbuild | ||
| moz.build | ||