gecko-dev/mobile
Grigory Kruglov c506f4dc28 Bug 1400742 - Remove per-account in-memory cache r=nalexander
1368147 added reading fxa.account.json into the unbundle() codepath for the cases
when the in-memory cache isn't populated. This surfaced a race condition:
pickling of the fxa.account.json file and running unbundle() (as triggered from various
parts of the UI, or othe SyncStatusObservers) will race, and if unbundle wins, it
will attempt to read a yet-to-be-created fxa.account.json file, and crash.

Fixing the race isn't trivial, but we can avoid it by removing the in-memory cache,
thus avoiding having to read the cache key from the pickled file (uid).

In-memory cache was added in response to caching/invalidation issues of set/getUserData,
see Bug 964854 for the history. The current thinking is that those problems are pre-API16,
which hopefully means that we shouldn't encounter them anymore, and thus can remove the
workaround entirely.

MozReview-Commit-ID: AfL2Jq4IlYT

--HG--
extra : rebase_source : 8bcdd1bc084700694d52bce3a2f1ae536b7fe9e1
2017-09-20 18:21:06 -04:00
..
android Bug 1400742 - Remove per-account in-memory cache r=nalexander 2017-09-20 18:21:06 -04:00
locales Bug 1394462 - Update dnsNotFound error copy and illustration. r=nhnt11 2017-09-19 21:54:29 +02:00