gecko-dev/ipc/glue/CrossProcessSemaphore_posix.cpp
Ryan Hunt 084c9b6f4c Allocate TextureReadLock at TextureClient creation and drop file handles immediately after. (bug 1416726, r=aosmond)
This changes the lifecycle and API for TextureReadLock to fix file descriptor exhaustion
crashes. These changes are partially superficial and mostly align the API of TextureReadLocks
with their actual usage.

The changes are:

1. Create the TextureReadLock in the TextureClient constructor so it's available before IPC creation
    a. This is superficial as EnableReadLock was always called before IPC creation
2. Send the ReadLockDescriptor in the PTextureConstructor message and close the file handle
3. Receive the ReadLockDescriptor in TextureHost and close the file handle
4. Send a boolean flag in layer transactions if the texture is read locked instead of a descriptor
5. Use a boolean flag in TextureHost to determine if the ReadLock must be unlocked instead of a nullptr

I believe that we can remove the InitReadLocks code from LayerTransaction as that was added to
prevent file descriptor limits in IPDL messages and is no longer needed with this change. But
that is a non-essential change and this patch is already big enough.

MozReview-Commit-ID: DzHujrOQejH

--HG--
extra : rebase_source : 3bdd7c9bc8edfdc386faad8a9e59ad7dc18ed91d
2018-03-12 08:10:13 -05:00

174 lines
4.1 KiB
C++

/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#include "CrossProcessSemaphore.h"
#include "mozilla/Unused.h"
#include "nsDebug.h"
#include "nsISupportsImpl.h"
#include <errno.h>
static const uint64_t kNsPerMs = 1000000;
static const uint64_t kNsPerSec = 1000000000;
namespace {
struct SemaphoreData {
sem_t mSemaphore;
mozilla::Atomic<int32_t> mRefCount;
uint32_t mInitialValue;
};
} // namespace
namespace mozilla {
/* static */ CrossProcessSemaphore*
CrossProcessSemaphore::Create(const char*, uint32_t aInitialValue)
{
RefPtr<ipc::SharedMemoryBasic> sharedBuffer = new ipc::SharedMemoryBasic;
if (!sharedBuffer->Create(sizeof(SemaphoreData))) {
return nullptr;
}
if (!sharedBuffer->Map(sizeof(SemaphoreData))) {
return nullptr;
}
SemaphoreData* data = static_cast<SemaphoreData*>(sharedBuffer->memory());
if (!data) {
return nullptr;
}
if (sem_init(&data->mSemaphore, 1, aInitialValue)) {
return nullptr;
}
CrossProcessSemaphore* sem = new CrossProcessSemaphore;
sem->mSharedBuffer = sharedBuffer;
sem->mSemaphore = &data->mSemaphore;
sem->mRefCount = &data->mRefCount;
*sem->mRefCount = 1;
data->mInitialValue = aInitialValue;
return sem;
}
/* static */ CrossProcessSemaphore*
CrossProcessSemaphore::Create(CrossProcessSemaphoreHandle aHandle)
{
RefPtr<ipc::SharedMemoryBasic> sharedBuffer = new ipc::SharedMemoryBasic;
if (!sharedBuffer->IsHandleValid(aHandle)) {
return nullptr;
}
if (!sharedBuffer->SetHandle(aHandle, ipc::SharedMemory::RightsReadWrite)) {
return nullptr;
}
if (!sharedBuffer->Map(sizeof(SemaphoreData))) {
return nullptr;
}
sharedBuffer->CloseHandle();
SemaphoreData* data = static_cast<SemaphoreData*>(sharedBuffer->memory());
if (!data) {
return nullptr;
}
int32_t oldCount = data->mRefCount++;
if (oldCount == 0) {
// The other side has already let go of their CrossProcessSemaphore, so now
// mSemaphore is garbage. We need to re-initialize it.
if (sem_init(&data->mSemaphore, 1, data->mInitialValue)) {
data->mRefCount--;
return nullptr;
}
}
CrossProcessSemaphore* sem = new CrossProcessSemaphore;
sem->mSharedBuffer = sharedBuffer;
sem->mSemaphore = &data->mSemaphore;
sem->mRefCount = &data->mRefCount;
return sem;
}
CrossProcessSemaphore::CrossProcessSemaphore()
: mSemaphore(nullptr)
, mRefCount(nullptr)
{
MOZ_COUNT_CTOR(CrossProcessSemaphore);
}
CrossProcessSemaphore::~CrossProcessSemaphore()
{
int32_t oldCount = --(*mRefCount);
if (oldCount == 0) {
// Nothing can be done if the destroy fails so ignore return code.
Unused << sem_destroy(mSemaphore);
}
MOZ_COUNT_DTOR(CrossProcessSemaphore);
}
bool
CrossProcessSemaphore::Wait(const Maybe<TimeDuration>& aWaitTime)
{
MOZ_ASSERT(*mRefCount > 0, "Attempting to wait on a semaphore with zero ref count");
int ret;
if (aWaitTime.isSome()) {
struct timespec ts;
if (clock_gettime(CLOCK_REALTIME, &ts) == -1) {
return false;
}
ts.tv_nsec += (kNsPerMs * aWaitTime->ToMilliseconds());
ts.tv_sec += ts.tv_nsec / kNsPerSec;
ts.tv_nsec %= kNsPerSec;
while ((ret = sem_timedwait(mSemaphore, &ts)) == -1 && errno == EINTR) {
}
} else {
while ((ret = sem_wait(mSemaphore)) == -1 && errno == EINTR) {
}
}
return ret == 0;
}
void
CrossProcessSemaphore::Signal()
{
MOZ_ASSERT(*mRefCount > 0, "Attempting to signal a semaphore with zero ref count");
sem_post(mSemaphore);
}
CrossProcessSemaphoreHandle
CrossProcessSemaphore::ShareToProcess(base::ProcessId aTargetPid)
{
CrossProcessSemaphoreHandle result = ipc::SharedMemoryBasic::NULLHandle();
if (mSharedBuffer && !mSharedBuffer->ShareToProcess(aTargetPid, &result)) {
MOZ_CRASH();
}
return result;
}
void
CrossProcessSemaphore::CloseHandle()
{
mSharedBuffer->CloseHandle();
}
} // namespace mozilla