Read-only Git mirror of the Mercurial gecko repositories at https://hg.mozilla.org. How to contribute: https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
Go to file
Oriol Brufau 69270edb78 Bug 1671140 [wpt PR 26101] - Avoid DCHECK failure when reusing space and newline with white-space:pre, a=testonly
Automatic update from web-platform-tests
Avoid DCHECK failure when reusing space and newline with white-space:pre

Consider this code:
  <style>i { white-space: pre-line }</style>
  X<i> </i><i>&#10;</i>

The first time that NGInlineNode::CollectInlines runs, the text data
will be "X", then "X ", and then AppendForcedBreakCollapseWhitespace
will remove the trailing whitespace before inserting the forced break,
so we get "X\n".

But if some text is appended dynamically, CollectInlines will run again,
and this time it will try to reuse existing items in AppendTextReusing.
Before this patch, this would produce "X \n", which would trigger a
DCHECK failure in ComputeOffsetMapping because it's a different string.

Therefore, this patch prevents AppendTextReusing from reusing existing
items if the last item to collapse with ends with collapsible spaces and
the first item to reuse has 'white-space:pre' and begins with a newline.

Bug: 1136688

TEST=external/wpt/css/css-text/white-space/pre-line-with-space-and-newline.html

Change-Id: I0ff71b125b66256ec3b5c263605c3c116f9ac55f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466279
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#816641}

--

wpt-commits: 5b6e508729caf23ab70c4db695315aef951c3d50
wpt-pr: 26101
2020-10-20 13:24:59 +00:00
.cargo Bug 1670341 - Update mp4parse-rust to eliminate multiple versions of hashbrown crate. r=emilio 2020-10-16 19:49:05 +00:00
.vscode
accessible Bug 1670846: Treat line break characters in pre-formatted text as a11y paragraph boundaries. r=MarcoZ 2020-10-18 09:19:23 +00:00
browser Bug 1668284 - Unknown content type change settings label is no longer accurate. r=Gijs,fluent-reviewers,flod 2020-10-20 12:34:45 +00:00
build Bug 1672127 - Fix browser_fall_back_to_https.js to use actual host r=ckerschb 2020-10-20 10:26:41 +00:00
caps Bug 1626016 - Remove createFixupURI and move postData inside URIFixupInfo. r=Gijs,geckoview-reviewers,preferences-reviewers,snorp 2020-10-13 10:20:16 +00:00
chrome Bug 1669833 - Removed else after the return statement. r=jfkthame 2020-10-17 13:47:13 +00:00
config Backed out 5 changesets (bug 1644624, bug 1671555) for windows shippable bustage. 2020-10-20 06:52:09 +03:00
devtools Bug 1672132 - [devtools] Inline renderPanel into boostrapApp. r=jdescottes. 2020-10-20 12:35:24 +00:00
docs no bug - Remove old DXR references r=andi DONTBUILD 2020-10-20 11:59:25 +00:00
docshell Bug 1672127 - Fix browser_fall_back_to_https.js to use actual host r=ckerschb 2020-10-20 10:26:41 +00:00
dom Bug 1663924 - Use IDB_TRY in ObjectStoreAddOrPutRequestOp::DoDatabaseWork. r=dom-workers-and-storage-reviewers,ttung 2020-10-20 12:01:15 +00:00
editor Bug 1607131 - Make beforeinput event for MozEditableElement.setUserInput() not cancelable by default r=smaug 2020-10-20 00:13:43 +00:00
extensions Bug 1607131 - Make beforeinput event for MozEditableElement.setUserInput() not cancelable by default r=smaug 2020-10-20 00:13:43 +00:00
gfx Bug 1656211 - Force recompositing frames on GTK when popup window configuration changes. r=nical 2020-10-19 07:44:59 +00:00
gradle/wrapper
hal
image Bug 1656114 - Part 5: Report use counters in documents that come out of the bfcache. r=nika 2020-10-11 22:15:06 +00:00
intl Bug 1669573 - Add DataTimeFormat::FormatDateTime; r=zbraniecki 2020-10-15 12:21:52 +00:00
ipc Bug 1671577 - Use OtherPid() in AddProfilerMarker(). r=jld 2020-10-16 17:53:42 +00:00
js Bug 1665411 - Use first-fit mutexes on macOS r=spohl 2020-10-20 12:07:30 +00:00
layout Bug 1671863 - Skip reftest on mingw platform. r=heycam 2020-10-20 02:46:28 +00:00
media Bug 1669888 - Enable ffvpx on all Mac platforms. r=jya 2020-10-08 05:28:28 +00:00
memory Bug 1671623 - don't overloaded log10 r=pbone 2020-10-19 06:42:45 +00:00
mfbt no bug - TSan library excludes miss libdconfsettings. r=Gankro 2020-10-14 19:35:24 +00:00
mobile Bug 1672046 - Use correct URI from Event in GeckoViewProgress. r=esawin 2020-10-19 21:03:13 +00:00
modules Bug 1619673 - Disable appcache in release r=dragana 2020-10-20 12:14:16 +00:00
mozglue Bug 1665411 - Use first-fit mutexes on macOS r=spohl 2020-10-20 12:07:30 +00:00
netwerk Bug 1669355 - Refactor MIME type warnings into base class. r=necko-reviewers,valentin 2020-10-19 07:00:41 +00:00
nsprpub Bug 1660371 - NSPR_4_29_RTM. r=kjacobs UPGRADE_NSPR_RELEASE DONTBUILD 2020-09-17 15:26:54 +00:00
other-licenses
parser Bug 1669664 - Don't speculatively load scripts, etc inside a template element. r=hsivonen 2020-10-14 21:58:50 +00:00
python Bug 1615884 - Handle Windows separators correctly when calling clang-format -d on Windows, while allowing writing path with '/' on the command-line. r=andi 2020-10-19 12:33:50 +00:00
remote Bug 1668851 - Try to write data to socket directly without waiting r=necko-reviewers,dragana,remote-protocol-reviewers 2020-10-08 13:26:03 +00:00
security No Bug, mozilla-central repo-update HSTS HPKP remote-settings - a=repo-update r=jcristau 2020-10-19 14:31:18 +00:00
services Merge autoland to mozilla-central. a=merge 2020-10-20 00:37:32 +03:00
servo Bug 1671401 - Use separate Scrollbar and ThemedScrollbar ColorIDs. r=spohl 2020-10-16 12:49:47 +00:00
startupcache
storage Bug 1663924 - Split BorrowedStatement from CachedStatement. r=dom-workers-and-storage-reviewers,janv 2020-09-29 10:57:19 +00:00
taskcluster Backed out 5 changesets (bug 1644624, bug 1671555) for windows shippable bustage. 2020-10-20 06:52:09 +03:00
testing Bug 1671140 [wpt PR 26101] - Avoid DCHECK failure when reusing space and newline with white-space:pre, a=testonly 2020-10-20 13:24:59 +00:00
third_party Bug 1622846 - WebGPU new mapping API r=webidl,jgilbert,smaug 2020-10-19 17:19:12 +00:00
toolkit Bug 1668284 - Unknown content type change settings label is no longer accurate. r=Gijs,fluent-reviewers,flod 2020-10-20 12:34:45 +00:00
tools Backed out 7 changesets (bug 1661304) for xpcshell failures on test_UserInteraction_annotations.js. CLOSED TREE 2020-10-19 21:39:07 +03:00
uriloader Bug 1637745 - Test. r=Gijs 2020-10-20 09:05:59 +00:00
view
widget Bug 1656211 - Force recompositing frames on GTK when popup window configuration changes. r=nical 2020-10-19 07:44:59 +00:00
xpcom Backed out 12 changesets (bug 1626278) for mochitest leakchecks . CLOSED TREE 2020-10-19 22:58:59 +03:00
xpfe/appshell Bug 1667081 - Part 3: Remove windowLowered in nsIFocusManager; r=hsivonen 2020-09-29 07:21:34 +00:00
.arcconfig
.babel-eslint.rc.js
.clang-format
.clang-format-ignore Bug 1667674 - [Wayland] Support public primary-selection unstable protocol. r=stransky 2020-10-02 09:13:06 +00:00
.cron.yml
.eslintignore Bug 1669956 - [devtools] Enable eslint for devtools/client/shared/components/reps. r=jdescottes. 2020-10-14 11:33:16 +00:00
.eslintrc.js Bug 1665713 - pt3 - fix js lint issues resulting from moving mochitest directory. r=ng 2020-10-02 16:29:35 +00:00
.flake8 Bug 1622686 - Make testing/web-platform flake8 compliant. r=sylvestre,jgraham 2020-09-29 14:22:49 +00:00
.git-blame-ignore-revs
.gitattributes
.gitignore Bug 1663372 - Ignore toolchains.json file with git. r=glandium 2020-09-25 13:09:50 +00:00
.hg-annotate-ignore-revs
.hg-format-source
.hgignore
.hgtags No bug - tagging 6d98cc745df58e544a8d71c131f060fc2c460d83 with FIREFOX_NIGHTLY_83_END a=release DONTBUILD CLOSED TREE 2020-10-19 16:38:59 +00:00
.lldbinit
.mailmap
.prettierignore
.prettierrc
.taskcluster.yml Bug 1666809 - Insert decision task indexes directly via taskluster API rather than index-task, r=taskgraph-reviewers,aki 2020-09-24 19:19:36 +00:00
.trackerignore
.yamllint
.ycm_extra_conf.py
aclocal.m4
AUTHORS
build.gradle Bug 1553459 - Migrate to AndroidX r=geckoview-reviewers,agi 2020-09-18 22:29:04 +00:00
Cargo.lock Bug 1622846 - WebGPU new mapping API r=webidl,jgilbert,smaug 2020-10-19 17:19:12 +00:00
Cargo.toml Bug 1669055: Vendor Cranelift e22e2c3722f2fbccd3c8d3230119fa04c332c69c. r=jseward 2020-10-07 06:25:50 +00:00
client.mk Backed out changeset e34634758f51 (bug 1671424) for bustages on configure.py . CLOSED TREE 2020-10-20 00:16:22 +03:00
client.py
CLOBBER
configure.in Backed out changeset e34634758f51 (bug 1671424) for bustages on configure.py . CLOSED TREE 2020-10-20 00:16:22 +03:00
configure.py Backed out changeset e34634758f51 (bug 1671424) for bustages on configure.py . CLOSED TREE 2020-10-20 00:16:22 +03:00
GNUmakefile
gradle.properties Bug 1553459 - Migrate to AndroidX r=geckoview-reviewers,agi 2020-09-18 22:29:04 +00:00
gradlew
gradlew.bat
LICENSE
mach Bug 1669874 - Use command -v instead of which in mach. r=firefox-build-system-reviewers,andi,rstewart 2020-10-08 14:58:43 +00:00
Makefile.in Bug 1670357 - Remove make targets for cleaning: clean, realclean, clobber, distclean, clobber_all, everything r=firefox-build-system-reviewers,mhentges 2020-10-15 20:37:18 +00:00
moz.build Bug 1669590 - Remove the "LEGAL" file from the tree r=mhoye DONTBUILD 2020-10-09 08:06:02 +00:00
moz.configure Bug 1670156 - Use the same prefix/suffix for rust libraries on mingw builds. r=firefox-build-system-reviewers,dmajor 2020-10-16 16:06:19 +00:00
mozilla-config.h.in
old-configure.in Bug 1670738 - Try to make autoconf deduce ac_exeext for mingw r=glandium 2020-10-16 13:14:31 +00:00
package-lock.json Bug 1668274 - update eslint, eslint-plugin-no-unsanitized and mocha to allow use of logical assignment operators, r=Standard8 2020-10-02 18:00:40 +00:00
package.json Bug 1668274 - update eslint, eslint-plugin-no-unsanitized and mocha to allow use of logical assignment operators, r=Standard8 2020-10-02 18:00:40 +00:00
README.txt
settings.gradle
substitute-local-geckoview.gradle
test.mozbuild

An explanation of the Firefox Source Code Directory Structure and links to
project pages with documentation can be found at:

    https://firefox-source-docs.mozilla.org/contributing/directory_structure.html

For information on how to build Firefox from the source code and create the patch see:

    https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html

If you have a question about developing Firefox, and can't find the solution
on https://firefox-source-docs.mozilla.org/, you can try asking your question on Matrix at chat.mozilla.org in `Introduction` (https://chat.mozilla.org/#/room/#introduction:mozilla.org) channel.


Nightly development builds can be downloaded from:

    https://archive.mozilla.org/pub/firefox/nightly/latest-mozilla-central/
            - or -
    https://www.mozilla.org/firefox/channel/desktop/#nightly

Keep in mind that nightly builds, which are used by Firefox developers for
testing, may be buggy.