gecko-dev/browser/installer
Adam Gashlin 6b6c4da4b5 Bug 1696772 - Don't use FILE_FLAG_DELETE_ON_CLOSE for multi-instance locks. r=nalexander,application-update-reviewers.
FILE_FLAG_DELETE_ON_CLOSE had the wrong semantics, rendering the lock
file unusable after it had been closed once.

Delete the lock file in the uninstaller as a simple alternative (given that
the lock file is not in a temporary location on Windows).

For a test I returned to the older form of
test_backgroundtask_update_sync_manager which initially exposed the issue:
It expects the background task to be able to detect the xpcshell instance
after running resetLock, which failed before this fix.
I also extended the original updateSyncManager test to run the second
copy twice, which also catches the issue.

Differential Revision: https://phabricator.services.mozilla.com/D109565
2021-03-24 20:36:06 +00:00
..
windows Bug 1696772 - Don't use FILE_FLAG_DELETE_ON_CLOSE for multi-instance locks. r=nalexander,application-update-reviewers. 2021-03-24 20:36:06 +00:00
allowed-dupes.mn Bug 1699858 - Avoid using the toolkit/global icons which are about to change for proton. r=nchevobbe,jdescottes 2021-03-24 19:06:27 +00:00
Makefile.in Bug 1667276 - Part 3: Load a custom prefs file when running a background task. r=mossop,KrisWright 2021-01-27 22:54:25 +00:00
package-manifest.in Bug 1667276 - Part 3: Load a custom prefs file when running a background task. r=mossop,KrisWright 2021-01-27 22:54:25 +00:00
removed-files.in