mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-17 07:15:46 +00:00
0d4a611a04
MozReview-Commit-ID: AXrQEjWzxvg --HG-- extra : rebase_source : bf972fbb22648af2edbb756eb899ebddf8444dbc
30 lines
1.2 KiB
C++
30 lines
1.2 KiB
C++
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#include "TrivialCtorDtorChecker.h"
|
|
#include "CustomMatchers.h"
|
|
|
|
void TrivialCtorDtorChecker::registerMatchers(MatchFinder *AstMatcher) {
|
|
AstMatcher->addMatcher(cxxRecordDecl(hasTrivialCtorDtor()).bind("node"),
|
|
this);
|
|
}
|
|
|
|
void TrivialCtorDtorChecker::check(const MatchFinder::MatchResult &Result) {
|
|
const char *Error = "class %0 must have trivial constructors and destructors";
|
|
const CXXRecordDecl *Node = Result.Nodes.getNodeAs<CXXRecordDecl>("node");
|
|
|
|
if (!Node->hasDefinition()) {
|
|
return;
|
|
}
|
|
|
|
// We need to accept non-constexpr trivial constructors as well. This occurs
|
|
// when a struct contains pod members, which will not be initialized. As
|
|
// constexpr values are initialized, the constructor is non-constexpr.
|
|
bool BadCtor = !(Node->hasConstexprDefaultConstructor() ||
|
|
Node->hasTrivialDefaultConstructor());
|
|
bool BadDtor = !Node->hasTrivialDestructor();
|
|
if (BadCtor || BadDtor)
|
|
diag(Node->getLocStart(), Error, DiagnosticIDs::Error) << Node;
|
|
}
|