mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-27 12:15:33 +00:00
70c61fbb90
In the current setup, we'll end up GCing once when destroying the SafeJSContext, and then once again immediately after in the explicit GC we do before destroying the XPCJSRuntime. It would be nice to avoid the first GC entirely, but we currently need both to avoid leaking. All in all, these patches cause us to GC three times during shutdown, rather than twice as we did before, because the second GC was rolled together with the runtime destruction GC when we destroyed the last JSContext. There are a number of ways to eliminate these, at least in opt builds, but mccr8 thinks it probably doesn't matter, since there shouldn't be much left in the heap after the second GC. We can probably get away with eliminating rambo GC entirely at some point. But this might become irrelevant for the browser if we end up doing bug 662444. It would also be interesting to see what, if anything, the rambo GC actually collects. We might even be able to get away with asserting that all the zones are gone and removing the GC entirely. We also take the opportunity to kill mOwnSafeJSContext, which no longer holds any meaning. |
||
|---|---|---|
| .. | ||
| crashtests | ||
| idl | ||
| loader | ||
| public | ||
| shell | ||
| src | ||
| tests | ||
| wrappers | ||
| moz.build | ||