gecko-dev/xpcom/components/nsServiceManagerUtils.h
Kris Maglione 7aa3564a28 Bug 1477579: Part 3 - Avoid duplicating static strings in category manager entries. r=froydnj
Much like the component manager, many of the strings that we use for category
manager entries are statically allocated. There's no need to duplicate these
strings.

This patch changes the category manager APIs to take nsACStrings rather than
raw pointers, and to pass literal nsCStrings when we know we have a literal
string to begin with. When adding the category entry, it then skips making
copies of any strings with the LITERAL flag.

MozReview-Commit-ID: EJEcYSdNMWs
***
amend-catman

--HG--
extra : source : aa9a8f18e98f930a3d8359565eef02f3f6efc5f9
extra : absorb_source : 81a22ab26ee8017ac43321ff2c987d8096182d37
2018-07-23 17:41:06 -07:00

96 lines
2.7 KiB
C++

/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#ifndef nsServiceManagerUtils_h__
#define nsServiceManagerUtils_h__
#include "nsIServiceManager.h"
#include "nsCOMPtr.h"
#include "nsString.h"
inline const nsGetServiceByCID
do_GetService(const nsCID& aCID)
{
return nsGetServiceByCID(aCID);
}
inline const nsGetServiceByCIDWithError
do_GetService(const nsCID& aCID, nsresult* aError)
{
return nsGetServiceByCIDWithError(aCID, aError);
}
inline const nsGetServiceByContractID
do_GetService(const char* aContractID)
{
return nsGetServiceByContractID(aContractID);
}
inline const nsGetServiceByContractIDWithError
do_GetService(const char* aContractID, nsresult* aError)
{
return nsGetServiceByContractIDWithError(aContractID, aError);
}
class MOZ_STACK_CLASS nsGetServiceFromCategory final : public nsCOMPtr_helper
{
public:
nsGetServiceFromCategory(const nsACString& aCategory, const nsACString& aEntry,
nsresult* aErrorPtr)
: mCategory(aCategory)
, mEntry(aEntry)
, mErrorPtr(aErrorPtr)
{
}
virtual nsresult NS_FASTCALL operator()(const nsIID&, void**) const
override;
protected:
const nsCString mCategory;
const nsCString mEntry;
nsresult* mErrorPtr;
};
inline const nsGetServiceFromCategory
do_GetServiceFromCategory(const nsACString& aCategory, const nsACString& aEntry,
nsresult* aError = 0)
{
return nsGetServiceFromCategory(aCategory, aEntry, aError);
}
nsresult CallGetService(const nsCID& aClass, const nsIID& aIID, void** aResult);
nsresult CallGetService(const char* aContractID, const nsIID& aIID,
void** aResult);
// type-safe shortcuts for calling |GetService|
template<class DestinationType>
inline nsresult
CallGetService(const nsCID& aClass,
DestinationType** aDestination)
{
MOZ_ASSERT(aDestination, "null parameter");
return CallGetService(aClass,
NS_GET_TEMPLATE_IID(DestinationType),
reinterpret_cast<void**>(aDestination));
}
template<class DestinationType>
inline nsresult
CallGetService(const char* aContractID,
DestinationType** aDestination)
{
MOZ_ASSERT(aContractID, "null parameter");
MOZ_ASSERT(aDestination, "null parameter");
return CallGetService(aContractID,
NS_GET_TEMPLATE_IID(DestinationType),
reinterpret_cast<void**>(aDestination));
}
#endif