gecko-dev/xpcom
Nika Layzell 7ced96212e Bug 1778211 - Reject xpidl CDATA containing 'virtual', r=xpcom-reviewers,necko-reviewers,mccr8,dragana
We'll probably want to do something more accurate in the future with a
custom clang static analysis pass which validates that XPIDL interfaces
have the expected vtable and struct layout, however doing so would be
more involved than the string matching done in this patch.

In addition to checking for extra virtual methods, we'll likely also
want to check for data members on interfaces, and reject them unless the
class is marked as `[builtinclass]` in addition to some other attribute
which we'll need to add to prevent them from being implemented in Rust
(as c++ data members will not be reflected by the rust macro).

There were 2 instances of a comment which contained the word 'virtual'
within a CDATA block. These comments were moved out of the CDATA block
to avoid triggering the error.

Differential Revision: https://phabricator.services.mozilla.com/D151068
2022-07-06 14:53:06 +00:00
..
base Bug 1778211 - Reject xpidl CDATA containing 'virtual', r=xpcom-reviewers,necko-reviewers,mccr8,dragana 2022-07-06 14:53:06 +00:00
build Bug 1773770: Part 12 - Remove XPCOM Module infrastructure. r=xpcom-reviewers,nika 2022-06-30 09:12:19 +00:00
components Bug 1773770: Part 12 - Remove XPCOM Module infrastructure. r=xpcom-reviewers,nika 2022-06-30 09:12:19 +00:00
docs Bug 1776103 - Clean up DMD docs. r=xpcom-reviewers,nika DONTBUILD 2022-06-29 21:41:04 +00:00
ds Bug 1778211 - Reject xpidl CDATA containing 'virtual', r=xpcom-reviewers,necko-reviewers,mccr8,dragana 2022-07-06 14:53:06 +00:00
geckoprocesstypes_generator Bug 1751948 - Part 6: Add basic support for running IPDL unit tests during gtest, r=ipc-reviewers,andi,handyman 2022-02-28 21:01:49 +00:00
glue Bug 1774864 - Cleanup xpcom/ includes r=sylvestre 2022-06-24 07:13:59 +00:00
idl-parser Bug 1778211 - Reject xpidl CDATA containing 'virtual', r=xpcom-reviewers,necko-reviewers,mccr8,dragana 2022-07-06 14:53:06 +00:00
io Bug 1774864 - Cleanup xpcom/ includes r=sylvestre 2022-06-24 07:13:59 +00:00
libxpt/xptcall
reflect Bug 1778211 - Reject xpidl CDATA containing 'virtual', r=xpcom-reviewers,necko-reviewers,mccr8,dragana 2022-07-06 14:53:06 +00:00
rust Bug 1774501 - Update to env_logger 0.9 in various in-tree crates. r=nbp,keeler,xpcom-reviewers,rhunt,nika 2022-06-16 20:44:03 +00:00
string Bug 1773604 - Move definition of kNotFound to nsStringFwd.h, r=xpcom-reviewers,barret 2022-06-28 01:35:11 +00:00
system Bug 1770098 - Disable Win32k Lockdown with incompatible mitigations r=handyman,Gankra 2022-06-16 14:05:00 +00:00
tests Bug 1773770: Part 11 - Migrate TestRacingServiceManager to register factories directly. r=xpcom-reviewers,nika 2022-06-30 09:12:19 +00:00
threads Bug 1778211 - Reject xpidl CDATA containing 'virtual', r=xpcom-reviewers,necko-reviewers,mccr8,dragana 2022-07-06 14:53:06 +00:00
windbgdlg Bug 1747756 - Move Windows system libraries from LIBS to moz.build. r=firefox-build-system-reviewers,mhentges 2021-12-30 20:56:43 +00:00
xpidl
moz.build Bug 1726804 - Refactor definition and usage of GECKO_PROCESS_TYPE() r=nika,firefox-build-system-reviewers,mhentges 2021-11-19 14:02:55 +00:00
xpcom-config.h.in