mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-19 16:25:38 +00:00
abd52a84b9
The "generate-build-stats" mozharness action collects a bunch of build system metrics, including build_resources.json, ctors count, and installer size and reports them by writing special messages that log parsers read. Before this commit, this mozharness action occurred sometime after "build." But relative ordering to other actions was not consistent and appears to be significantly cargo culted. 4e61e69a383c (bug 1304508) changed the "check" mozharness action to invoke `mach build check` instead of `make` directly. An unintended consequence of this is that `mach build` replaced the build_resources.json file from the build itself with one measuring `make check`. This made the "build time summary" metric take a nose dive. This commit works around the issue introduced by 4e61e69a383c by reordering the mozharness actions so "generate-build-stats" follows immediately after the "build" action. Not only does it now occur before the "check" action, but it also occurs before uploading and other actions. I'm not sure why "generate-build-stats" is its own action and not part of "build" itself. As the diff shows, numerous instances of "generate-build-stats" are commented out, which means we aren't collecting metrics. "generate-build-stats" is also missing from a handful of mozharness configs, including Windows Clang builds. I'm not sure what the history is (it is likely varied and almost certainly involves a fair amount of cargo culting), but I think it is a bug that we aren't collecting build metrics for every build. I would like to fix this. And moving "generate-build-stats" immediately after "build" should make that transition easier. MozReview-Commit-ID: 7jNTVWRvMnh --HG-- extra : rebase_source : 0b5fd1f462caa5c283ba7e1b693fdc5b8b948add |
||
|---|---|---|
| .. | ||
| firefox_ui_tests | ||
| merge_day | ||
| release | ||
| spidermonkey | ||
| android_emulator_unittest.py | ||
| awsy_script.py | ||
| bouncer_submitter.py | ||
| configtest.py | ||
| desktop_l10n.py | ||
| desktop_partner_repacks.py | ||
| desktop_unittest.py | ||
| firefox_media_tests_buildbot.py | ||
| firefox_media_tests_jenkins.py | ||
| firefox_media_tests_taskcluster.py | ||
| fx_desktop_build.py | ||
| l10n_bumper.py | ||
| marionette.py | ||
| mobile_l10n.py | ||
| mobile_partner_repack.py | ||
| multil10n.py | ||
| openh264_build.py | ||
| repackage.py | ||
| spidermonkey_build.py | ||
| talos_script.py | ||
| web_platform_tests.py | ||