mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-11-05 16:46:26 +00:00
e7aa393b43
- add proper unique keys to users table - check for empty username and/or passwords - compare the entered password against the db version instead of itself <- !!! - check form submissions in JS prior to submission - require a unique IRC nickname if it is provided, but allow users not to enter one if they so choose - display mailto: links for admins only - display account created page when updating accounts - make login look-and-feel consistent with the rest of the site b=321265 - add getDisplayName function to User.pm -> returns IRC nickname, real name, or email depending on what is available. Used wherever user information is displayed. b=324022 - add scrollbars to testcase display (css -> overflow: auto) b=324648 - use quotemeta in Testresults.pm to avoid SQL injection when searching results Misc: - update copyrights to 2006 - fix log_text db schema regression - remove validity_lookup and vetting_status_lookup tables and assoicated perl classes. Replaced by per-test-result fields. - remove out-of-date formats/ directory and contents - add functions to DBTools.pm to manipulate keys and drop tables - display error/success/info messages in a transient popup div - update version to 0.6. Make version string part of sidebar title. - allow re-testing of completed subgroups by same tester, i.e. don't disable subgroups with 100% testing coverage - remove 'next' regression on run_tests testcase display - comment out user table on stats page - whitespace fixes
253 lines
8.6 KiB
Perl
Executable File
253 lines
8.6 KiB
Perl
Executable File
#!/usr/bin/perl -w
|
|
# -*- mode: cperl; c-basic-offset: 8; indent-tabs-mode: nil; -*-
|
|
|
|
# ***** BEGIN LICENSE BLOCK *****
|
|
# Version: MPL 1.1
|
|
#
|
|
# The contents of this file are subject to the Mozilla Public License Version
|
|
# 1.1 (the "License"); you may not use this file except in compliance with
|
|
# the License. You may obtain a copy of the License at
|
|
# http://www.mozilla.org/MPL/
|
|
#
|
|
# Software distributed under the License is distributed on an "AS IS" basis,
|
|
# WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License
|
|
# for the specific language governing rights and limitations under the
|
|
# License.
|
|
#
|
|
# The Original Code is Litmus.
|
|
#
|
|
# The Initial Developer of the Original Code is
|
|
# the Mozilla Corporation.
|
|
# Portions created by the Initial Developer are Copyright (C) 2006
|
|
# the Initial Developer. All Rights Reserved.
|
|
#
|
|
# Contributor(s):
|
|
# Chris Cooper <ccooper@deadsquid.com>
|
|
# Zach Lipton <zach@zachlipton.com>
|
|
#
|
|
# ***** END LICENSE BLOCK *****
|
|
|
|
use strict;
|
|
|
|
use Litmus;
|
|
use Litmus::Error;
|
|
use Litmus::DB::Product;
|
|
use Litmus::UserAgentDetect;
|
|
use Litmus::SysConfig;
|
|
use Litmus::Auth;
|
|
use Litmus::Utils;
|
|
use Litmus::DB::Resultbug;
|
|
|
|
use CGI;
|
|
use Date::Manip;
|
|
use diagnostics;
|
|
|
|
my $c = Litmus->cgi();
|
|
|
|
my $user;
|
|
my $sysconfig;
|
|
if ($c->param("isSysConfig")) {
|
|
$sysconfig = Litmus::SysConfig->processForm($c);
|
|
my $email = $c->param("email");
|
|
$user = Litmus::DB::User->find_or_create(email => $email);
|
|
print $c->header(-cookie => [$sysconfig->setCookie(), Litmus::Auth::setCookie($user)]);
|
|
} else {
|
|
print $c->header();
|
|
}
|
|
|
|
my @names = $c->param();
|
|
|
|
# find all the test numbers contained in this result submission
|
|
my @tests;
|
|
foreach my $curname (@names) {
|
|
if ($curname =~ /testresult_(\d*)/) {
|
|
push(@tests, $1);
|
|
}
|
|
}
|
|
|
|
# don't get to use the simple test interface if you really
|
|
# have more than one test (i.e. you cheated and changed the
|
|
# hidden input)
|
|
if (scalar @tests > 1 && $c->param("isSimpleTest")) {
|
|
invalidInputError("Cannot use simpletest interface with more than one test");
|
|
}
|
|
|
|
my $testcount;
|
|
my %resultcounts;
|
|
my $product;
|
|
foreach my $curtestid (@tests) {
|
|
unless ($c->param("testresult_".$curtestid)) {
|
|
# user didn't submit a result for this test so just skip
|
|
# it and move on...
|
|
next;
|
|
}
|
|
|
|
my $curtest = Litmus::DB::Test->retrieve($curtestid);
|
|
unless ($curtest) {
|
|
# oddly enough, the test doesn't exist
|
|
next;
|
|
}
|
|
|
|
$testcount++;
|
|
|
|
$product = $curtest->product();
|
|
|
|
my $ua = Litmus::UserAgentDetect->new();
|
|
# for simpletest, build a temporary sysconfig based on the
|
|
# UA string and product of this test:
|
|
if ($c->param("isSimpleTest")) {
|
|
$sysconfig = Litmus::SysConfig->new(
|
|
$curtest->product(),
|
|
$ua->platform($curtest->product()),
|
|
"NULL", # no way to autodetect the opsys
|
|
$ua->branch($curtest->product()),
|
|
$ua->buildid(),
|
|
);
|
|
}
|
|
|
|
# get system configuration. If there is no configuration and we're
|
|
# not doing the simpletest interface, then we make you enter it
|
|
# Get system configuration. If there is no configuration,
|
|
# then we make the user enter it.
|
|
if (!$sysconfig) {
|
|
$sysconfig = Litmus::SysConfig->getCookie($product);
|
|
}
|
|
|
|
# Users who still don't have a sysconfig for this product
|
|
# should go configure themselves first.
|
|
if (!$sysconfig) {
|
|
Litmus::SysConfig->displayForm($product,
|
|
"process_test_results.cgi",
|
|
$c);
|
|
exit;
|
|
}
|
|
|
|
my $result = Litmus::DB::Result->retrieve($c->param("testresult_".$curtestid));
|
|
$resultcounts{$result->name()}++;
|
|
|
|
my $note = $c->param("comment_".$curtestid);
|
|
my $bugs = $c->param("bugs_".$curtestid);
|
|
|
|
my $time = &Date::Manip::UnixDate("now","%q");
|
|
|
|
# normally, the user comes with a cookie, but for simpletest
|
|
# users, we just use the web-user@mozilla.org user:
|
|
|
|
if ($c->param("isSimpleTest")) {
|
|
$user = $user || Litmus::DB::User->search(email => 'web-tester@mozilla.org')->next();
|
|
} else {
|
|
$user = $user || Litmus::Auth::getCookie()->userid();
|
|
}
|
|
|
|
my $tr = Litmus::DB::Testresult->create({
|
|
user => $user,
|
|
testid => $curtest,
|
|
timestamp => $time,
|
|
last_updated => $time,
|
|
useragent => $ua,
|
|
result => $result,
|
|
platform => $sysconfig->platform(),
|
|
opsys => $sysconfig->opsys(),
|
|
branch => $sysconfig->branch(),
|
|
buildid => $sysconfig->buildid(),
|
|
locale_abbrev => $sysconfig->locale(),
|
|
});
|
|
|
|
# if there's a note, create an entry in the comments table for it
|
|
if ($note and
|
|
$note ne '') {
|
|
Litmus::DB::Comment->create({
|
|
testresult => $tr,
|
|
submission_time => $time,
|
|
last_updated => $time,
|
|
user => $user,
|
|
comment => $note
|
|
});
|
|
}
|
|
|
|
if ($bugs and
|
|
$bugs ne '') {
|
|
$bugs =~ s/[^0-9,]//g;
|
|
my @new_bugs = split(/,/,$bugs);
|
|
foreach my $new_bug (@new_bugs) {
|
|
next if ($new_bug eq '0');
|
|
my $bug = Litmus::DB::Resultbug->create({
|
|
testresult => $tr,
|
|
last_updated => $time,
|
|
submission_time => $time,
|
|
user => $user,
|
|
bug_id => $new_bug,
|
|
});
|
|
}
|
|
}
|
|
|
|
}
|
|
|
|
# process changes to testcases:
|
|
my @changed;
|
|
if ($c->param("editingTestcases") &&
|
|
Litmus::Auth::canEdit(Litmus::Auth::getCookie())) {
|
|
# only users with canedit can edit testcases, duh!
|
|
|
|
# the editingTestcases param contains a comma-separated list of
|
|
# testids that the user has made changes to (well, has clicked
|
|
# the edit button for).
|
|
@changed = split(',' => $c->param("editingTestcases"));
|
|
foreach my $editid (@changed) {
|
|
my $edittest = Litmus::DB::Test->retrieve($editid);
|
|
if (! $edittest) {invalidInputError("Test $editid does not exist")}
|
|
|
|
$edittest->summary($c->param("summary_edit_$editid"));
|
|
if ($c->param("communityenabled_$editid")) {
|
|
$edittest->communityenabled(1);
|
|
} else {
|
|
$edittest->communityenabled(0);
|
|
}
|
|
my $product = Litmus::DB::Product->retrieve($c->param("product_$editid"));
|
|
my $group = Litmus::DB::Testgroup->retrieve($c->param("testgroup_$editid"));
|
|
my $subgroup = Litmus::DB::Subgroup->retrieve($c->param("subgroup_$editid"));
|
|
requireField("product", $product);
|
|
requireField("group", $group);
|
|
requireField("subgroup", $subgroup);
|
|
$edittest->product($product);
|
|
$edittest->testgroup($group);
|
|
$edittest->subgroup($subgroup);
|
|
|
|
$edittest->steps($c->param("steps_edit_$editid"));
|
|
$edittest->expected_results($c->param("results_edit_$editid"));
|
|
|
|
$edittest->update();
|
|
}
|
|
} elsif ($c->param("editingTestcases") &&
|
|
! Litmus::Auth::canEdit(Litmus::Auth::getCookie())) {
|
|
invalidInputError("You do not have permissions to edit testcases. ");
|
|
}
|
|
|
|
my $testgroup;
|
|
if ($c->param("testgroup")) {
|
|
$testgroup = Litmus::DB::Testgroup->retrieve($c->param("testgroup")),
|
|
}
|
|
|
|
my $vars;
|
|
$vars->{'title'} = 'Run Tests';
|
|
|
|
my $cookie = Litmus::Auth::getCookie();
|
|
$vars->{"defaultemail"} = $cookie;
|
|
$vars->{"show_admin"} = Litmus::Auth::istrusted($cookie);
|
|
|
|
# show the normal thank you page unless we're in simpletest mode where
|
|
# we should show a special page:
|
|
if ($c->param("isSimpleTest")) {
|
|
Litmus->template()->process("simpletest/resultssubmitted.html.tmpl", $vars) || internalError(Litmus->template()->error());
|
|
} else {
|
|
$vars->{'testcount'} = $testcount;
|
|
$vars->{'product'} = $product || undef;
|
|
$vars->{'resultcounts'} = \%resultcounts || undef;
|
|
$vars->{'changedlist'} = \@changed || undef;
|
|
$vars->{'testgroup'} = $testgroup || undef;
|
|
$vars->{'return'} = $c->param("return") || undef;
|
|
|
|
Litmus->template()->process("process/process.html.tmpl", $vars) ||
|
|
internalError(Litmus->template()->error());
|
|
}
|