mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-03-02 22:37:50 +00:00
886c2c65a8
Currently, the gamepad code uses a uint32_t as a handle and does some trickery with it by trying to create a unique ID and adding an offset to it for VR code. This can (and has) led to errors where the developer forgets to perform the arithmetic and sends the wrong number to the wrong manager. This change created a strongly-typed handle that remembers which service it belongs to. This should eliminate such accidents. Differential Revision: https://phabricator.services.mozilla.com/D96273
35 lines
1.2 KiB
C++
35 lines
1.2 KiB
C++
/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
|
|
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this file,
|
|
* You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#include "GamepadTestChannelChild.h"
|
|
|
|
#include "mozilla/dom/GamepadServiceTest.h"
|
|
|
|
namespace mozilla::dom {
|
|
|
|
already_AddRefed<GamepadTestChannelChild> GamepadTestChannelChild::Create(
|
|
GamepadServiceTest* aGamepadServiceTest) {
|
|
return RefPtr<GamepadTestChannelChild>(
|
|
new GamepadTestChannelChild(aGamepadServiceTest))
|
|
.forget();
|
|
}
|
|
|
|
GamepadTestChannelChild::GamepadTestChannelChild(
|
|
GamepadServiceTest* aGamepadServiceTest)
|
|
: mGamepadServiceTest(aGamepadServiceTest) {}
|
|
|
|
mozilla::ipc::IPCResult GamepadTestChannelChild::RecvReplyGamepadHandle(
|
|
const uint32_t& aID, const GamepadHandle& aHandle) {
|
|
MOZ_RELEASE_ASSERT(
|
|
mGamepadServiceTest,
|
|
"Test channel should never outlive the owning GamepadServiceTest");
|
|
|
|
mGamepadServiceTest->ReplyGamepadHandle(aID, aHandle);
|
|
return IPC_OK();
|
|
}
|
|
|
|
} // namespace mozilla::dom
|