mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-11-23 21:01:08 +00:00
f03fb58873
In the previous implementation, FetchEvent.preloadResponse is resolved when the response fetching finishes. However, ServiceWorker responding letency could be increased since waiting for preloadResponse finishes. The patch resolves FetchEvent.preloadResponse earlier when the response is available. The basic idea is to resolve the preload response when FetchInstance::OnResponseAvailableInternal() is called. Then propagating the response from the parent process main thread to the content process worker thread. This is achieved by IPC PFetchEventOp::Send/RecvPreloadResponse -> PFetchEventOpProxy::Send/RecvPreloadResponse. Since we can only get the response's ResourceTiming when FetchInstance::OnResponseEnd() is called. This patch introduces a new IPC method to propagate the ResourceTiming information from the parent process main thread to the content process worker thread. PFetchEventOp::Send/RecvPreloadResponseEnd -> PFetchEventOpProxy->Send/RecvPreloadResponseEnd. The tricky of this patch is we must extend the life cycle of FetchEventOp object if preloadResponse is set into FetchEvent. That because ServiceWorker could resolve FetchEvent.respondWith() by using FetchEvent.preloadResponse. In that case, FetchEventOp will get into a finish state and try to call FetchEventOpProxyChild::Senddelete with the operation result. However, the ResponseEnd could not be called at the moment, and we need to wait for the corresponding timing information and its end reason. To extend the life cycle of FetchEventOp, this patch cached the operation result while we get FetchEventOp::Callback is called. Then call FetchEventOpProxyChile::Senddelete() in FetchEventOpProxyChild::RecvPreloadResponseEnd() to close IPC. Or Senddelete() will be called while ActorDestroy() caused by shutdown. Differential Revision: https://phabricator.services.mozilla.com/D145338
196 lines
6.4 KiB
C++
196 lines
6.4 KiB
C++
/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
|
|
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#ifndef mozilla_dom_serviceworkerop_h__
|
|
#define mozilla_dom_serviceworkerop_h__
|
|
|
|
#include <functional>
|
|
|
|
#include "mozilla/dom/ServiceWorkerOpPromise.h"
|
|
#include "nsISupportsImpl.h"
|
|
|
|
#include "ServiceWorkerEvents.h"
|
|
#include "ServiceWorkerOpPromise.h"
|
|
#include "mozilla/Attributes.h"
|
|
#include "mozilla/Maybe.h"
|
|
#include "mozilla/RefPtr.h"
|
|
#include "mozilla/TimeStamp.h"
|
|
#include "mozilla/dom/PromiseNativeHandler.h"
|
|
#include "mozilla/dom/RemoteWorkerChild.h"
|
|
#include "mozilla/dom/ServiceWorkerOpArgs.h"
|
|
#include "mozilla/dom/WorkerRunnable.h"
|
|
|
|
namespace mozilla::dom {
|
|
|
|
class FetchEventOpProxyChild;
|
|
|
|
class ServiceWorkerOp : public RemoteWorkerChild::Op {
|
|
public:
|
|
// `aCallback` will be called when the operation completes or is canceled.
|
|
static already_AddRefed<ServiceWorkerOp> Create(
|
|
ServiceWorkerOpArgs&& aArgs,
|
|
std::function<void(const ServiceWorkerOpResult&)>&& aCallback);
|
|
|
|
ServiceWorkerOp(
|
|
ServiceWorkerOpArgs&& aArgs,
|
|
std::function<void(const ServiceWorkerOpResult&)>&& aCallback);
|
|
|
|
ServiceWorkerOp(const ServiceWorkerOp&) = delete;
|
|
|
|
ServiceWorkerOp& operator=(const ServiceWorkerOp&) = delete;
|
|
|
|
ServiceWorkerOp(ServiceWorkerOp&&) = default;
|
|
|
|
ServiceWorkerOp& operator=(ServiceWorkerOp&&) = default;
|
|
|
|
// Returns `true` if the operation has started and `false` otherwise.
|
|
bool MaybeStart(RemoteWorkerChild* aOwner,
|
|
RemoteWorkerChild::State& aState) final;
|
|
|
|
void Cancel() final;
|
|
|
|
protected:
|
|
~ServiceWorkerOp();
|
|
|
|
bool Started() const;
|
|
|
|
bool IsTerminationOp() const;
|
|
|
|
// Override to provide a runnable that's not a `ServiceWorkerOpRunnable.`
|
|
virtual RefPtr<WorkerRunnable> GetRunnable(WorkerPrivate* aWorkerPrivate);
|
|
|
|
// Overridden by ServiceWorkerOp subclasses, it should return true when
|
|
// the ServiceWorkerOp was executed successfully (and false if it did fail).
|
|
// Content throwing an exception during event dispatch is still considered
|
|
// success.
|
|
virtual bool Exec(JSContext* aCx, WorkerPrivate* aWorkerPrivate) = 0;
|
|
|
|
// Override to reject any additional MozPromises that subclasses may contain.
|
|
virtual void RejectAll(nsresult aStatus);
|
|
|
|
ServiceWorkerOpArgs mArgs;
|
|
|
|
// Subclasses must settle this promise when appropriate.
|
|
MozPromiseHolder<ServiceWorkerOpPromise> mPromiseHolder;
|
|
|
|
private:
|
|
class ServiceWorkerOpRunnable;
|
|
|
|
bool mStarted = false;
|
|
};
|
|
|
|
class ExtendableEventOp : public ServiceWorkerOp,
|
|
public ExtendableEventCallback {
|
|
using ServiceWorkerOp::ServiceWorkerOp;
|
|
|
|
protected:
|
|
~ExtendableEventOp() = default;
|
|
|
|
void FinishedWithResult(ExtendableEventResult aResult) override;
|
|
};
|
|
|
|
class FetchEventOp final : public ExtendableEventOp,
|
|
public PromiseNativeHandler {
|
|
using ExtendableEventOp::ExtendableEventOp;
|
|
|
|
public:
|
|
NS_DECL_THREADSAFE_ISUPPORTS
|
|
|
|
/**
|
|
* This must be called once and only once before the first call to
|
|
* `MaybeStart()`; `aActor` will be used for `AsyncLog()` and
|
|
* `ReportCanceled().`
|
|
*/
|
|
void SetActor(RefPtr<FetchEventOpProxyChild> aActor);
|
|
|
|
void RevokeActor(FetchEventOpProxyChild* aActor);
|
|
|
|
// This must be called at most once before the first call to `MaybeStart().`
|
|
RefPtr<FetchEventRespondWithPromise> GetRespondWithPromise();
|
|
|
|
// This must be called when `FetchEvent::RespondWith()` is called.
|
|
void RespondWithCalledAt(const nsCString& aRespondWithScriptSpec,
|
|
uint32_t aRespondWithLineNumber,
|
|
uint32_t aRespondWithColumnNumber);
|
|
|
|
void ReportCanceled(const nsCString& aPreventDefaultScriptSpec,
|
|
uint32_t aPreventDefaultLineNumber,
|
|
uint32_t aPreventDefaultColumnNumber);
|
|
|
|
private:
|
|
class AutoCancel;
|
|
|
|
~FetchEventOp();
|
|
|
|
bool Exec(JSContext* aCx, WorkerPrivate* aWorkerPrivate) override;
|
|
|
|
void RejectAll(nsresult aStatus) override;
|
|
|
|
void FinishedWithResult(ExtendableEventResult aResult) override;
|
|
|
|
/**
|
|
* `{Resolved,Reject}Callback()` are use to handle the
|
|
* `FetchEvent::RespondWith()` promise.
|
|
*/
|
|
void ResolvedCallback(JSContext* aCx, JS::Handle<JS::Value> aValue,
|
|
ErrorResult& aRv) override;
|
|
|
|
void RejectedCallback(JSContext* aCx, JS::Handle<JS::Value> aValue,
|
|
ErrorResult& aRv) override;
|
|
|
|
void MaybeFinished();
|
|
|
|
// Requires mRespondWithClosure to be non-empty.
|
|
void AsyncLog(const nsCString& aMessageName, nsTArray<nsString> aParams);
|
|
|
|
void AsyncLog(const nsCString& aScriptSpec, uint32_t aLineNumber,
|
|
uint32_t aColumnNumber, const nsCString& aMessageName,
|
|
nsTArray<nsString> aParams);
|
|
|
|
void GetRequestURL(nsAString& aOutRequestURL);
|
|
|
|
// A failure code means that the dispatch failed.
|
|
nsresult DispatchFetchEvent(JSContext* aCx, WorkerPrivate* aWorkerPrivate);
|
|
|
|
// Worker Launcher thread only. Used for `AsyncLog().`
|
|
RefPtr<FetchEventOpProxyChild> mActor;
|
|
|
|
/**
|
|
* Created on the Worker Launcher thread and settled on the worker thread.
|
|
* If this isn't settled before `mPromiseHolder` (which it should be),
|
|
* `FetchEventOpChild` will cancel the intercepted network request.
|
|
*/
|
|
MozPromiseHolder<FetchEventRespondWithPromise> mRespondWithPromiseHolder;
|
|
|
|
// Worker thread only.
|
|
Maybe<ExtendableEventResult> mResult;
|
|
bool mPostDispatchChecksDone = false;
|
|
|
|
// Worker thread only; set when `FetchEvent::RespondWith()` is called.
|
|
Maybe<FetchEventRespondWithClosure> mRespondWithClosure;
|
|
|
|
// Must be set to `nullptr` on the worker thread because `Promise`'s
|
|
// destructor must be called on the worker thread.
|
|
RefPtr<Promise> mHandled;
|
|
|
|
// Must be set to `nullptr` on the worker thread because `Promise`'s
|
|
// destructor must be called on the worker thread.
|
|
RefPtr<Promise> mPreloadResponse;
|
|
|
|
// Holds the callback that resolves mPreloadResponse.
|
|
MozPromiseRequestHolder<FetchEventPreloadResponseAvailablePromise>
|
|
mPreloadResponseAvailablePromiseRequestHolder;
|
|
MozPromiseRequestHolder<FetchEventPreloadResponseEndPromise>
|
|
mPreloadResponseEndPromiseRequestHolder;
|
|
|
|
TimeStamp mFetchHandlerStart;
|
|
TimeStamp mFetchHandlerFinish;
|
|
};
|
|
|
|
} // namespace mozilla::dom
|
|
|
|
#endif // mozilla_dom_serviceworkerop_h__
|