gecko-dev/gfx/ipc
Nicholas Nethercote 7974362afd Bug 1567329 - Append _AtStartup to once static pref getters. r=erahm
Currently it's completely unclear at use sites that the getters for `once`
static prefs return the pref value from startup, rather than the current pref
value. (Bugs have been caused by this.) This commit improves things by changing
the getter name to make it clear that the pref value obtained is from startup.

This required changing things within libpref so it distinguishes between the
"base id" (`foo_bar`) and the "full id" (`foo_bar` or
`foo_bar_DoNotUseDirectly` or `foo_bar_AtStartup` or
`foo_bar_AtStartup_DoNotUseDirectly`; the name used depends on the `mirror` and
`do_not_use_directly` values in the YAML definition.) The "full id" is used in
most places, while the "base id" is used for the `GetPrefName_*` and
`GetPrefDefault_*` functions.

(This is a nice demonstration of the benefits of the YAML file, BTW. Making
this change with the old code would have involved adding an entry to every
single pref in StaticPrefList.h.)

The patch also rejigs the comment at the top of StaticPrefList.yaml, to clarify
some things.

Differential Revision: https://phabricator.services.mozilla.com/D38604

--HG--
extra : moz-landing-system : lando
2019-07-22 02:10:14 +00:00
..
CompositorOptions.h Bug 1540581 - P6. Tidy some C++ declarations in gfx/. r=gerald,jrmuizel 2019-04-11 12:36:51 +00:00
CompositorSession.cpp Bug 1533296 - Make WebRender error as to Fallback to Compositor rendering during disabling WebRender on android r=nical 2019-06-19 16:14:56 +00:00
CompositorSession.h Bug 1533296 - Make WebRender error as to Fallback to Compositor rendering during disabling WebRender on android r=nical 2019-06-19 16:14:56 +00:00
CompositorWidgetVsyncObserver.cpp Bug 1510853 - Introduce VsyncId and VsyncEvent for identifying vsyncs without timestamp comparisons. r=jrmuizel 2018-12-07 23:27:28 +00:00
CompositorWidgetVsyncObserver.h Bug 1510853 - Introduce VsyncId and VsyncEvent for identifying vsyncs without timestamp comparisons. r=jrmuizel 2018-12-07 23:27:28 +00:00
CrossProcessPaint.cpp Bug 1562722 - Don't apply the background color to anything except the root document when using CrossProcessPaint. r=rhunt 2019-07-11 14:01:15 +00:00
CrossProcessPaint.h Bug 1562722 - Don't apply the background color to anything except the root document when using CrossProcessPaint. r=rhunt 2019-07-11 14:01:15 +00:00
D3DMessageUtils.cpp Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre 2019-01-18 10:16:18 +01:00
D3DMessageUtils.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
GfxMessageUtils.h Bug 1536021 - Gecko side changes. r=kvark 2019-05-10 22:13:31 +02:00
GPUChild.cpp Bug 1567329 - Append _AtStartup to once static pref getters. r=erahm 2019-07-22 02:10:14 +00:00
GPUChild.h Bug 1289211 - Rename InfallibleTArray to nsTArray in gfx/ipc/ r=kats 2019-07-10 03:29:05 +00:00
GPUParent.cpp Bug 1567329 - Append _AtStartup to once static pref getters. r=erahm 2019-07-22 02:10:14 +00:00
GPUParent.h Bug 1555891 - Merge PVideoDecoderManager into PRemoteDecoderManager. r=jya,jld 2019-06-11 02:01:34 +00:00
GPUProcessHost.cpp Bug 1567329 - Append _AtStartup to once static pref getters. r=erahm 2019-07-22 02:10:14 +00:00
GPUProcessHost.h Bug 1550422 - P2. add shared pref serializer/deserializer to GPU process. r=kmag 2019-05-26 02:33:12 +00:00
GPUProcessImpl.cpp Bug 1550422 - P2. add shared pref serializer/deserializer to GPU process. r=kmag 2019-05-26 02:33:12 +00:00
GPUProcessImpl.h Bug 1540581 - P6. Tidy some C++ declarations in gfx/. r=gerald,jrmuizel 2019-04-11 12:36:51 +00:00
GPUProcessListener.h Bug 1540581 - P6. Tidy some C++ declarations in gfx/. r=gerald,jrmuizel 2019-04-11 12:36:51 +00:00
GPUProcessManager.cpp Bug 1567329 - Append _AtStartup to once static pref getters. r=erahm 2019-07-22 02:10:14 +00:00
GPUProcessManager.h Bug 1533296 - Make WebRender error as to Fallback to Compositor rendering during disabling WebRender on android r=nical 2019-06-19 16:14:56 +00:00
GraphicsMessages.ipdlh Bug 1550422 - P23. Remove now unused gfxPrefs. r=jrmuizel 2019-05-26 14:31:53 +00:00
InProcessCompositorSession.cpp Bug 1533296 - Make WebRender error as to Fallback to Compositor rendering during disabling WebRender on android r=nical 2019-06-19 16:14:56 +00:00
InProcessCompositorSession.h Bug 1533296 - Make WebRender error as to Fallback to Compositor rendering during disabling WebRender on android r=nical 2019-06-19 16:14:56 +00:00
moz.build Bug 1490537 - init and shutdown Skia in the GPU process. r=mattwoodrow 2018-11-29 18:09:46 -05:00
PGPU.ipdl Bug 1555891 - Merge PVideoDecoderManager into PRemoteDecoderManager. r=jya,jld 2019-06-11 02:01:34 +00:00
PVsyncBridge.ipdl Bug 1510853 - Introduce VsyncId and VsyncEvent for identifying vsyncs without timestamp comparisons. r=jrmuizel 2018-12-07 23:27:28 +00:00
RemoteCompositorSession.cpp Bug 1533296 - Make WebRender error as to Fallback to Compositor rendering during disabling WebRender on android r=nical 2019-06-19 16:14:56 +00:00
RemoteCompositorSession.h Bug 1533296 - Make WebRender error as to Fallback to Compositor rendering during disabling WebRender on android r=nical 2019-06-19 16:14:56 +00:00
SharedDIB.cpp Backed out 15 changesets (bug 1479960, bug 1426526, bug 1534780, bug 1536697) for toolchain bustages on UniquePtrExtensions.h . CLOSED TREE 2019-06-28 22:42:00 +03:00
SharedDIB.h Bug 1547143 - Format the tree: Be prescriptive with the pointer style (left) r=Ehsan 2019-05-01 08:47:10 +00:00
SharedDIBSurface.cpp Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
SharedDIBSurface.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
SharedDIBWin.cpp Backed out 15 changesets (bug 1479960, bug 1426526, bug 1534780, bug 1536697) for toolchain bustages on UniquePtrExtensions.h . CLOSED TREE 2019-06-28 22:42:00 +03:00
SharedDIBWin.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
VsyncBridgeChild.cpp Bug 1540731 - Part 2: Move toplevel actors to override ActorDestroy, r=froydnj 2019-05-21 17:04:21 +00:00
VsyncBridgeChild.h Bug 1540731 - Part 2: Move toplevel actors to override ActorDestroy, r=froydnj 2019-05-21 17:04:21 +00:00
VsyncBridgeParent.cpp Bug 1540731 - Part 2: Move toplevel actors to override ActorDestroy, r=froydnj 2019-05-21 17:04:21 +00:00
VsyncBridgeParent.h Bug 1540731 - Part 2: Move toplevel actors to override ActorDestroy, r=froydnj 2019-05-21 17:04:21 +00:00
VsyncIOThreadHolder.cpp Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
VsyncIOThreadHolder.h No bug - clang-format -p gfx 2019-03-29 23:41:48 -07:00