gecko-dev/editor
Masayuki Nakano 806984a06a Bug 1417492 - HTMLEditRules::TryToJoinBlocks() should no do nothing when left list node and right list node are not descendant of each other r=m_kato
We hit assertion which were added by bug 1414713.  That tells us an ancient bug.

There is comment which claims that we should move all list items in the right
list node to left list node if the list nodes should be merged.  However, this
has never been done actually since 2002.  The code tried to move *some* list
items in the right list node to the list list node.  However, retrieving first
list item at an offset almost always failed because the offset variable has
never been initialized.

If we believe the comment, we should move all children of the right list node
to the left list node.  However, until we get a testcase to reach this case,
we should keep current behavior, i.e., do nothing, for unexpected regression.

MozReview-Commit-ID: 1r81q1m44oW

--HG--
extra : rebase_source : fc02520f76440d5900fec0517aa6bcd188e1a14f
2017-11-18 16:12:44 +09:00
..
composer Bug 1416622 - Tighten up libpref's process checking. r=glandium 2017-11-13 09:19:55 +11:00
libeditor Bug 1417492 - HTMLEditRules::TryToJoinBlocks() should no do nothing when left list node and right list node are not descendant of each other r=m_kato 2017-11-18 16:12:44 +09:00
reftests Bug 464450 - Get rid of the padded class and clean up related styling. r=mak 2017-11-07 14:15:19 +01:00
txmgr Bug 1413013 - Remove unused nsITransactionList. r=masayuki 2017-10-30 20:35:00 +00:00
txtsvc Bug 1415445 - part 3: nsIEditActionListener's WillCreateElement() and DidCreateElement() should take child node at insertion point or new node itself rather than the container node and offset in it r=m_kato 2017-11-08 18:16:46 +09:00
AsyncSpellCheckTestHelper.jsm
moz.build Bug 1417400 - Get rid of nsIContentFilter. r=masayuki 2017-11-16 13:36:10 +09:00
nsEditorCID.h
nsIDocumentStateListener.idl
nsIEditActionListener.idl Bug 1415445 - part 3: nsIEditActionListener's WillCreateElement() and DidCreateElement() should take child node at insertion point or new node itself rather than the container node and offset in it r=m_kato 2017-11-08 18:16:46 +09:00
nsIEditor.idl Bug 1407854 - Part 1: Remove nsIEditor.createNode(); r=masayuki 2017-10-12 17:13:55 -04:00
nsIEditorMailSupport.idl Bug 1060051 - Make editor related interfaces builtin classes if it's possible r=Ehsan,smaug 2017-08-04 13:57:56 +09:00
nsIEditorObserver.idl
nsIEditorSpellCheck.idl
nsIEditorStyleSheets.idl Bug 1060051 - Make editor related interfaces builtin classes if it's possible r=Ehsan,smaug 2017-08-04 13:57:56 +09:00
nsIEditorUtils.idl Bug 1060051 - Make editor related interfaces builtin classes if it's possible r=Ehsan,smaug 2017-08-04 13:57:56 +09:00
nsIHTMLAbsPosEditor.idl Bug 1060051 - Make editor related interfaces builtin classes if it's possible r=Ehsan,smaug 2017-08-04 13:57:56 +09:00
nsIHTMLEditor.idl Bug 1417400 - Get rid of nsIContentFilter. r=masayuki 2017-11-16 13:36:10 +09:00
nsIHTMLInlineTableEditor.idl Bug 1060051 - Make editor related interfaces builtin classes if it's possible r=Ehsan,smaug 2017-08-04 13:57:56 +09:00
nsIHTMLObjectResizer.idl Bug 1060051 - Make editor related interfaces builtin classes if it's possible r=Ehsan,smaug 2017-08-04 13:57:56 +09:00
nsIPlaintextEditor.idl Bug 1060051 - Make editor related interfaces builtin classes if it's possible r=Ehsan,smaug 2017-08-04 13:57:56 +09:00
nsITableEditor.idl Bug 1387317 - part1: Make AutoSelectionSetterAfterTableEdit use HTMLEditor instead of nsITableEditor r=m_kato 2017-08-08 10:57:19 +09:00
nsIURIRefObject.idl
nsPIEditorTransaction.idl