gecko-dev/layout/svg
Timothy Nikkel b89bb47353 Bug 1628988. Don't apply ImgDrawResult::NOT_READY in PaintMaskSurface. r=mstange
PaintMaskSurface shouldn't be applying ImgDrawResult::NOT_READY when we don't have a frame and the mask image hasn't been resolved. ImgDrawResult is only about drawing images, not about waiting for external resources to resolve or frames to get constructed. The only purpose of tracking ImgDrawResult's in painting code is to know which frames we need to invalidate because their rendering might change if we sync decode images during a Draw call. Applying NOT_READY here means we invalidate for every paint with the sync decode images flag (ie reftest paints), and it never changes from NOT_READY. This bites the reftest for this bug 1624532.

To fix it, instead of "overloading" the ImgDrawResult we return a bool to indicate the mask is missing or incomplete.

Differential Revision: https://phabricator.services.mozilla.com/D70595

--HG--
extra : moz-landing-system : lando
2020-04-13 20:08:05 +00:00
..
crashtests Bug 1623992 - Automated rewrite from chrome://global/skin/ to chrome://global/skin/global.css in markup r=marionette-reviewers,perftest-reviewers,mossop,whimboo,sparky 2020-04-03 22:23:23 +00:00
tests Bug 1620542 - Automatically fix ESLint errors in .eslintrc.js files. r=mossop 2020-03-07 10:09:44 +00:00
AutoReferenceChainGuard.h Bug 1625855 - Replace MOZ_MUST_USE with [[nodiscard]] in layout. r=TYLin 2020-04-08 01:59:36 +00:00
moz.build Backed out changeset 6550b62f1fe7 (bug 1555356) for causing reftest failures in SVG files. 2020-02-14 23:59:09 +02:00
nsCSSClipPathInstance.cpp Bug 1614510 - Split clip-path and shape-outside values. r=boris 2020-02-11 23:34:53 +00:00
nsCSSClipPathInstance.h Bug 1614510 - Split clip-path and shape-outside values. r=boris 2020-02-11 23:34:53 +00:00
nsCSSFilterInstance.cpp Bug 1618345 - Enforce proper color management by splitting gfx::Color into sRGBColor and DeviceColor types. r=jrmuizel 2020-03-09 14:16:17 +00:00
nsCSSFilterInstance.h Bug 1618345 - Enforce proper color management by splitting gfx::Color into sRGBColor and DeviceColor types. r=jrmuizel 2020-03-09 14:16:17 +00:00
nsFilterInstance.cpp Bug 1618345 - Enforce proper color management by splitting gfx::Color into sRGBColor and DeviceColor types. r=jrmuizel 2020-03-09 14:16:17 +00:00
nsFilterInstance.h
nsISVGSVGFrame.h
nsSVGAFrame.cpp Bug 1610387 - Remove nsAutoPtr usage from layout/. r=dbaron 2020-02-01 09:40:36 +00:00
nsSVGClipPathFrame.cpp Bug 1618345 - Enforce proper color management by splitting gfx::Color into sRGBColor and DeviceColor types. r=jrmuizel 2020-03-09 14:16:17 +00:00
nsSVGClipPathFrame.h
nsSVGContainerFrame.cpp Bug 1610387 - Remove nsAutoPtr usage from layout/. r=dbaron 2020-02-01 09:40:36 +00:00
nsSVGContainerFrame.h Bug 1610387 - Remove nsAutoPtr usage from layout/. r=dbaron 2020-02-01 09:40:36 +00:00
nsSVGDisplayableFrame.h
nsSVGFilterFrame.cpp
nsSVGFilterFrame.h
nsSVGFilterInstance.cpp
nsSVGFilterInstance.h
nsSVGFilterPaintCallback.h
nsSVGForeignObjectFrame.cpp Bug 1610387 - Remove nsAutoPtr usage from layout/. r=dbaron 2020-02-01 09:40:36 +00:00
nsSVGForeignObjectFrame.h Bug 1610387 - Remove nsAutoPtr usage from layout/. r=dbaron 2020-02-01 09:40:36 +00:00
nsSVGGenericContainerFrame.cpp
nsSVGGenericContainerFrame.h
nsSVGGFrame.cpp
nsSVGGFrame.h Bug 1610387 - Remove nsAutoPtr usage from layout/. r=dbaron 2020-02-01 09:40:36 +00:00
nsSVGGradientFrame.cpp Bug 1618345 - Enforce proper color management by splitting gfx::Color into sRGBColor and DeviceColor types. r=jrmuizel 2020-03-09 14:16:17 +00:00
nsSVGGradientFrame.h
nsSVGImageFrame.cpp Bug 1622332 - Convert style-blend #defines to an enum class. r=emilio 2020-03-14 21:24:11 +00:00
nsSVGImageFrame.h Backed out changeset 6550b62f1fe7 (bug 1555356) for causing reftest failures in SVG files. 2020-02-14 23:59:09 +02:00
nsSVGInnerSVGFrame.cpp
nsSVGInnerSVGFrame.h
nsSVGIntegrationUtils.cpp Bug 1628988. Don't apply ImgDrawResult::NOT_READY in PaintMaskSurface. r=mstange 2020-04-13 20:08:05 +00:00
nsSVGIntegrationUtils.h Bug 1628988. Don't apply ImgDrawResult::NOT_READY in PaintMaskSurface. r=mstange 2020-04-13 20:08:05 +00:00
nsSVGMarkerFrame.cpp
nsSVGMarkerFrame.h
nsSVGMaskFrame.cpp Bug 1618345 - Enforce proper color management by splitting gfx::Color into sRGBColor and DeviceColor types. r=jrmuizel 2020-03-09 14:16:17 +00:00
nsSVGMaskFrame.h
nsSVGOuterSVGFrame.cpp Bug 1613985 - Use MOZ_COUNTED_DEFAULT_CTOR_*/MOZ_COUNTED_DTOR_* macros. r=froydnj 2020-02-20 11:40:14 +00:00
nsSVGOuterSVGFrame.h Bug 1610387 - Remove nsAutoPtr usage from layout/. r=dbaron 2020-02-01 09:40:36 +00:00
nsSVGPaintServerFrame.h
nsSVGPatternFrame.cpp Bug 1618345 - Enforce proper color management by splitting gfx::Color into sRGBColor and DeviceColor types. r=jrmuizel 2020-03-09 14:16:17 +00:00
nsSVGPatternFrame.h Bug 1610387 - Remove nsAutoPtr usage from layout/. r=dbaron 2020-02-01 09:40:36 +00:00
nsSVGStopFrame.cpp
nsSVGSwitchFrame.cpp
nsSVGSymbolFrame.cpp
nsSVGSymbolFrame.h
nsSVGUseFrame.cpp
nsSVGUseFrame.h
nsSVGUtils.cpp Bug 1622332 - Convert style-blend #defines to an enum class. r=emilio 2020-03-14 21:24:11 +00:00
nsSVGUtils.h Bug 1617425 - Use cbindgen for SVG lengths. r=jwatt 2020-02-23 15:43:03 +00:00
nsSVGViewportFrame.cpp
nsSVGViewportFrame.h Bug 1610387 - Remove nsAutoPtr usage from layout/. r=dbaron 2020-02-01 09:40:36 +00:00
svg.css
SVGContextPaint.cpp Bug 1618345 - Enforce proper color management by splitting gfx::Color into sRGBColor and DeviceColor types. r=jrmuizel 2020-03-09 14:16:17 +00:00
SVGContextPaint.h Bug 1618345 - Enforce proper color management by splitting gfx::Color into sRGBColor and DeviceColor types. r=jrmuizel 2020-03-09 14:16:17 +00:00
SVGFEContainerFrame.cpp
SVGFEImageFrame.cpp
SVGFELeafFrame.cpp
SVGFEUnstyledLeafFrame.cpp
SVGGeometryFrame.cpp Bug 1618345 - Enforce proper color management by splitting gfx::Color into sRGBColor and DeviceColor types. r=jrmuizel 2020-03-09 14:16:17 +00:00
SVGGeometryFrame.h Backed out changeset 6550b62f1fe7 (bug 1555356) for causing reftest failures in SVG files. 2020-02-14 23:59:09 +02:00
SVGImageContext.cpp Bug 1617425 - Use cbindgen for SVG lengths. r=jwatt 2020-02-23 15:43:03 +00:00
SVGImageContext.h
SVGObserverUtils.cpp Bug 1613985 - Use MOZ_COUNTED_DEFAULT_CTOR_*/MOZ_COUNTED_DTOR_* macros. r=froydnj 2020-02-20 11:40:14 +00:00
SVGObserverUtils.h
SVGTextFrame.cpp Bug 1618345 - Enforce proper color management by splitting gfx::Color into sRGBColor and DeviceColor types. r=jrmuizel 2020-03-09 14:16:17 +00:00
SVGTextFrame.h Bug 1614165 part 1. Improve error messages for SVG text. r=emilio 2020-02-09 02:15:32 +00:00
SVGViewFrame.cpp