gecko-dev/js/xpconnect/loader/ScriptCacheActors.h
Jed Davis ee171b6406 Bug 1615155 - Don't generate default Recv__delete__ if there are args. r=nika
The default method implementations cause problems when trying to
override them with different types in a direct call class.

For the `Recv__delete__` case there's a simple solution: omit it if
there are any arguments, because it doesn't make much sense to specify
arguments and then completely ignore them, and the no-arg case isn't a
problem for overriding.

Differential Revision: https://phabricator.services.mozilla.com/D62977

--HG--
extra : moz-landing-system : lando
2020-02-18 20:46:21 +00:00

60 lines
1.4 KiB
C++

/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 2; -*- */
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#ifndef ScriptCache_h
#define ScriptCache_h
#include "mozilla/ScriptPreloader.h"
#include "mozilla/loader/PScriptCacheChild.h"
#include "mozilla/loader/PScriptCacheParent.h"
namespace mozilla {
namespace ipc {
class FileDescriptor;
}
namespace loader {
using mozilla::ipc::FileDescriptor;
using mozilla::ipc::IPCResult;
class ScriptCacheParent final : public PScriptCacheParent {
friend class PScriptCacheParent;
public:
explicit ScriptCacheParent(bool wantCacheData)
: mWantCacheData(wantCacheData) {}
protected:
IPCResult Recv__delete__(nsTArray<ScriptData>&& scripts);
virtual void ActorDestroy(ActorDestroyReason aWhy) override;
private:
bool mWantCacheData;
};
class ScriptCacheChild final : public PScriptCacheChild {
friend class mozilla::ScriptPreloader;
public:
ScriptCacheChild() = default;
void Init(const Maybe<FileDescriptor>& cacheFile, bool wantCacheData);
protected:
virtual void ActorDestroy(ActorDestroyReason aWhy) override;
void SendScriptsAndFinalize(ScriptPreloader::ScriptHash& scripts);
private:
bool mWantCacheData = false;
};
} // namespace loader
} // namespace mozilla
#endif // ScriptCache_h