mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-11-04 16:15:25 +00:00
34dcc7b852
This change avoids lots of false positives for Coverity's CHECKED_RETURN warning, caused by NS_WARN_IF's current use in both statement-style and expression-style. In the case where the code within the NS_WARN_IF has side-effects, I made the following change. > NS_WARN_IF(NS_FAILED(FunctionWithSideEffects())); > --> > Unused << NS_WARN_IF(NS_FAILED(FunctionWithSideEffects())); In the case where the code within the NS_WARN_IF lacks side-effects, I made the following change. > NS_WARN_IF(!condWithoutSideEffects); > --> > NS_WARNING_ASSERTION(condWithoutSideEffects, "msg"); This has two improvements. - The condition is not evaluated in non-debug builds. - The sense of the condition is inverted to the familiar "this condition should be true" sense used in assertions. A common variation on the side-effect-free case is the following. > nsresult rv = Fn(); > NS_WARN_IF_(NS_FAILED(rv)); > --> > DebugOnly<nsresult rv> = Fn(); > NS_WARNING_ASSERTION(NS_SUCCEEDED(rv), "Fn failed"); --HG-- extra : rebase_source : 58788245021096efa8372a9dc1d597a611d45611
456 lines
12 KiB
C++
456 lines
12 KiB
C++
/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
|
|
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#include "MultipartBlobImpl.h"
|
|
#include "jsfriendapi.h"
|
|
#include "mozilla/dom/BlobSet.h"
|
|
#include "mozilla/dom/FileBinding.h"
|
|
#include "mozilla/dom/UnionTypes.h"
|
|
#include "nsDOMClassInfoID.h"
|
|
#include "nsIMultiplexInputStream.h"
|
|
#include "nsStringStream.h"
|
|
#include "nsTArray.h"
|
|
#include "nsJSUtils.h"
|
|
#include "nsContentUtils.h"
|
|
#include "nsIScriptError.h"
|
|
#include "nsIXPConnect.h"
|
|
#include <algorithm>
|
|
|
|
using namespace mozilla;
|
|
using namespace mozilla::dom;
|
|
|
|
NS_IMPL_ISUPPORTS_INHERITED0(MultipartBlobImpl, BlobImpl)
|
|
|
|
/* static */ already_AddRefed<MultipartBlobImpl>
|
|
MultipartBlobImpl::Create(const nsTArray<RefPtr<BlobImpl>>& aBlobImpls,
|
|
const nsAString& aName,
|
|
const nsAString& aContentType,
|
|
ErrorResult& aRv)
|
|
{
|
|
RefPtr<MultipartBlobImpl> blobImpl =
|
|
new MultipartBlobImpl(aBlobImpls, aName, aContentType);
|
|
blobImpl->SetLengthAndModifiedDate(aRv);
|
|
if (NS_WARN_IF(aRv.Failed())) {
|
|
return nullptr;
|
|
}
|
|
|
|
return blobImpl.forget();
|
|
}
|
|
|
|
/* static */ already_AddRefed<MultipartBlobImpl>
|
|
MultipartBlobImpl::Create(const nsTArray<RefPtr<BlobImpl>>& aBlobImpls,
|
|
const nsAString& aContentType,
|
|
ErrorResult& aRv)
|
|
{
|
|
RefPtr<MultipartBlobImpl> blobImpl =
|
|
new MultipartBlobImpl(aBlobImpls, aContentType);
|
|
blobImpl->SetLengthAndModifiedDate(aRv);
|
|
if (NS_WARN_IF(aRv.Failed())) {
|
|
return nullptr;
|
|
}
|
|
|
|
return blobImpl.forget();
|
|
}
|
|
|
|
void
|
|
MultipartBlobImpl::GetInternalStream(nsIInputStream** aStream,
|
|
ErrorResult& aRv)
|
|
{
|
|
*aStream = nullptr;
|
|
|
|
nsCOMPtr<nsIMultiplexInputStream> stream =
|
|
do_CreateInstance("@mozilla.org/io/multiplex-input-stream;1");
|
|
if (NS_WARN_IF(!stream)) {
|
|
aRv.Throw(NS_ERROR_FAILURE);
|
|
return;
|
|
}
|
|
|
|
uint32_t i;
|
|
for (i = 0; i < mBlobImpls.Length(); i++) {
|
|
nsCOMPtr<nsIInputStream> scratchStream;
|
|
BlobImpl* blobImpl = mBlobImpls.ElementAt(i).get();
|
|
|
|
blobImpl->GetInternalStream(getter_AddRefs(scratchStream), aRv);
|
|
if (NS_WARN_IF(aRv.Failed())) {
|
|
return;
|
|
}
|
|
|
|
aRv = stream->AppendStream(scratchStream);
|
|
if (NS_WARN_IF(aRv.Failed())) {
|
|
return;
|
|
}
|
|
}
|
|
|
|
stream.forget(aStream);
|
|
}
|
|
|
|
already_AddRefed<BlobImpl>
|
|
MultipartBlobImpl::CreateSlice(uint64_t aStart, uint64_t aLength,
|
|
const nsAString& aContentType,
|
|
ErrorResult& aRv)
|
|
{
|
|
// If we clamped to nothing we create an empty blob
|
|
nsTArray<RefPtr<BlobImpl>> blobImpls;
|
|
|
|
uint64_t length = aLength;
|
|
uint64_t skipStart = aStart;
|
|
|
|
// Prune the list of blobs if we can
|
|
uint32_t i;
|
|
for (i = 0; length && skipStart && i < mBlobImpls.Length(); i++) {
|
|
BlobImpl* blobImpl = mBlobImpls[i].get();
|
|
|
|
uint64_t l = blobImpl->GetSize(aRv);
|
|
if (NS_WARN_IF(aRv.Failed())) {
|
|
return nullptr;
|
|
}
|
|
|
|
if (skipStart < l) {
|
|
uint64_t upperBound = std::min<uint64_t>(l - skipStart, length);
|
|
|
|
RefPtr<BlobImpl> firstBlobImpl =
|
|
blobImpl->CreateSlice(skipStart, upperBound,
|
|
aContentType, aRv);
|
|
if (NS_WARN_IF(aRv.Failed())) {
|
|
return nullptr;
|
|
}
|
|
|
|
// Avoid wrapping a single blob inside an MultipartBlobImpl
|
|
if (length == upperBound) {
|
|
return firstBlobImpl.forget();
|
|
}
|
|
|
|
blobImpls.AppendElement(firstBlobImpl);
|
|
length -= upperBound;
|
|
i++;
|
|
break;
|
|
}
|
|
skipStart -= l;
|
|
}
|
|
|
|
// Now append enough blobs until we're done
|
|
for (; length && i < mBlobImpls.Length(); i++) {
|
|
BlobImpl* blobImpl = mBlobImpls[i].get();
|
|
|
|
uint64_t l = blobImpl->GetSize(aRv);
|
|
if (NS_WARN_IF(aRv.Failed())) {
|
|
return nullptr;
|
|
}
|
|
|
|
if (length < l) {
|
|
RefPtr<BlobImpl> lastBlobImpl =
|
|
blobImpl->CreateSlice(0, length, aContentType, aRv);
|
|
if (NS_WARN_IF(aRv.Failed())) {
|
|
return nullptr;
|
|
}
|
|
|
|
blobImpls.AppendElement(lastBlobImpl);
|
|
} else {
|
|
blobImpls.AppendElement(blobImpl);
|
|
}
|
|
length -= std::min<uint64_t>(l, length);
|
|
}
|
|
|
|
// we can create our blob now
|
|
RefPtr<BlobImpl> impl = Create(blobImpls, aContentType, aRv);
|
|
if (NS_WARN_IF(aRv.Failed())) {
|
|
return nullptr;
|
|
}
|
|
|
|
return impl.forget();
|
|
}
|
|
|
|
void
|
|
MultipartBlobImpl::InitializeBlob(ErrorResult& aRv)
|
|
{
|
|
SetLengthAndModifiedDate(aRv);
|
|
NS_WARNING_ASSERTION(!aRv.Failed(), "SetLengthAndModifiedDate failed");
|
|
}
|
|
|
|
void
|
|
MultipartBlobImpl::InitializeBlob(JSContext* aCx,
|
|
const Sequence<Blob::BlobPart>& aData,
|
|
const nsAString& aContentType,
|
|
bool aNativeEOL,
|
|
ErrorResult& aRv)
|
|
{
|
|
mContentType = aContentType;
|
|
BlobSet blobSet;
|
|
|
|
for (uint32_t i = 0, len = aData.Length(); i < len; ++i) {
|
|
const Blob::BlobPart& data = aData[i];
|
|
|
|
if (data.IsBlob()) {
|
|
RefPtr<Blob> blob = data.GetAsBlob().get();
|
|
blobSet.AppendBlobImpl(blob->Impl());
|
|
}
|
|
|
|
else if (data.IsUSVString()) {
|
|
aRv = blobSet.AppendString(data.GetAsUSVString(), aNativeEOL, aCx);
|
|
if (aRv.Failed()) {
|
|
return;
|
|
}
|
|
}
|
|
|
|
else if (data.IsArrayBuffer()) {
|
|
const ArrayBuffer& buffer = data.GetAsArrayBuffer();
|
|
buffer.ComputeLengthAndData();
|
|
aRv = blobSet.AppendVoidPtr(buffer.Data(), buffer.Length());
|
|
if (aRv.Failed()) {
|
|
return;
|
|
}
|
|
}
|
|
|
|
else if (data.IsArrayBufferView()) {
|
|
const ArrayBufferView& buffer = data.GetAsArrayBufferView();
|
|
buffer.ComputeLengthAndData();
|
|
aRv = blobSet.AppendVoidPtr(buffer.Data(), buffer.Length());
|
|
if (aRv.Failed()) {
|
|
return;
|
|
}
|
|
}
|
|
|
|
else {
|
|
MOZ_CRASH("Impossible blob data type.");
|
|
}
|
|
}
|
|
|
|
|
|
mBlobImpls = blobSet.GetBlobImpls();
|
|
SetLengthAndModifiedDate(aRv);
|
|
NS_WARNING_ASSERTION(!aRv.Failed(), "SetLengthAndModifiedDate failed");
|
|
}
|
|
|
|
void
|
|
MultipartBlobImpl::SetLengthAndModifiedDate(ErrorResult& aRv)
|
|
{
|
|
MOZ_ASSERT(mLength == UINT64_MAX);
|
|
MOZ_ASSERT(mLastModificationDate == INT64_MAX);
|
|
|
|
uint64_t totalLength = 0;
|
|
int64_t lastModified = 0;
|
|
bool lastModifiedSet = false;
|
|
|
|
for (uint32_t index = 0, count = mBlobImpls.Length(); index < count; index++) {
|
|
RefPtr<BlobImpl>& blob = mBlobImpls[index];
|
|
|
|
#ifdef DEBUG
|
|
MOZ_ASSERT(!blob->IsSizeUnknown());
|
|
MOZ_ASSERT(!blob->IsDateUnknown());
|
|
#endif
|
|
|
|
uint64_t subBlobLength = blob->GetSize(aRv);
|
|
if (NS_WARN_IF(aRv.Failed())) {
|
|
return;
|
|
}
|
|
|
|
MOZ_ASSERT(UINT64_MAX - subBlobLength >= totalLength);
|
|
totalLength += subBlobLength;
|
|
|
|
if (blob->IsFile()) {
|
|
int64_t partLastModified = blob->GetLastModified(aRv);
|
|
if (NS_WARN_IF(aRv.Failed())) {
|
|
return;
|
|
}
|
|
|
|
if (lastModified < partLastModified) {
|
|
lastModified = partLastModified;
|
|
lastModifiedSet = true;
|
|
}
|
|
}
|
|
}
|
|
|
|
mLength = totalLength;
|
|
|
|
if (mIsFile) {
|
|
// We cannot use PR_Now() because bug 493756 and, for this reason:
|
|
// var x = new Date(); var f = new File(...);
|
|
// x.getTime() < f.dateModified.getTime()
|
|
// could fail.
|
|
mLastModificationDate =
|
|
lastModifiedSet ? lastModified * PR_USEC_PER_MSEC : JS_Now();
|
|
}
|
|
}
|
|
|
|
void
|
|
MultipartBlobImpl::GetMozFullPathInternal(nsAString& aFilename,
|
|
ErrorResult& aRv) const
|
|
{
|
|
if (!mIsFromNsIFile || mBlobImpls.Length() == 0) {
|
|
BlobImplBase::GetMozFullPathInternal(aFilename, aRv);
|
|
return;
|
|
}
|
|
|
|
BlobImpl* blobImpl = mBlobImpls.ElementAt(0).get();
|
|
if (!blobImpl) {
|
|
BlobImplBase::GetMozFullPathInternal(aFilename, aRv);
|
|
return;
|
|
}
|
|
|
|
blobImpl->GetMozFullPathInternal(aFilename, aRv);
|
|
}
|
|
|
|
nsresult
|
|
MultipartBlobImpl::SetMutable(bool aMutable)
|
|
{
|
|
nsresult rv;
|
|
|
|
// This looks a little sketchy since BlobImpl objects are supposed to be
|
|
// threadsafe. However, we try to enforce that all BlobImpl objects must be
|
|
// set to immutable *before* being passed to another thread, so this should
|
|
// be safe.
|
|
if (!aMutable && !mImmutable && !mBlobImpls.IsEmpty()) {
|
|
for (uint32_t index = 0, count = mBlobImpls.Length();
|
|
index < count;
|
|
index++) {
|
|
rv = mBlobImpls[index]->SetMutable(aMutable);
|
|
if (NS_WARN_IF(NS_FAILED(rv))) {
|
|
return rv;
|
|
}
|
|
}
|
|
}
|
|
|
|
rv = BlobImplBase::SetMutable(aMutable);
|
|
if (NS_WARN_IF(NS_FAILED(rv))) {
|
|
return rv;
|
|
}
|
|
|
|
MOZ_ASSERT_IF(!aMutable, mImmutable);
|
|
|
|
return NS_OK;
|
|
}
|
|
|
|
void
|
|
MultipartBlobImpl::InitializeChromeFile(Blob& aBlob,
|
|
const ChromeFilePropertyBag& aBag,
|
|
ErrorResult& aRv)
|
|
{
|
|
NS_ASSERTION(!mImmutable, "Something went wrong ...");
|
|
|
|
if (mImmutable) {
|
|
aRv.Throw(NS_ERROR_UNEXPECTED);
|
|
return;
|
|
}
|
|
|
|
MOZ_ASSERT(nsContentUtils::IsCallerChrome());
|
|
|
|
mName = aBag.mName;
|
|
mContentType = aBag.mType;
|
|
mIsFromNsIFile = true;
|
|
|
|
// XXXkhuey this is terrible
|
|
if (mContentType.IsEmpty()) {
|
|
aBlob.GetType(mContentType);
|
|
}
|
|
|
|
|
|
BlobSet blobSet;
|
|
blobSet.AppendBlobImpl(aBlob.Impl());
|
|
mBlobImpls = blobSet.GetBlobImpls();
|
|
|
|
SetLengthAndModifiedDate(aRv);
|
|
NS_WARNING_ASSERTION(!aRv.Failed(), "SetLengthAndModifiedDate failed");
|
|
}
|
|
|
|
void
|
|
MultipartBlobImpl::InitializeChromeFile(nsPIDOMWindowInner* aWindow,
|
|
nsIFile* aFile,
|
|
const ChromeFilePropertyBag& aBag,
|
|
bool aIsFromNsIFile,
|
|
ErrorResult& aRv)
|
|
{
|
|
NS_ASSERTION(!mImmutable, "Something went wrong ...");
|
|
if (mImmutable) {
|
|
aRv.Throw(NS_ERROR_UNEXPECTED);
|
|
return;
|
|
}
|
|
|
|
MOZ_ASSERT(nsContentUtils::IsCallerChrome());
|
|
|
|
mName = aBag.mName;
|
|
mContentType = aBag.mType;
|
|
mIsFromNsIFile = aIsFromNsIFile;
|
|
|
|
bool exists;
|
|
aRv = aFile->Exists(&exists);
|
|
if (NS_WARN_IF(aRv.Failed())) {
|
|
return;
|
|
}
|
|
|
|
if (!exists) {
|
|
aRv.Throw(NS_ERROR_FILE_NOT_FOUND);
|
|
return;
|
|
}
|
|
|
|
bool isDir;
|
|
aRv = aFile->IsDirectory(&isDir);
|
|
if (NS_WARN_IF(aRv.Failed())) {
|
|
return;
|
|
}
|
|
|
|
if (isDir) {
|
|
aRv.Throw(NS_ERROR_FILE_IS_DIRECTORY);
|
|
return;
|
|
}
|
|
|
|
if (mName.IsEmpty()) {
|
|
aFile->GetLeafName(mName);
|
|
}
|
|
|
|
RefPtr<File> blob = File::CreateFromFile(aWindow, aFile, aBag.mTemporary);
|
|
|
|
// Pre-cache size.
|
|
blob->GetSize(aRv);
|
|
if (NS_WARN_IF(aRv.Failed())) {
|
|
return;
|
|
}
|
|
|
|
// Pre-cache modified date.
|
|
blob->GetLastModified(aRv);
|
|
if (NS_WARN_IF(aRv.Failed())) {
|
|
return;
|
|
}
|
|
|
|
// XXXkhuey this is terrible
|
|
if (mContentType.IsEmpty()) {
|
|
blob->GetType(mContentType);
|
|
}
|
|
|
|
BlobSet blobSet;
|
|
blobSet.AppendBlobImpl(static_cast<File*>(blob.get())->Impl());
|
|
mBlobImpls = blobSet.GetBlobImpls();
|
|
|
|
SetLengthAndModifiedDate(aRv);
|
|
NS_WARNING_ASSERTION(!aRv.Failed(), "SetLengthAndModifiedDate failed");
|
|
}
|
|
|
|
void
|
|
MultipartBlobImpl::InitializeChromeFile(nsPIDOMWindowInner* aWindow,
|
|
const nsAString& aData,
|
|
const ChromeFilePropertyBag& aBag,
|
|
ErrorResult& aRv)
|
|
{
|
|
nsCOMPtr<nsIFile> file;
|
|
aRv = NS_NewLocalFile(aData, false, getter_AddRefs(file));
|
|
if (NS_WARN_IF(aRv.Failed())) {
|
|
return;
|
|
}
|
|
|
|
InitializeChromeFile(aWindow, file, aBag, false, aRv);
|
|
}
|
|
|
|
bool
|
|
MultipartBlobImpl::MayBeClonedToOtherThreads() const
|
|
{
|
|
for (uint32_t i = 0; i < mBlobImpls.Length(); ++i) {
|
|
if (!mBlobImpls[i]->MayBeClonedToOtherThreads()) {
|
|
return false;
|
|
}
|
|
}
|
|
|
|
return true;
|
|
}
|