gecko-dev/devtools/client/aboutdebugging-new
Julian Descottes 84e0af7fe4 Bug 1521752 - Create jest test for aboutdebugging-new Message component;r=ladybenko
Depends on D24146
Example of a try run with tests running:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cca3978c6e3eb042c59e62b25b1946219cf3d74a&selectedJob=235873038

Differential Revision: https://phabricator.services.mozilla.com/D24721

--HG--
rename : devtools/client/framework/test/jest/.eslintrc.js => devtools/client/aboutdebugging-new/test/jest/.eslintrc.js
rename : devtools/client/framework/test/jest/README.md => devtools/client/aboutdebugging-new/test/jest/README.md
rename : devtools/client/framework/test/jest/jest.config.js => devtools/client/aboutdebugging-new/test/jest/jest.config.js
rename : devtools/client/framework/test/jest/package.json => devtools/client/aboutdebugging-new/test/jest/package.json
extra : moz-landing-system : lando
2019-03-26 17:16:41 +00:00
..
documentation Bug 1524610: Add a document for Reference Browser. r=jdescottes,agi,snorp 2019-03-06 23:57:16 +00:00
src Bug 1505125 - UX implementation of the Sidebar. r=jdescottes,daisuke,Ola,flod 2019-03-26 12:38:48 +00:00
test Bug 1521752 - Create jest test for aboutdebugging-new Message component;r=ladybenko 2019-03-26 17:16:41 +00:00
aboutdebugging.css Bug 1529518: Move worker status to top. r=ladybenko 2019-03-19 11:23:22 +00:00
aboutdebugging.js Bug 1487581 - Remove aboutdebugging.notftl file;r=daisuke 2019-03-20 18:08:18 +00:00
index.html Bug 1500353 - Update localization for document title r=ladybenko,jdescottes 2019-01-11 13:29:56 +00:00
initializer.js Bug 1514594: Part 3 - Change ChromeUtils.import API. 2019-01-17 10:18:31 -08:00
moz.build Bug 1499357 - Move inline script out of new aboutdebugging index.html;r=ladybenko 2018-10-18 16:10:35 +00:00
README.md Bug 1509301. Adding contact info to README.md r=ladybenko 2018-11-26 12:03:45 +00:00

about:debugging-new

What is about:debugging-new

The purpose of about:debugging is to be a debugging hub to start inspecting your addons, processes, tabs and workers. This new version of about:debugging will also allow you to debug remote devices (Firefox for Android on a smartphone). The user should be able to connect either via USB or WiFi. This solution is supposed to replace the various existing remote debugging solutions available in Firefox DevTools, WebIDE and the Connect page.

To try about:debugging-new, the preference devtools.aboutdebugging.new-enabled needs to be set to true in about:config. After that, the UI is available by typing about:debugging in the Firefox URL bar.

Technical overview

The about:debugging-new UI is built using React and Redux. The various React/Redux files should be organized as follows:

  • devtools/client/aboutdebugging-new/src/actions
  • devtools/client/aboutdebugging-new/src/components
  • devtools/client/aboutdebugging-new/src/middleware
  • devtools/client/aboutdebugging-new/src/reducers

The folder devtools/client/aboutdebugging-new/src/modules contains various helpers and classes that are not related to React/Redux. For instance modules/usb-runtimes.js provides an abstraction layer to enable USB runtimes scanning, to list USB runtimes etc...

Firefox Component Registration

about:debugging-new is an "about" page registered via a component manifest that is located in /devtools/startup/aboutdebugging.manifest. The component registration code is at /devtools/startup/aboutdebugging-registration.js and mostly contains the logic to switch between the old and the new about:debugging UI, based on the value of the preference devtools.aboutdebugging.new-enabled.

Actions

Actions should cover all user or external events that change the UI.

asynchronous actions

For asynchronous actions, we will use the thunk middleware, similar to what it done in the webconsole and netmonitor. An asynchronous action should be split in three actions:

  • start
  • success
  • failure

As we will implement asynchronous, we should aim to keep a consistent naming for those actions.

A typical usecase for an asynchronous action here would be selecting a runtime. The selection will be immediate but should trigger actions to retrieve tabs, addons, workers etc… which will all be asynchronous.

Components

Components should avoid dealing with specialized objects as much as possible.

They should never use any of the lifecycle methods that will be deprecated in React 17 (componentWillMount, componentWillReceiveProps, and componentWillUpdate).

When it comes to updating the state, components should do it via an action if the result of this action is something that should be preserved when reloading the UI.

Middlewares

We use several middlewares in the application. The middlewares are required in the create-store module devtools/client/aboutdebugging-new/src/create-store.js.

thunk

This is a shared middleware used by other DevTools modules that allows to dispatch actions and allows to create multiple asynchronous actions.

debug-target-listener

This middleware is responsible for monitoring a client. It will add various listeners on the client when receiving the WATCH_RUNTIME_SUCCESS action and will remove the listeners when receiving UNWATCH_RUNTIME_SUCCESS. Could probably be ported to an action, no real added value as a middleware.

error-logging

This middleware will forward any error object dispatched by an action to the console. Typically, all the FAILURE actions of our asynchronous actions should dispatch an error object.

extension/tab/worker-component-data

This middleware takes the raw data of a debugging target returned by the devtools client and transforms it to presentation data that can be used by the debugtarget components. Could probably be ported to an action, no real added value as a middleware.

waitUntilService

This is a shared middleware used by other DevTools modules that allows to wait until a given action is dispatched. We use it in mochitests.

state

The state represents the model for the UI of the application.

ui

Holds the global state of the application. This can contain generic preferences such as "is feature X enabled" or purely UI related "is category X collapsed".

runtimes

Holds the current list of runtimes known by the application as well as the currently selected runtime.

debug-targets

Holds all the debug targets (ie tabs, addons, workers etc...) for the currently monitored runtime. There is at most one monitored runtime at a given time.

Constants

Constants can be found at devtools/client/aboutdebugging-new/src/constants.js. It contains all the actions available in about:debugging as well as several other "packages" of constants used in the application.

If a constant (string, number, etc...) is only used in a single module it can be defined as a const in this module. However as soon as the constant is shared by several modules, it should move to devtools/client/aboutdebugging-new/src/constants.js.

Types

Types can be found at devtools/client/aboutdebugging-new/src/types.js. They serve both as documentation as well as validation. We do not aim at having types for every single element of the state, but only for complex objects.

Contact

If you have any questions about the code, features, planning, the active team is:

  • engineering: Belén Albeza (:ladybenko)
  • engineering: Daisuke Akatsuka (:daisuke)
  • engineering: Julian Descottes (:jdescottes)
  • engineering: Ola Gasidlo (:ola))
  • engineering management: Soledad Penadés (:sole)
  • product management: Harald Kischner (:digitarald)

You can find us on Slack or IRC on #devtools at irc.mozilla.org.