gecko-dev/dom/html/HTMLOptGroupElement.h
Emilio Cobos Álvarez 51758cfc9b Bug 1829189 - Make OnAttrSetButNotChanged and AfterSetAttr infallible. r=smaug
Same rg + sed shenanigans as the first patch.

There were two that could fail, both due to OOM:

 * HTMLInputElement::AfterSetAttr: If we fail (only in the type=range
   case) we end up with an old value without it being clamped by
   min/max/step.

 * HTMLBodyElement::AfterSetAttr: If we fail we won't peek up the
   DocShell's frame margins and styling could be incorrect.

That seems better than having to deal with broken states after we've
already set the attribute.

Depends on D176069

Differential Revision: https://phabricator.services.mozilla.com/D176070
2023-04-21 08:56:27 +00:00

75 lines
2.4 KiB
C++

/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this file,
* You can obtain one at http://mozilla.org/MPL/2.0/. */
#ifndef mozilla_dom_HTMLOptGroupElement_h
#define mozilla_dom_HTMLOptGroupElement_h
#include "mozilla/Attributes.h"
#include "nsGenericHTMLElement.h"
namespace mozilla {
class ErrorResult;
class EventChainPreVisitor;
namespace dom {
class HTMLOptGroupElement final : public nsGenericHTMLElement {
public:
explicit HTMLOptGroupElement(
already_AddRefed<mozilla::dom::NodeInfo>&& aNodeInfo);
NS_IMPL_FROMNODE_HTML_WITH_TAG(HTMLOptGroupElement, optgroup)
// nsISupports
NS_INLINE_DECL_REFCOUNTING_INHERITED(HTMLOptGroupElement,
nsGenericHTMLElement)
// nsINode
virtual void InsertChildBefore(nsIContent* aKid, nsIContent* aBeforeThis,
bool aNotify, ErrorResult& aRv) override;
virtual void RemoveChildNode(nsIContent* aKid, bool aNotify) override;
// nsIContent
void GetEventTargetParent(EventChainPreVisitor& aVisitor) override;
virtual nsresult Clone(dom::NodeInfo*, nsINode** aResult) const override;
virtual void AfterSetAttr(int32_t aNameSpaceID, nsAtom* aName,
const nsAttrValue* aValue,
const nsAttrValue* aOldValue,
nsIPrincipal* aSubjectPrincipal,
bool aNotify) override;
bool Disabled() const { return GetBoolAttr(nsGkAtoms::disabled); }
void SetDisabled(bool aValue, ErrorResult& aError) {
SetHTMLBoolAttr(nsGkAtoms::disabled, aValue, aError);
}
void GetLabel(nsAString& aValue) const {
GetHTMLAttr(nsGkAtoms::label, aValue);
}
void SetLabel(const nsAString& aLabel, ErrorResult& aError) {
SetHTMLAttr(nsGkAtoms::label, aLabel, aError);
}
protected:
virtual ~HTMLOptGroupElement();
virtual JSObject* WrapNode(JSContext* aCx,
JS::Handle<JSObject*> aGivenProto) override;
protected:
/**
* Get the select content element that contains this option
* @param aSelectElement the select element [OUT]
*/
Element* GetSelect();
};
} // namespace dom
} // namespace mozilla
#endif /* mozilla_dom_HTMLOptGroupElement_h */