Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-22 17:55:50 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
83a923ef7a
gecko-dev/dom/webauthn
History
J.C. Jones 9ca7fca83d Bug 1463170 - Set AuthenticatorAssertionResponse.userHandle to null r=ttaubert r=smaug 
Summary:
The WebAuthn spec says to set `AuthenticatorAssertionResponse.userHandle` to
null when the authenticator returns no user handle (e.g., when allowList is set),
but we return an empty ArrayBuffer. This is because of the defaults in
AuthenticatorAssertionResponse.h, as the field is itself unset.

We missed this change to the spec that happened in December [2], so this also
has a corresponding WebIDL update. I don't see any other instances of WebIDL
differences.

[1] https://w3c.github.io/webauthn/#ref-for-dom-authenticatorassertionresponse-userhandle%E2%91%A0
[2] 3b2a1d141c

Test Plan: https://treeherder.mozilla.org/#/jobs?repo=try&revision=59a2ab255ef14e935c1aa9f457276f8e61e5d779

Reviewers: smaug, ttaubert

Bug #: 1463170

Differential Revision: https://phabricator.services.mozilla.com/D1337

--HG--
extra : amend_source : 966dcd24050585e745078648e1d7995b3beaf9ca
extra : transplant_source : h%3E%B7COQ%F3%05%A9%95%1C%5D%CD%E1XZ%06Z%8D%83
2018-05-21 09:04:50 -07:00
..
cbor-cpp Bug 1380529 - Add a CBOR library for WebAuthn (1/3) r=ttaubert 2017-07-13 18:12:57 -07:00
libudev-sys Bug 1449034 - Update Rust crates to use lazy_static 1.0. r=ted 2018-03-26 15:12:56 -07:00
tests Bug 1463170 - Set AuthenticatorAssertionResponse.userHandle to null r=ttaubert r=smaug 2018-05-21 09:04:50 -07:00
u2f-hid-rs Bug 1460301 - Web Authentication - Don't use U2F_PING to initialize tokens r=jcj 2018-05-14 17:37:47 +02:00
AuthenticatorAssertionResponse.cpp Bug 1463170 - Set AuthenticatorAssertionResponse.userHandle to null r=ttaubert r=smaug 2018-05-21 09:04:50 -07:00
AuthenticatorAssertionResponse.h Bug 1407093 - Web Authentication - WD-07 updates for user handles r=jcj,smaug 2017-12-13 11:15:16 +01:00
AuthenticatorAttestationResponse.cpp Bug 1412125, part 2 - Fix dom/ mode lines. r=qdot 2017-10-26 15:08:41 -07:00
AuthenticatorAttestationResponse.h Bug 1412125, part 2 - Fix dom/ mode lines. r=qdot 2017-10-26 15:08:41 -07:00
AuthenticatorResponse.cpp Bug 1412125, part 2 - Fix dom/ mode lines. r=qdot 2017-10-26 15:08:41 -07:00
AuthenticatorResponse.h Bug 1412125, part 2 - Fix dom/ mode lines. r=qdot 2017-10-26 15:08:41 -07:00
moz.build Bug 1430150 - Implement WebAuthentication permission prompts r=jcj,johannh 2018-03-11 18:47:14 +01:00
nsIU2FTokenManager.idl Bug 1430150 - Implement WebAuthentication permission prompts r=jcj,johannh 2018-03-11 18:47:14 +01:00
PublicKeyCredential.cpp Bug 1406471 - Web Authentication - Implement FIDO AppID Extension r=jcj,smaug 2018-02-22 10:53:49 +01:00
PublicKeyCredential.h Bug 1406471 - Web Authentication - Implement FIDO AppID Extension r=jcj,smaug 2018-02-22 10:53:49 +01:00
PWebAuthnTransaction.ipdl Bug 1430150 - Implement WebAuthentication permission prompts r=jcj,johannh 2018-03-11 18:47:14 +01:00
U2FHIDTokenManager.cpp Bug 1444547 - Propagate proper error codes from u2f-hid-rs to WebAuthn r=jcj 2018-03-14 14:09:02 +01:00
U2FHIDTokenManager.h Bug 1444547 - Propagate proper error codes from u2f-hid-rs to WebAuthn r=jcj 2018-03-14 14:09:02 +01:00
U2FSoftTokenManager.cpp Bug 1460767 - Return device ineligible when appropriate for U2F r=ttaubert 2018-05-10 16:36:18 -07:00
U2FSoftTokenManager.h Bug 1439856 - U2FTokenTransport interface should use WebAuthn*Info types defined in the .pidl r=jcj 2018-02-22 22:09:00 +01:00
U2FTokenManager.cpp Bug 1430150 - Implement WebAuthentication permission prompts r=jcj,johannh 2018-03-11 18:47:14 +01:00
U2FTokenManager.h Bug 1430150 - Implement WebAuthentication permission prompts r=jcj,johannh 2018-03-11 18:47:14 +01:00
U2FTokenTransport.h Bug 1439856 - U2FTokenTransport interface should use WebAuthn*Info types defined in the .pidl r=jcj 2018-02-22 22:09:00 +01:00
WebAuthnCBORUtil.cpp Bug 1416056 - Web Authentication - Default to "None Attestation" r=jcj 2018-02-09 16:34:39 +01:00
WebAuthnCBORUtil.h Bug 1416056 - Web Authentication - Default to "None Attestation" r=jcj 2018-02-09 16:34:39 +01:00
WebAuthnCoseIdentifiers.h Bug 1412125, part 2 - Fix dom/ mode lines. r=qdot 2017-10-26 15:08:41 -07:00
WebAuthnManager.cpp Bug 1462324 - Remove unused WebAuthnTransaction::mDirectAttestation r=jcj 2018-05-17 18:32:53 +02:00
WebAuthnManager.h Bug 1462324 - Remove unused WebAuthnTransaction::mDirectAttestation r=jcj 2018-05-17 18:32:53 +02:00
WebAuthnManagerBase.cpp Bug 1455055 part 6. Clean up HandleEvent implementations in dom. r=masayuki 2018-04-20 00:49:30 -04:00
WebAuthnManagerBase.h Bug 1437616 - Fix more Windows bustage on a CLOSED TREE r=me 2018-02-12 22:09:38 +01:00
WebAuthnTransactionChild.cpp Bug 1437616 - Use proper WebAuthn result types defined in the .pidl r=jcj 2018-02-12 21:08:54 +01:00
WebAuthnTransactionChild.h Bug 1437616 - Use proper WebAuthn result types defined in the .pidl r=jcj 2018-02-12 21:08:54 +01:00
WebAuthnTransactionParent.cpp Bug 1421616 - Have one WebAuthnManager instance per CredentialsContainer r=jcj 2017-12-05 19:05:06 +01:00
WebAuthnTransactionParent.h Bug 1421616 - Have one WebAuthnManager instance per CredentialsContainer r=jcj 2017-12-05 19:05:06 +01:00
WebAuthnUtil.cpp Bug 1458755 - Web Authentication - Copy flag bits 0 & 1 for Sign operations r=jcj 2018-05-07 11:23:10 +02:00
WebAuthnUtil.h Bug 1406471 - Web Authentication - Implement FIDO AppID Extension r=jcj,smaug 2018-02-22 10:53:49 +01:00