David Major dc67bfc9a3 Bug 1344629 - Part 6: Rewrite unnecessary uses of nsLiteralString. r=dbaron ...

There's an antipattern where nsLiteralString is used as an unnecessary intermediary in converting from CharT* to CharT*,
e.g. CallAFunctionThatTakesACharPointer(NS_LITERAL_CSTRING("foo").get());
or
NS_NAMED_LITERAL_STRING(foo, "abc");
CallAFunctionThatTakesACharPointer(foo.get());

This patch rewrites the callsites that can be trivially changed to use char*/char16_t*.

I'd somewhat like to remove nsTLiteralString::get() altogether, but in code that's less straightforward than these examples, get() is useful enough to keep.

MozReview-Commit-ID: Kh1rUziVllo

--HG--
extra : rebase_source : c21a65694d6e1c42fd88f73632f7ac8f38d005ae

2017-03-14 15:26:27 +13:00

..

build

Bug 1286877 - do not set c-basic-offset for python-mode; r=gps

2016-07-14 10:16:42 -06:00

test

Bug 1335983 - Migrate nsCollation::CreateCollection to use LocaleService::GetAppLocale. r=jfkthame

2017-02-07 12:52:03 -08:00

.eslintrc.js

Bug 1328851 - Enable eslint rule no-undef for storage/. r=mak

2017-01-05 11:54:49 +00:00

FileSystemModule.cpp

Bug 1182996 - Fix and add missing namespace comments. rs=ehsan

2015-07-13 08:25:42 -07:00

FileSystemModule.h

Bug 1164717 - Flatten storage/src/ directory. r=mak

2015-05-19 10:47:33 -07:00

IStorageBindingParamsInternal.h

Bug 1182996 - Fix and add missing namespace comments. rs=ehsan

2015-07-13 08:25:42 -07:00

moz.build

Bug 1341799 - annotate storage/* with BUG_COMPONENT in moz.build files. r=mak

2017-02-23 08:01:50 -05:00

mozIStorageAggregateFunction.idl

Bug 1164717 - Flatten storage/public/ directory. r=mak

2015-05-19 10:47:29 -07:00

mozIStorageAsyncConnection.idl

Bug 1283083 - Cloning a connection should re-attach databases to the clone. r=asuth

2016-06-29 17:33:15 +02:00

mozIStorageAsyncStatement.idl

Bug 1164717 - Flatten storage/public/ directory. r=mak

2015-05-19 10:47:29 -07:00

mozIStorageBaseStatement.idl

Bug 1164717 - Flatten storage/public/ directory. r=mak

2015-05-19 10:47:29 -07:00

mozIStorageBindingParams.idl

Bug 1164717 - Flatten storage/public/ directory. r=mak

2015-05-19 10:47:29 -07:00

mozIStorageBindingParamsArray.idl

Bug 1164717 - Flatten storage/public/ directory. r=mak

2015-05-19 10:47:29 -07:00

mozIStorageCompletionCallback.idl

Bug 1164717 - Flatten storage/public/ directory. r=mak

2015-05-19 10:47:29 -07:00

mozIStorageConnection.idl

Bug 1283083 - Cloning a connection should re-attach databases to the clone. r=asuth

2016-06-29 17:33:15 +02:00

mozIStorageError.idl

Bug 1164717 - Flatten storage/public/ directory. r=mak

2015-05-19 10:47:29 -07:00

mozIStorageFunction.idl

Bug 1164717 - Flatten storage/public/ directory. r=mak

2015-05-19 10:47:29 -07:00

mozIStoragePendingStatement.idl

Bug 1164717 - Flatten storage/public/ directory. r=mak

2015-05-19 10:47:29 -07:00

mozIStorageProgressHandler.idl

Bug 1164717 - Flatten storage/public/ directory. r=mak

2015-05-19 10:47:29 -07:00

mozIStorageResultSet.idl

Bug 1164717 - Flatten storage/public/ directory. r=mak

2015-05-19 10:47:29 -07:00

mozIStorageRow.idl

Bug 1164717 - Flatten storage/public/ directory. r=mak

2015-05-19 10:47:29 -07:00

mozIStorageService.idl

Bug 1164717 - Flatten storage/public/ directory. r=mak

2015-05-19 10:47:29 -07:00

mozIStorageStatement.idl

Bug 1313309 - Remove getColumnDecltype and compile with SQLITE_OMIT_DECLTYPE. r=asuth

2016-11-03 21:04:00 +01:00

mozIStorageStatementCallback.idl

Bug 1164717 - Flatten storage/public/ directory. r=mak

2015-05-19 10:47:29 -07:00

mozIStorageStatementParams.idl

Bug 1164717 - Flatten storage/public/ directory. r=mak

2015-05-19 10:47:29 -07:00

mozIStorageStatementRow.idl

Bug 1164717 - Flatten storage/public/ directory. r=mak

2015-05-19 10:47:29 -07:00

mozIStorageVacuumParticipant.idl

Bug 1164717 - Flatten storage/public/ directory. r=mak

2015-05-19 10:47:29 -07:00

mozIStorageValueArray.idl

Bug 1164717 - Flatten storage/public/ directory. r=mak

2015-05-19 10:47:29 -07:00

mozStorageArgValueArray.cpp

Bug 1305202 - Use NullString() more and remove superfluous Truncates(). r=smaug

2016-09-23 21:10:01 -04:00

mozStorageArgValueArray.h

Bug 1164717 - Flatten storage/src/ directory. r=mak

2015-05-19 10:47:33 -07:00

mozStorageAsyncStatement.cpp

Bug 1060419 - make log_print use Printf.h, r=froydnj

2016-12-15 20:16:31 -07:00

mozStorageAsyncStatement.h

Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat

2015-10-18 01:24:48 -04:00

mozStorageAsyncStatementExecution.cpp

Bug 1331804 - Add more runnable names (r=ehsan)

2017-01-24 16:34:37 -08:00

mozStorageAsyncStatementExecution.h

Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat

2015-10-18 01:24:48 -04:00

mozStorageAsyncStatementJSHelper.cpp

Bug 1332172 - Remove XPC_MAP_WANT_*. r=mccr8.

2017-01-23 13:33:58 +11:00

mozStorageAsyncStatementJSHelper.h

Bug 1164717 - Flatten storage/src/ directory. r=mak

2015-05-19 10:47:33 -07:00

mozStorageAsyncStatementParams.cpp

Bug 1332172 - Remove XPC_MAP_WANT_*. r=mccr8.

2017-01-23 13:33:58 +11:00

mozStorageAsyncStatementParams.h

Bug 1164717 - Flatten storage/src/ directory. r=mak

2015-05-19 10:47:33 -07:00

mozStorageBindingParams.cpp

Bug 964561 - Part 10: Fix a possible leak in BindAdoptedBlobByName()/BindAdoptedBlobByIndex(); r=mak

2016-10-25 21:18:37 +02:00

mozStorageBindingParams.h

Bug 1186791 (part 1) - Replace nsBaseHashtable::EnumerateRead() calls in storage/ with iterators. r=mak.

2015-10-29 16:04:41 -07:00

mozStorageBindingParamsArray.cpp

Bug 1164717 - Flatten storage/src/ directory. r=mak

2015-05-19 10:47:33 -07:00

mozStorageBindingParamsArray.h

Bug 1237151 (part 3) - Remove ignored qualifiers in all remaining code. r=froydnj.

2016-01-05 17:08:45 -08:00

mozStorageConnection.cpp

Bug 1331804 - Add more runnable names (r=ehsan)

2017-01-24 16:34:37 -08:00

mozStorageConnection.h

Bug 1331804 - Add more runnable names (r=ehsan)

2017-01-24 16:34:37 -08:00

mozStorageError.cpp

Bug 1164717 - Flatten storage/src/ directory. r=mak

2015-05-19 10:47:33 -07:00

mozStorageError.h

Bug 1182996 - Fix and add missing namespace comments. rs=ehsan

2015-07-13 08:25:42 -07:00

mozStorageHelper.h

Bug 1299727 - Rename NS_WARN_IF_FALSE as NS_WARNING_ASSERTION. r=erahm.

2016-09-01 15:01:16 +10:00

mozStoragePrivateHelpers.cpp

Bug 1290337 - Part 20: Replace Value parameter to const Value& in storage. r=mak

2016-09-11 18:21:36 +09:00

mozStoragePrivateHelpers.h

Bug 1290337 - Part 20: Replace Value parameter to const Value& in storage. r=mak

2016-09-11 18:21:36 +09:00

mozStorageResultSet.cpp

Bug 1164717 - Flatten storage/src/ directory. r=mak

2015-05-19 10:47:33 -07:00

mozStorageResultSet.h

Bug 1164717 - Flatten storage/src/ directory. r=mak

2015-05-19 10:47:33 -07:00

mozStorageRow.cpp

Bug 1164717 - Flatten storage/src/ directory. r=mak

2015-05-19 10:47:33 -07:00

mozStorageRow.h

Bug 1231378 - part 4 - Fix uninitialized members of classes in netwerk/widget/storage/uriloader/memory/tools, r=smaug

2016-01-12 18:16:59 +00:00

mozStorageService.cpp

Bug 1342441 - Improve the Wrong Sqlite Version message. r=asuth

2017-02-24 17:39:30 +01:00

mozStorageService.h

Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat

2015-10-18 01:24:48 -04:00

mozStorageSQLFunctions.cpp

Bug 1235261 - Part 1: Rename nsAutoTArray to AutoTArray. r=froydnj

2016-02-02 17:36:30 +02:00

mozStorageSQLFunctions.h

Bug 1164717 - Flatten storage/src/ directory. r=mak

2015-05-19 10:47:33 -07:00

mozStorageStatement.cpp

Bug 1060419 - make log_print use Printf.h, r=froydnj

2016-12-15 20:16:31 -07:00

mozStorageStatement.h

Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat

2015-10-18 01:24:48 -04:00

mozStorageStatementData.h

Bug 1164581 - Adding an overload for NS_ProxyRelease that accepts already_AddRefed, and removing all the others. r=bobbyholley

2016-02-10 08:23:00 +01:00

mozStorageStatementJSHelper.cpp

Bug 1332172 - Remove XPC_MAP_WANT_*. r=mccr8.

2017-01-23 13:33:58 +11:00

mozStorageStatementJSHelper.h

Bug 1164717 - Flatten storage/src/ directory. r=mak

2015-05-19 10:47:33 -07:00

mozStorageStatementParams.cpp

Bug 1332172 - Remove XPC_MAP_WANT_*. r=mccr8.

2017-01-23 13:33:58 +11:00

mozStorageStatementParams.h

Bug 1164717 - Flatten storage/src/ directory. r=mak

2015-05-19 10:47:33 -07:00

mozStorageStatementRow.cpp

Bug 1332172 - Remove XPC_MAP_WANT_*. r=mccr8.

2017-01-23 13:33:58 +11:00

mozStorageStatementRow.h

Bug 1164717 - Flatten storage/src/ directory. r=mak

2015-05-19 10:47:33 -07:00

SQLCollations.cpp

Bug 1182996 - Fix and add missing namespace comments. rs=ehsan

2015-07-13 08:25:42 -07:00

SQLCollations.h

Bug 1164717 - Flatten storage/src/ directory. r=mak

2015-05-19 10:47:33 -07:00

SQLiteMutex.h

bug 1244743 - Replace MOZ_NATIVE_X with MOZ_SYSTEM_X. r=gps

2016-02-01 10:49:34 -05:00

StatementCache.h

Bug 1187141 - Replace nsBaseHashtable::Enumerate() calls in storage/ with iterators. r=mak.

2016-01-24 18:09:12 -08:00

storage.h

Bug 1164717 - Flatten storage/public/ directory. r=mak

2015-05-19 10:47:29 -07:00

StorageBaseStatementInternal.cpp

Bug 1293603 (part 2) - Make Run() declarations consistent. r=erahm.

2016-08-08 12:18:10 +10:00

StorageBaseStatementInternal.h

Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat

2015-10-18 01:24:48 -04:00

style.txt

…

TelemetryVFS.cpp

Bug 1330907 - Rename Telemetry::ID to Telemetry::HistogramID. r=dexter

2017-02-16 00:45:15 +05:30

VacuumManager.cpp

Bug 1344629 - Part 6: Rewrite unnecessary uses of nsLiteralString. r=dbaron

2017-03-14 15:26:27 +13:00

VacuumManager.h

Bug 1164717 - Flatten storage/src/ directory. r=mak

2015-05-19 10:47:33 -07:00

Variant_inl.h

Bug 1164717 - Flatten storage/src/ directory. r=mak

2015-05-19 10:47:33 -07:00

Variant.h

Bug 1305202 - Use NullString() more and remove superfluous Truncates(). r=smaug

2016-09-23 21:10:01 -04:00

variantToSQLiteT_impl.h

Bug 1278468 - Fix -Wshadow warnings in storage/ directory. r=mak

2016-06-07 22:08:41 -07:00