Read-only Git mirror of the Mercurial gecko repositories at https://hg.mozilla.org. How to contribute: https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
Go to file
Emilio Cobos Álvarez 83d5691cbc Bug 1614658 - Enable accessibility.mouse_focuses_formcontrol by default. r=mac-reviewers,bradwerth,mstange
This aligns Mac's focus model with other platforms. Matches Chromium, but not
Safari.

Reasons why I think it's worth making this change:

 * Consistency with all other platforms.
 * Makes the :focus-visible implementation more useful.
 * Fixes focus navigation after e.g. clicking a button.
 * Shouldn't cause a lot more outlines to show up (at least not by default).

An example of the second point:

    data:text/html,<button onclick="this.nextElementSibling.focus()">Click</button><button>Imagine I'm a dialog close button or something</button>

In non-macOS platforms, we won't show an outline for the button in that case,
which matches the developer expectations (links below). We don't show the
outline because the focus comes from an element that has been focused by mouse
(and thus didn't show an outline). But on macOS that doesn't work, because the
button is not focused.

For completeness, the actual heuristics for :focus-visible may change a bit as
a result of the discussions in:

  * https://github.com/w3c/csswg-drafts/issues/5885
  * https://github.com/web-platform-tests/wpt/pull/27806

But it's not clear to me how to best define this so it works on the macOS focus
model.

An example of the third point:

    data:text/html,<input type=text><input type=submit><input type=text>

On Safari and Chrome (and Firefox on non-macOS platforms), clicking the button,
then pressing tab, goes to the input on the right. In Firefox on macOS it
doesn't because the button doesn't gain focus nor is selectable.

Differential Revision: https://phabricator.services.mozilla.com/D108808
2021-03-17 22:34:55 +00:00
.cargo Backed out 2 changesets (bug 1698438) for windows build bustages. CLOSED TREE 2021-03-17 14:52:27 +02:00
.vscode
accessible Bug 1699029: Switch to use wrapper-API GetCrossDocParentFrameInProcess() in LocalAccessible::VisibilityState(). r=hiro 2021-03-17 16:09:19 +00:00
browser Bug 1698962 - Land "Pin Firefox" onboarding strings in nightly ahead of changing default in beta r=pdahiya,fluent-reviewers,flod 2021-03-17 21:45:47 +00:00
build Bug 1697863 - Add another Stylo valgrind suppression. r=emilio 2021-03-17 17:15:11 +00:00
caps Bug 1684001 - IsURIInPrefList should be infallible. r=masayuki 2021-03-08 23:36:40 +00:00
chrome Bug 1695162 - Use range-based for instead of custom hashtable iterators. r=xpcom-reviewers,kmag 2021-03-17 15:49:46 +00:00
config Bug 1689597 - Add Fuzzilli support to the build system. r=glandium 2021-03-11 12:13:21 +00:00
devtools Bug 1697338 - Remove unused -moz-default-appearance values -moz-mac-vibrancy-light/dark, and the system colors of the same name. r=emilio 2021-03-17 16:50:08 +00:00
docs Bug 1658876 - [devtools] Avoid including its own cloning and build instructions in docs. r=nchevobbe 2021-03-15 11:41:14 +00:00
docshell Bug 1597499 - Make Session Restore work in Fission, r=nika 2021-03-17 16:43:05 +00:00
dom Bug 1614658 - Enable accessibility.mouse_focuses_formcontrol by default. r=mac-reviewers,bradwerth,mstange 2021-03-17 22:34:55 +00:00
editor Bug 1698734 - Don't create an EventListenerManager just to check for existing listeners. r=smaug 2021-03-16 12:49:44 +00:00
extensions Bug 1695162 - Use range-based for instead of custom hashtable iterators. r=xpcom-reviewers,kmag 2021-03-17 15:49:46 +00:00
gfx Bug 1697724 - Align buffer address in commit_solid_span() r=lsalzman 2021-03-17 21:43:18 +00:00
gradle/wrapper
hal Bug 1694481 - Remove unused android lock screen orientation support. r=aklotz 2021-03-10 22:43:09 +00:00
image Bug 1695162 - Use range-based for instead of custom hashtable iterators. r=xpcom-reviewers,kmag 2021-03-17 15:49:46 +00:00
intl Bug 1696206 - Update documentation for legacy migrations; r=flod 2021-03-17 18:51:01 +00:00
ipc Bug 1695162 - Use range-based for instead of custom hashtable iterators. r=xpcom-reviewers,kmag 2021-03-17 15:49:46 +00:00
js Bug 1691490 - Implement SIMD i64x2.{gt,lt,ge,le}_s instructions. r=lth 2021-03-17 20:07:51 +00:00
layout Bug 1698353. Don't try to restrict the display port base rect of a scroll frame with the display port of the same scroll frame because that doesn't make sense. r=botond 2021-03-17 21:29:22 +00:00
media Bug 1690167 - Change VsprintfLiteral/SprintfLiteral to rely on PrintfTarget. r=nika,Gankra,firefox-build-system-reviewers,mhentges 2021-03-10 23:52:40 +00:00
memory Bug 1698719 - Remove aSkipFrames argument to both FramePointerStackWalk and MozStackWalkThread. r=gsvelto,gerald 2021-03-17 00:21:39 +00:00
mfbt Bug 1571631 - Remove MOZ_MUST_USE definition. r=sg 2021-03-17 03:01:21 +00:00
mobile Bug 1698158 - part 3.2 - Remove unnecessary imports from testharness addons experimental API. r=mixedpuppy 2021-03-16 18:15:41 +00:00
modules Bug 1614658 - Enable accessibility.mouse_focuses_formcontrol by default. r=mac-reviewers,bradwerth,mstange 2021-03-17 22:34:55 +00:00
mozglue Bug 1698719 - Remove aSkipFrames argument to both FramePointerStackWalk and MozStackWalkThread. r=gsvelto,gerald 2021-03-17 00:21:39 +00:00
netwerk Bug 1695162 - Use range-based for instead of custom hashtable iterators. r=xpcom-reviewers,kmag 2021-03-17 15:49:46 +00:00
nsprpub Bug 1694371, Update Firefox to NSPR_4_30_RTM. r=bbeurdouche UPGRADE_NSPR_RELEASE DONTBUILD 2021-03-16 15:15:43 +00:00
other-licenses Bug 1692893 - Minimal patch: Workaround atk extern "C" issue. r=Jamie 2021-02-16 00:40:33 +00:00
parser Bug 1692308 - Add an initial delay to IdleTaskRunner r=smaug 2021-03-12 06:55:46 +00:00
python Bug 1691140, add Task Manager to browser tools menu for proton r=mconley,fluent-reviewers,flod 2021-03-17 15:44:17 +00:00
remote Bug 1698152 - [puppeteer] Improve "Page.close should run beforeunload if asked for" unittest for Firefox. r=remote-protocol-reviewers,jdescottes 2021-03-16 15:38:39 +00:00
security Bug 1665786 - browser_certificateManager.js should wait for the next refresh driver tick instead of relying on the implicit initial waitForCondition timer to wait for strings to be localized, r=keeler. 2021-03-17 17:39:35 +00:00
services Bug 1665420 - Remove legacy BrowserID crypto code. r=markh 2021-03-17 00:38:08 +00:00
servo Bug 1697338 - Remove unused -moz-default-appearance values -moz-mac-vibrancy-light/dark, and the system colors of the same name. r=emilio 2021-03-17 16:50:08 +00:00
startupcache Bug 1688511 - do not use 'else' after 'return'. r=sylvestre 2021-02-04 09:24:19 +00:00
storage Bug 1695162 - Use range-based for instead of custom hashtable iterators. r=xpcom-reviewers,kmag 2021-03-17 15:49:46 +00:00
taskcluster Bug 1694398 Fix raptor-webext tests for benchmarks that were migrated r=perftest-reviewers,sparky 2021-03-17 20:08:53 +00:00
testing Bug 1614658 - Enable accessibility.mouse_focuses_formcontrol by default. r=mac-reviewers,bradwerth,mstange 2021-03-17 22:34:55 +00:00
third_party Bug 1696206 - Vendor fluent.migrate 0.11; r=flod 2021-03-17 18:51:01 +00:00
toolkit Bug 1699124 - Remove toolkit/themes/windows/global/icons/Error.png. r=desktop-theme-reviewers,Itiel 2021-03-17 21:10:59 +00:00
tools Bug 1699188 - [mozlint] Include jsmin now that mozversioncontrol uses it r=ahal 2021-03-17 18:57:03 +00:00
uriloader Bug 1694481 - Remove unused code from exthandler/android. r=droeh,esawin 2021-03-10 22:43:08 +00:00
view Backed out changeset 93fd52dafca2 (bug 1689682) as requested by haik. CLOSED TREE 2021-03-14 04:29:17 +02:00
widget Bug 1697091 - Move SetThemeRegion inside skeleton UI maximization else clause r=tnikkel 2021-03-17 21:12:54 +00:00
xpcom Bug 1695162 - Use range-based for instead of custom hashtable iterators. r=xpcom-reviewers,kmag 2021-03-17 15:49:46 +00:00
xpfe/appshell Bug 1694481 - Remove unused code from exthandler/android. r=droeh,esawin 2021-03-10 22:43:08 +00:00
.arcconfig
.babel-eslint.rc.js
.clang-format
.clang-format-ignore Bug 1686831 - Import glibc printf test cases verbatim. r=mhoye 2021-01-28 09:48:53 +00:00
.cron.yml Bug 1696496 - Disable raptor tests running on windows10-64-ref-hw-2017. r=perftest-reviewers,igoldan 2021-03-11 14:13:09 +00:00
.eslintignore Bug 1690475 - [remote] Reorganize xpcshell and browser chrome tests. r=remote-protocol-reviewers,jdescottes 2021-02-23 17:37:03 +00:00
.eslintrc.js Bug 1696873 - Apply automatic fixes to enable more ESLint rules on remaining docshell xhtml files. r=smaug 2021-03-08 13:41:52 +00:00
.flake8 Bug 1695263 - Vendor in a copy of wptserve that's still Python 2 compatible, r=marionette-reviewers,whimboo 2021-03-03 10:03:05 +00:00
.git-blame-ignore-revs
.gitattributes
.gitignore
.hg-annotate-ignore-revs
.hg-format-source
.hgignore
.hgtags No bug - tagging 396d6048aec7d8118bf31637be4a3f5aa06d74ee with FIREFOX_NIGHTLY_87_END a=release DONTBUILD CLOSED TREE 2021-02-22 12:50:38 +00:00
.lldbinit
.mailmap
.prettierignore Bug 1667276 - Part 3: Load a custom prefs file when running a background task. r=mossop,KrisWright 2021-01-27 22:54:25 +00:00
.prettierrc
.taskcluster.yml Bug 1696944 - Part 3 - Add new image to taskcluster.yml. r=aki 2021-03-17 11:22:02 +00:00
.trackerignore
.yamllint
.ycm_extra_conf.py
aclocal.m4
AUTHORS
build.gradle
Cargo.lock Backed out 2 changesets (bug 1698438) for windows build bustages. CLOSED TREE 2021-03-17 14:52:27 +02:00
Cargo.toml Bug 1698295 - Build glsl with opt-level=2 to improve build times. r=glandium 2021-03-16 14:28:07 +00:00
client.mk Bug 1683797: Removes unnecessary lines from client.mk r=sheehan,firefox-build-system-reviewers,glandium 2021-03-09 14:45:24 +00:00
client.py
CLOBBER
configure.in
configure.py
GNUmakefile
gradle.properties
gradlew
gradlew.bat
LICENSE
mach Bug 1638992 - Run ./mach test with Python 3, r=releng-reviewers,jmaher 2021-03-12 21:10:31 +00:00
mach.ps1
Makefile.in
moz.build
moz.configure Bug 1697098 - Default to --enable-bootstrap for arm64 mac builds. r=firefox-build-system-reviewers,andi,sheehan,mhentges 2021-03-09 21:27:52 +00:00
mozilla-config.h.in
old-configure.in Bug 1698706 - Always add PIC flags to C{,XX}FLAGS. r=firefox-build-system-reviewers,andi,sheehan,mhentges 2021-03-17 02:27:22 +00:00
package-lock.json
package.json
README.txt
settings.gradle
substitute-local-geckoview.gradle
test.mozbuild

An explanation of the Firefox Source Code Directory Structure and links to
project pages with documentation can be found at:

    https://firefox-source-docs.mozilla.org/contributing/directory_structure.html

For information on how to build Firefox from the source code and create the patch see:

    https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html

If you have a question about developing Firefox, and can't find the solution
on https://firefox-source-docs.mozilla.org/, you can try asking your question on Matrix at chat.mozilla.org in `Introduction` (https://chat.mozilla.org/#/room/#introduction:mozilla.org) channel.


Nightly development builds can be downloaded from:

    https://archive.mozilla.org/pub/firefox/nightly/latest-mozilla-central/
            - or -
    https://www.mozilla.org/firefox/channel/desktop/#nightly

Keep in mind that nightly builds, which are used by Firefox developers for
testing, may be buggy.