mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-25 03:05:34 +00:00
4a6ff21ab5
While showing a doorhanger permisison prompt, if the user presses the ESC key we call the secondary action callback, passing in whether any checkbox on the popup notification was checked. In the case of an autoplay-media permission prompt, we have a "remember" checkbox, which is checked by default. So pressing ESC means the user will remember a "block" result for the current site. We believe that users don't expect pressing ESC to result in a remembered decision, they expect pressing ESC to avoid making a decision. So we want to ignore the checkbox when ESC is pressed for autoplay-media. So this patch adds a new PopupNotification behaviour which reports the source of event which caused the action callback to be called. This enables the ESC key press to ignore storing a permission. Note: the change here to not store a permission on ESC press applies to all permissions, not just autoplay-media. MozReview-Commit-ID: IUWFN8LG9VF --HG-- extra : rebase_source : b004bc211177a7bfb6dcea563d75db9a6750b214 |
||
|---|---|---|
| .. | ||
| unit | ||
| browser_permissionsPrompt.html | ||
| browser_permissionsPromptAllow.js | ||
| browser_permissionsPromptDeny.js | ||
| browser_permissionsPromptUnknown.js | ||
| browser.ini | ||
| browserHelpers.js | ||
| head.js | ||
| helpers.js | ||
| mochitest.ini | ||
| test_storage_manager_persist_allow.html | ||
| test_storage_manager_persist_deny.html | ||
| test_storage_manager_persisted.html | ||