gecko-dev/layout
L. David Baron 8487157732 Bug 1308876 - Mark lines dirty when we abort their reflow due to page-break-inside:avoid. r=mats
Both of the changes are needed to fix
layout/reftests/w3c-css/submitted/css21/pagination/moz-css21-float-page-break-inside-avoid-4.html
with the primary patch in bug 1308876.

That patch changes the transfer of NS_FRAME_IS_DIRTY from parent to
child so that it happens at the start of the parent's reflow rather than
later at the start of the child's reflow, which means that frames that
are pulled into a dirty frame during reflow are not marked dirty (and
thus forced to reflow all of their lines).  This means that the primary
patch in bug 1308876 introduces the possibility of non-dirty reflows
during printing, which means we exercise non-dirty relayout code in a
number of tests where we did not do so previously.

Note: This patch passes try on its own, on Linux64 debug.

Writing a simple test for this that fails without the primary patch in
bug 1308876 seems difficult.  ColumnSetFrame responds to
nsReflowStatus::NextInFlowNeedsReflow by marking the next-in-flow
*dirty* (which page frames don't), which makes it hard to test in
columns, at least without nesting.  (Colums probably shouldn't do that,
though, but that's a performance fix for another time.)

MozReview-Commit-ID: JZ3qWTSO2lX
2017-07-12 19:37:11 -07:00
..
base merge mozilla-inbound to mozilla-central a=merge 2017-07-12 11:07:09 +02:00
build Bug 1378712 - Remove all trailing whitespaces r=Ehsan 2017-07-06 14:00:35 +02:00
doc
forms Bug 1380521 - Use a more reliably invalid initial mBSizeOfARow so that we reflow properly if it changes to zero. r=dholbert 2017-07-12 19:37:11 -07:00
generic Bug 1308876 - Mark lines dirty when we abort their reflow due to page-break-inside:avoid. r=mats 2017-07-12 19:37:11 -07:00
inspector Bug 1372464 - Use ComputedValues rather than element to get style rule list. r=heycam 2017-07-10 09:38:58 +10:00
ipc Bug 1379046: Use the correct LayerManager everywhere. r=kats 2017-07-06 19:46:59 -07:00
mathml Bug 1378712 - Remove all trailing whitespaces r=Ehsan 2017-07-06 14:00:35 +02:00
media
painting Bug 1378712 - Remove all trailing whitespaces r=Ehsan 2017-07-06 14:00:35 +02:00
printing Bug 1376026 - fix plumbing of DWrite parameters for Skia fonts to not depend on gfxPlatform. r=jrmuizel 2017-06-30 14:09:05 -04:00
reftests Bug 1380521 - Use a more reliably invalid initial mBSizeOfARow so that we reflow properly if it changes to zero. r=dholbert 2017-07-12 19:37:11 -07:00
style Merge m-c to inbound, a=merge 2017-07-12 18:26:46 -07:00
svg Bug 1379464 - Enable context-paint for mozilla-created webextensions. r=heycam,kmag 2017-07-10 13:34:41 -04:00
tables Backed out changeset 31c43a9ffa8b (bug 1379474) for bustage 2017-07-10 08:06:30 +02:00
tools Bug 1378712 - Remove all trailing whitespaces r=Ehsan 2017-07-06 14:00:35 +02:00
xul Bug 1378712 - Remove all trailing whitespaces r=Ehsan 2017-07-06 14:00:35 +02:00
moz.build