gecko-dev/services/sync
Lina Cambridge be55ac8482 Bug 1615931 - Handle invalid bookmark URLs in new bookmark sync. r=markh,LougeniaBailey
This commit changes `Store::local_row_to_item` to validate local URLs,
and flags items with malformed URLs as invalid. These items are either
replaced with valid remote copies, if they exist, or deleted if not.
Additionally, `BaseBookmarksStore#_calculateIndex` no longer throws
when determining the sort index for an item with an invalid URL.

As an aside, we use the `url` crate to parse URLs. This is the same
crate as used by `MozURL`, which, in turn, backs the JS `URL`
constructor...so URLs should be validated the same way in Rust and JS.

Differential Revision: https://phabricator.services.mozilla.com/D64695

--HG--
extra : moz-landing-system : lando
2020-03-02 02:11:13 +00:00
..
locales Bug 1549049 - Unify Sync Now buttons logic. r=markh,fluent-reviewers,flod 2019-10-11 17:06:57 +00:00
modules Bug 1615931 - Handle invalid bookmark URLs in new bookmark sync. r=markh,LougeniaBailey 2020-03-02 02:11:13 +00:00
modules-testing Bug 1582317 - record the sync storage node type in the sync telemetry ping. r=tcsc 2019-12-14 04:26:05 +00:00
tests Bug 1615931 - Handle invalid bookmark URLs in new bookmark sync. r=markh,LougeniaBailey 2020-03-02 02:11:13 +00:00
tps/extensions/tps Bug 1585211 - Have TPS enable sync when the test user logs in. r=tcsc 2019-10-01 00:32:01 +00:00
components.conf
moz.build Bug 1582023 - Replace "sync disconnect" dialog and local data removal with simple confirmation dialog. r=eoger,flod,fluent-reviewers 2019-09-19 05:59:51 +00:00
SyncComponents.manifest
Weave.jsm Bug 1238810 - Replace {FXA,WEAVE}_CONFIGURED with entries in the telemetry environment. r=chutten,markh,loines 2019-10-25 21:38:01 +00:00