gecko-dev/build/clang-plugin/MustReturnFromCallerChecker.h
Andi-Bogdan Postelnicu eb2b106a8c Bug 1580260 - rework the logic for MustReturnFromCaller checker. r=froydnj
Starting with `Clang-10`, and in particular with `https://reviews.llvm.org/D66404`,
the `CFG` has been reflown in order to reduce discrepancies in destructor calls with
the actual codegen. This has also impacted the order of `CFGStmt` for `ReturnStmt`,
whereas now the AST children of the `ReturnStmt` have precedence other their parent
node.
The purpose of this patch is to fix this and add new supported cases for the `Expr`
that is generated from `ReturnStmt`.

Differential Revision: https://phabricator.services.mozilla.com/D61556

--HG--
extra : moz-landing-system : lando
2020-02-05 08:34:36 +00:00

28 lines
907 B
C++

/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#ifndef MustReturnFromCallerChecker_h__
#define MustReturnFromCallerChecker_h__
#include "RecurseGuard.h"
#include "StmtToBlockMap.h"
#include "Utils.h"
#include "plugin.h"
class MustReturnFromCallerChecker : public BaseCheck {
public:
MustReturnFromCallerChecker(StringRef CheckName,
ContextType *Context = nullptr)
: BaseCheck(CheckName, Context) {}
void registerMatchers(MatchFinder *AstMatcher) override;
void check(const MatchFinder::MatchResult &Result) override;
private:
bool isIgnorable(const Stmt *S);
bool immediatelyReturns(RecurseGuard<const CFGBlock *> Block,
ASTContext *TheContext, size_t FromIdx);
};
#endif