mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-22 01:35:35 +00:00
73ec0ca7ec
Currently an inlined function in a namespace in DWARF will
be given a name comprised of just `namespace::`. This is due
to a logic error in ComputeQualifiedName, where it doesn't
handle an empty `unqualified_name` properly.
We apparently have a fair number of these in our Mac builds,
an example of the DWARF that's being mishandled looks like:
0x117eda40: TAG_namespace [5] *
AT_name( "js" )
AT_decl_file( "../../dist/include/js/Utility.h" )
AT_decl_line( 35 )
0x11808500: TAG_subprogram [251] *
AT_low_pc( 0x0000000002f12110 )
AT_high_pc( 0x0000000002f1216b )
AT_APPLE_omit_frame_ptr( 0x01 )
AT_frame_base( rsp )
AT_abstract_origin( {0x0000000011800a4f}"_ZN2js40TraceManuallyBarrieredGenericPointerEdgeEP8JSTracerPPNS_2gc4CellEPKc" )
AT_MIPS_linkage_name( "_ZN2js40TraceManuallyBarrieredGenericPointerEdgeEP8JSTracerPPNS_2gc4CellEPKc" )
AT_name( "TraceManuallyBarrieredGenericPointerEdge" )
AT_decl_file( "/builds/slave/rel-m-rel-m64_bld-000000000000/build/js/src/gc/Marking.cpp" )
AT_decl_line( 547 )
AT_external( 0x01 )
AT_APPLE_optimized( 0x01 )
AT_inline( DW_INL_inlined )
This turned a few instances of this in the file I was testing on into
`<name omitted>`, which seems to just be a symptom of the
"DW_AT_abstract_origin comes later in the file" issue. (Which is probably
also worth fixing given that it occurs some 29k times when dumping
symbols from Firefox's XUL binary, but it's a separate issue.)
R=mark@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1887033002 .
MozReview-Commit-ID: L3cn5z4FY6M
--HG--
extra : rebase_source : 03ebda4cf2d1179b2180a2817137a5f600f7ad1a
|
||
|---|---|---|
| .. | ||
| breakpad-patches | ||
| breakpad-windows-libxul | ||
| breakpad-windows-standalone | ||
| client | ||
| content | ||
| docs | ||
| google-breakpad | ||
| injector | ||
| test | ||
| tools | ||
| crashreporter.mozbuild | ||
| CrashReports.jsm | ||
| CrashSubmit.jsm | ||
| InjectCrashReporter.cpp | ||
| InjectCrashReporter.h | ||
| jar.mn | ||
| KeyValueParser.jsm | ||
| LoadLibraryRemote.cpp | ||
| LoadLibraryRemote.h | ||
| mac_utils.h | ||
| mac_utils.mm | ||
| moz.build | ||
| nsExceptionHandler.cpp | ||
| nsExceptionHandler.h | ||
| update-breakpad.sh | ||