mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-12-13 18:27:35 +00:00
56be5080d2
The only thing that can explain this is the WM_UPDATEUISTATE state getting out of sync in a way that we think we need to unconditionally show focus indicators for a window. I tried to first make this less error prone (see patch above) but digging more into these messages, I'm pretty sure we just don't need all this code. See: * https://devblogs.microsoft.com/oldnewthing/20130516-00/?p=4343 * https://devblogs.microsoft.com/oldnewthing/20130517-00/?p=4323 In particular, this is intended to be a windows feature to not show keyboard indicators on dialogs until you use the keyboard. But that's how Gecko dialogs behave already due to how :focus-visible behaves as per: https://searchfox.org/mozilla-central/rev/43ee5e789b079e94837a21336e9ce2420658fd19/toolkit/components/prompts/src/CommonDialog.jsm#319 I haven't been able to repro this state, but sounds believable that it could happen after opening a native dialog or so on? The purpose of this code is to implement the 'Underline access keys' in the Keyboard Accessibility control panel of windows. There's an easier way of tracking this, via the SPI_GETKEYBOARDCUES SPI, documented in: https://learn.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-systemparametersinfoa Hook that into LookAndFeel rather than using custom IPC and so on. Differential Revision: https://phabricator.services.mozilla.com/D165578
116 lines
3.6 KiB
C++
116 lines
3.6 KiB
C++
/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
|
|
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#ifndef TABMESSAGE_UTILS_H
|
|
#define TABMESSAGE_UTILS_H
|
|
|
|
#include "ipc/EnumSerializer.h"
|
|
#include "mozilla/RefPtr.h"
|
|
#include "mozilla/dom/Event.h"
|
|
#include "nsIRemoteTab.h"
|
|
#include "nsPIDOMWindow.h"
|
|
#include "nsCOMPtr.h"
|
|
#include "mozilla/dom/EffectsInfo.h"
|
|
#include "mozilla/layers/LayersMessageUtils.h"
|
|
#include "TabMessageTypes.h"
|
|
#include "X11UndefineNone.h"
|
|
|
|
namespace IPC {
|
|
|
|
template <>
|
|
struct ParamTraits<nsSizeMode>
|
|
: public ContiguousEnumSerializer<nsSizeMode, nsSizeMode_Normal,
|
|
nsSizeMode_Invalid> {};
|
|
|
|
template <>
|
|
struct ParamTraits<nsIRemoteTab::NavigationType>
|
|
: public ContiguousEnumSerializerInclusive<
|
|
nsIRemoteTab::NavigationType,
|
|
nsIRemoteTab::NavigationType::NAVIGATE_BACK,
|
|
nsIRemoteTab::NavigationType::NAVIGATE_URL> {};
|
|
|
|
template <>
|
|
struct ParamTraits<mozilla::dom::EffectsInfo> {
|
|
typedef mozilla::dom::EffectsInfo paramType;
|
|
|
|
static void Write(MessageWriter* aWriter, const paramType& aParam) {
|
|
WriteParam(aWriter, aParam.mVisibleRect);
|
|
WriteParam(aWriter, aParam.mRasterScale);
|
|
WriteParam(aWriter, aParam.mTransformToAncestorScale);
|
|
}
|
|
|
|
static bool Read(MessageReader* aReader, paramType* aResult) {
|
|
return ReadParam(aReader, &aResult->mVisibleRect) &&
|
|
ReadParam(aReader, &aResult->mRasterScale) &&
|
|
ReadParam(aReader, &aResult->mTransformToAncestorScale);
|
|
}
|
|
};
|
|
|
|
template <>
|
|
struct ParamTraits<mozilla::WhenToScroll>
|
|
: public ContiguousEnumSerializerInclusive<
|
|
mozilla::WhenToScroll, mozilla::WhenToScroll::Always,
|
|
mozilla::WhenToScroll::IfNotFullyVisible> {};
|
|
|
|
template <>
|
|
struct ParamTraits<mozilla::ScrollFlags>
|
|
: public BitFlagsEnumSerializer<mozilla::ScrollFlags,
|
|
mozilla::ScrollFlags::ALL_BITS> {};
|
|
|
|
template <>
|
|
struct ParamTraits<mozilla::WhereToScroll> {
|
|
using paramType = mozilla::WhereToScroll;
|
|
|
|
static void Write(MessageWriter* aWriter, const paramType& aParam) {
|
|
WriteParam(aWriter, aParam.mPercentage);
|
|
}
|
|
|
|
static bool Read(MessageReader* aReader, paramType* aResult) {
|
|
return ReadParam(aReader, &aResult->mPercentage);
|
|
}
|
|
};
|
|
|
|
template <>
|
|
struct ParamTraits<mozilla::ScrollAxis> {
|
|
typedef mozilla::ScrollAxis paramType;
|
|
|
|
static void Write(MessageWriter* aWriter, const paramType& aParam) {
|
|
WriteParam(aWriter, aParam.mWhereToScroll);
|
|
WriteParam(aWriter, aParam.mWhenToScroll);
|
|
WriteParam(aWriter, aParam.mOnlyIfPerceivedScrollableDirection);
|
|
}
|
|
|
|
static bool Read(MessageReader* aReader, paramType* aResult) {
|
|
if (!ReadParam(aReader, &aResult->mWhereToScroll)) {
|
|
return false;
|
|
}
|
|
if (!ReadParam(aReader, &aResult->mWhenToScroll)) {
|
|
return false;
|
|
}
|
|
|
|
// We can't set mOnlyIfPerceivedScrollableDirection directly since it's
|
|
// a bitfield.
|
|
bool value;
|
|
if (!ReadParam(aReader, &value)) {
|
|
return false;
|
|
}
|
|
aResult->mOnlyIfPerceivedScrollableDirection = value;
|
|
|
|
return true;
|
|
}
|
|
};
|
|
|
|
template <>
|
|
struct ParamTraits<mozilla::dom::EmbedderElementEventType>
|
|
: public ContiguousEnumSerializer<
|
|
mozilla::dom::EmbedderElementEventType,
|
|
mozilla::dom::EmbedderElementEventType::NoEvent,
|
|
mozilla::dom::EmbedderElementEventType::EndGuard_> {};
|
|
|
|
} // namespace IPC
|
|
|
|
#endif // TABMESSAGE_UTILS_H
|