gecko-dev/js
Chris Fallin 4192db83c2 Bug 1610192: Remove unneeded array-index in ObjLiteral array mode. r=mgaudet
The ObjLiteral format allows for names (as atom indices) or numeric
indices to be attached to each property in the literal. The numeric case
is limited to 23 bits by the packed format in memory.

The object-literal case ({}-literal with some numeric indices) already
checks for in-range values before deciding to use the ObjLiteral
infrastructure, but the array case did not check this.

Fortunately, the indices in the array case were only used as a sanity
check for debug-mode assertions, and never for any actual indexing
operation, so no out-of-bounds behavior could result, even before this
fix. However, the sanity-check assert will fire at
object-construction-from-ObjLiteral time in cases where the ObjLiteral
mode should not have been used, because no range check was done at
ObjLiteral-construction time.

This change removes the use of indices for array-mode ObjLiterals
entirely.

Differential Revision: https://phabricator.services.mozilla.com/D60474

--HG--
extra : moz-landing-system : lando
2020-01-21 21:58:46 +00:00
..
ductwork/debugger Bug 1605934 - Use nested namespaces r=sg 2020-01-18 13:48:34 +00:00
examples Bug 1564168 - [jsdbg2] Debugger.prototype.enabled should be removed. 2019-08-19 21:47:05 +00:00
ipc Bug 1600545 - Remove useless inclusions of header files generated from IDL files in accessible/, browser/, caps/, chrome/, devtools/, docshell/, editor/, extensions/, gfx/, hal/, image/, intl/, ipc/, js/, layout/, and media/ r=Ehsan 2019-12-06 09:16:44 +00:00
public Backed out changeset d389e3aa4522 (bug 1424934) as requested by jonco: 2020-01-21 20:40:41 +02:00
rust Bug 1530372 - Part 4: Support nursery allocation for BigInt. r=sfink,jandem 2020-01-06 12:49:45 +00:00
src Bug 1610192: Remove unneeded array-index in ObjLiteral array mode. r=mgaudet 2020-01-21 21:58:46 +00:00
xpconnect Bug 1610064 - Avoid including StyleSheet.h from Document.h. r=nordzilla,firefox-style-system-reviewers 2020-01-21 20:31:05 +00:00
app.mozbuild
ffi.configure
moz.build Bug 1564180 - Integrate SpiderMonkey docs with |mach doc|. r=jimb 2019-11-19 07:28:10 +00:00
moz.configure Bug 1592302: Part 2: Add new regexp files to build behind config option r=mgaudet 2019-12-02 16:13:05 +00:00
sub.configure Bug 1590907 - Make ENABLE_INTL_API and ENABLE_TYPED_OBJECTS into js-config macros. r=sfink,firefox-build-system-reviewers,mshal 2019-11-26 07:25:35 +00:00